Re: [pharo-project/pharo] 20045-No-one-uses-RBLintRule-longDescription-almost-no-one-implements (#130)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo] 20045-No-one-uses-RBLintRule-longDescription-almost-no-one-implements (#130)

pavel-krivanek

Merged #130.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #130."}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/130#event-1227650334"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo] 20045-No-one-uses-RBLintRule-longDescription-almost-no-one-implements (#130)

pavel-krivanek

no, this do not work (a mystery why). Reverting.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"PERSON","message":"@estebanlm in #130: no, this do not work (a mystery why). Reverting."}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/130#issuecomment-326006491"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo] 20045-No-one-uses-RBLintRule-longDescription-almost-no-one-implements (#130)

pavel-krivanek
In reply to this post by pavel-krivanek

The bootstrap process started to load Deprecated70 package soon because of deprecated FileStream. So this extension of the Deprecated70 package breaks it. I will open an issue.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pavel-krivanek in #130: The bootstrap process started to load Deprecated70 package soon because of deprecated FileStream. So this extension of the Deprecated70 package breaks it. I will open an issue. "}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/130#issuecomment-326008649"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo] 20045-No-one-uses-RBLintRule-longDescription-almost-no-one-implements (#130)

pavel-krivanek
In reply to this post by pavel-krivanek

So code in this PR is OK, Pharo packages need to be fixed...


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pavel-krivanek in #130: So code in this PR is OK, Pharo packages need to be fixed..."}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/130#issuecomment-326009214"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [pharo-project/pharo] 20045-No-one-uses-RBLintRule-longDescription-almost-no-one-implements (#130)

pavel-krivanek
In reply to this post by pavel-krivanek

ok, I'm reverting the issue, just let me know when is ready again :)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pharo-project/pharo","title":"pharo-project/pharo","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pharo-project/pharo"}},"updates":{"snippets":[{"icon":"PERSON","message":"@estebanlm in #130: ok, I'm reverting the issue, just let me know when is ready again :)"}],"action":{"name":"View Pull Request","url":"https://github.com/pharo-project/pharo/pull/130#issuecomment-326009533"}}}</script>