Refactoring issue

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Refactoring issue

sebastianconcept
Hey guys,

I'm experiencing something weird when trying to refactor stuff in my amber apps.

It happens when I insert an abstract class. 

Lets say you have something like this:

 Stuff
    Album

So the app works great.

Then, it needs to be refactored to:

  Stuff
     Music
        Album

And the app doesn't load anymore.

:/

In the console I see that some class does not understand _initialize()

but the cause of the problem seems to be that the order of the code isn't right (I'm not 100% sure)

Do you have that problem too?

sebastian

o/
Reply | Threaded
Open this post in threaded view
|

Re: Refactoring issue

Tyler Orida
Yes, somethimes. Mostly the classes then were in the wrong order.

2012/5/23 Sebastian Sastre <[hidden email]>
Hey guys,

I'm experiencing something weird when trying to refactor stuff in my amber apps.

It happens when I insert an abstract class. 

Lets say you have something like this:

 Stuff
    Album

So the app works great.

Then, it needs to be refactored to:

  Stuff
     Music
        Album

And the app doesn't load anymore.

:/

In the console I see that some class does not understand _initialize()

but the cause of the problem seems to be that the order of the code isn't right (I'm not 100% sure)

Do you have that problem too?

sebastian

o/

Reply | Threaded
Open this post in threaded view
|

Re: Refactoring issue

Nicolas Petton
Tyler Orida <[hidden email]> writes:

> Yes, somethimes. Mostly the classes then were in the wrong order.

It shouldn't happen anymore. IIRC Dale improved the exporter to export
classes in dependency order. Is that right Dale?

Nico

>
> 2012/5/23 Sebastian Sastre <[hidden email]>
>
>     Hey guys,
>    
>    
>     I'm experiencing something weird when trying to refactor stuff in
>     my amber apps.
>    
>    
>     It happens when I insert an abstract class. 
>    
>    
>     Lets say you have something like this:
>    
>    
>      Stuff
>         Album
>    
>    
>    
>     So the app works great.
>    
>    
>     Then, it needs to be refactored to:
>    
>    
>       Stuff
>          Music
>             Album
>    
>    
>     And the app doesn't load anymore.
>    
>    
>     :/
>    
>    
>     In the console I see that some class does not understand
>     _initialize()
>    
>    
>     but the cause of the problem seems to be that the order of the
>     code isn't right (I'm not 100% sure)
>    
>    
>     Do you have that problem too?
>    
>    
>     sebastian
>    
>    
>     o/
>
>

--
Nicolas Petton
http://nicolas-petton.fr
Reply | Threaded
Open this post in threaded view
|

Re: Refactoring issue

Dale Henrichs
Yes the load order for classes should be exported in the correct order ... you can verify that by looking at the .st file and ensure that superclasses are loaded first ... if the .st is wrong then it will be interesting to track down the cause ...

Dale

----- Original Message -----
| From: "petton nicolas" <[hidden email]>
| To: [hidden email]
| Sent: Thursday, May 31, 2012 2:22:03 PM
| Subject: Re: [amber-lang] Refactoring issue
|
| Tyler Orida <[hidden email]> writes:
|
| > Yes, somethimes. Mostly the classes then were in the wrong order.
|
| It shouldn't happen anymore. IIRC Dale improved the exporter to
| export
| classes in dependency order. Is that right Dale?
|
| Nico
|
| >
| > 2012/5/23 Sebastian Sastre <[hidden email]>
| >
| >     Hey guys,
| >    
| >    
| >     I'm experiencing something weird when trying to refactor stuff
| >     in
| >     my amber apps.
| >    
| >    
| >     It happens when I insert an abstract class.
| >    
| >    
| >     Lets say you have something like this:
| >    
| >    
| >      Stuff
| >         Album
| >    
| >    
| >    
| >     So the app works great.
| >    
| >    
| >     Then, it needs to be refactored to:
| >    
| >    
| >       Stuff
| >          Music
| >             Album
| >    
| >    
| >     And the app doesn't load anymore.
| >    
| >    
| >     :/
| >    
| >    
| >     In the console I see that some class does not understand
| >     _initialize()
| >    
| >    
| >     but the cause of the problem seems to be that the order of the
| >     code isn't right (I'm not 100% sure)
| >    
| >    
| >     Do you have that problem too?
| >    
| >    
| >     sebastian
| >    
| >    
| >     o/
| >
| >
|
| --
| Nicolas Petton
| http://nicolas-petton.fr
|