Regression with PNGReaderWriter in P6

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Regression with PNGReaderWriter in P6

HilaireFernandes
The code bellow decodes the PNG picture just fine in P3, in P6 it can't!

I suspect changes in PNGReaderWriter>>nextImage
However the version shows no history of edit :(

One should add this code below in a test for PNG.


PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
68 82 0 0 0 48 0 0 0 48 16 6 0 0 0 7 146 37 196 0 0 0 6 98 75 71 68 255
255 255 255 255 255 9 88 247 220 0 0 0 9 112 72 89 115 0 0 0 72 0 0 0 72
0 70 201 107 62 0 0 1 153 73 68 65 84 120 218 237 155 73 110 195 48 12
69 227 162 183 211 9 180 11 130 220 77 39 208 249 210 77 181 8 81 69 19
39 169 255 109 12 35 137 197 255 105 81 244 144 219 13 0 0 0 0 0 116 16
66 8 33 188 94 214 113 120 99 214 151 111 238 1 115 206 57 231 235 178
54 68 10 238 19 112 58 1 189 1 238 158 16 233 25 255 37 117 224 221 141
215 210 193 158 128 83 140 215 210 181 156 0 26 216 169 139 180 155 210
218 50 184 124 126 74 34 122 245 204 234 101 207 224 41 221 145 150 14
49 67 118 77 132 118 220 98 93 208 168 64 107 172 226 18 63 19 91 194
172 103 132 117 124 106 194 117 132 210 227 215 143 103 109 124 65 173 4
181 4 173 149 128 254 223 121 49 190 160 190 6 212 4 126 22 94 12 163 91
173 241 229 112 219 141 188 51 106 184 223 46 139 162 62 3 164 137 49
198 24 253 117 89 219 241 183 145 181 82 180 94 154 192 47 212 248 247
253 209 45 152 102 205 120 36 130 137 182 193 159 19 5 22 233 53 158 126
31 48 209 54 190 181 15 8 189 247 215 71 141 174 25 127 218 243 137 105
168 17 53 99 164 140 247 154 8 183 119 67 139 177 41 165 148 210 117 209
125 233 241 181 16 187 18 158 21 254 124 62 30 247 251 186 241 173 113
122 227 148 70 237 145 100 175 33 210 120 139 207 205 237 232 255 22 71
129 45 16 60 3 158 163 123 6 140 214 74 239 198 207 198 201 189 102 12
151 32 26 128 155 23 150 22 105 189 96 38 181 88 31 211 206 113 163 165
151 109 17 182 110 231 118 213 193 222 5 237 154 8 171 184 217 254 31
176 123 9 114 255 146 177 187 128 224 3 0 0 0 0 192 198 252 0 102 116 72
96 211 171 62 8 0 0 0 0 73 69 78 68 174 66 96 130) asByteArray



--
Dr. Geo
http://drgeo.eu


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Nicolai Hess-3-2


2017-06-18 14:01 GMT+02:00 Hilaire <[hidden email]>:
The code bellow decodes the PNG picture just fine in P3, in P6 it can't!

I suspect changes in PNGReaderWriter>>nextImage
However the version shows no history of edit :(

One should add this code below in a test for PNG.


PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
68 82 0 0 0 48 0 0 0 48 16 6 0 0 0 7 146 37 196 0 0 0 6 98 75 71 68 255
255 255 255 255 255 9 88 247 220 0 0 0 9 112 72 89 115 0 0 0 72 0 0 0 72
0 70 201 107 62 0 0 1 153 73 68 65 84 120 218 237 155 73 110 195 48 12
69 227 162 183 211 9 180 11 130 220 77 39 208 249 210 77 181 8 81 69 19
39 169 255 109 12 35 137 197 255 105 81 244 144 219 13 0 0 0 0 0 116 16
66 8 33 188 94 214 113 120 99 214 151 111 238 1 115 206 57 231 235 178
54 68 10 238 19 112 58 1 189 1 238 158 16 233 25 255 37 117 224 221 141
215 210 193 158 128 83 140 215 210 181 156 0 26 216 169 139 180 155 210
218 50 184 124 126 74 34 122 245 204 234 101 207 224 41 221 145 150 14
49 67 118 77 132 118 220 98 93 208 168 64 107 172 226 18 63 19 91 194
172 103 132 117 124 106 194 117 132 210 227 215 143 103 109 124 65 173 4
181 4 173 149 128 254 223 121 49 190 160 190 6 212 4 126 22 94 12 163 91
173 241 229 112 219 141 188 51 106 184 223 46 139 162 62 3 164 137 49
198 24 253 117 89 219 241 183 145 181 82 180 94 154 192 47 212 248 247
253 209 45 152 102 205 120 36 130 137 182 193 159 19 5 22 233 53 158 126
31 48 209 54 190 181 15 8 189 247 215 71 141 174 25 127 218 243 137 105
168 17 53 99 164 140 247 154 8 183 119 67 139 177 41 165 148 210 117 209
125 233 241 181 16 187 18 158 21 254 124 62 30 247 251 186 241 173 113
122 227 148 70 237 145 100 175 33 210 120 139 207 205 237 232 255 22 71
129 45 16 60 3 158 163 123 6 140 214 74 239 198 207 198 201 189 102 12
151 32 26 128 155 23 150 22 105 189 96 38 181 88 31 211 206 113 163 165
151 109 17 182 110 231 118 213 193 222 5 237 154 8 171 184 217 254 31
176 123 9 114 255 146 177 187 128 224 3 0 0 0 0 192 198 252 0 102 116 72
96 211 171 62 8 0 0 0 0 73 69 78 68 174 66 96 130) asByteArray



--
Dr. Geo
http://drgeo.eu





Works for me in windows 32.
Maybe it is an 32/64 bit vm issue ?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

HilaireFernandes
Aha, so I understand why you have all icons displayed just fine
Some arrays are decoded fine, but most are not.

Damn it.

Anyway the attached example will be fine for a unit test.

Le 18/06/2017 à 14:12, Nicolai Hess a écrit :
>
> Works for me in windows 32.
> Maybe it is an 32/64 bit vm issue ?

--
Dr. Geo
http://drgeo.eu


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Stephane Ducasse-3
Hilaire

what do you mean exactly. Is it working or not?
and where would be problem to fix.

Stef

On Sun, Jun 18, 2017 at 2:16 PM, Hilaire <[hidden email]> wrote:

> Aha, so I understand why you have all icons displayed just fine
> Some arrays are decoded fine, but most are not.
>
> Damn it.
>
> Anyway the attached example will be fine for a unit test.
>
> Le 18/06/2017 à 14:12, Nicolai Hess a écrit :
>>
>> Works for me in windows 32.
>> Maybe it is an 32/64 bit vm issue ?
>
> --
> Dr. Geo
> http://drgeo.eu
>
>

kmo
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

kmo
In reply to this post by HilaireFernandes
Just to confirm - I've tried it - works fine in Linux 32 bit VM - but fails with the 64 bit VM
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

HilaireFernandes
In reply to this post by Stephane Ducasse-3
Le 18/06/2017 à 15:39, Stephane Ducasse a écrit :

> what do you mean exactly. Is it working or not?

It is not working on 64 bits image/vm

> and where would be problem to fix.

No idea

--
Dr. Geo
http://drgeo.eu


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

HilaireFernandes
As a matter of fact, if I drop the original PNG picture in the 64bits
image , it is decoded fine (I am not sure however both the png file and
the bytearray are exactly the same)

It may seems the problem comes from the Byte array representation, just
blind guess.


Le 18/06/2017 à 16:09, Hilaire a écrit :
>> and where would be problem to fix.
> No idea

--
Dr. Geo
http://drgeo.eu

move.png (586 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

David T. Lewis
In reply to this post by HilaireFernandes
Hi Hilaire,

I confirmed this on Squeak, and added a new test based on your example.

The test is at
  http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194766.html,

and the fix is
  http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194767.html

I did not check a Pharo image, but I expect is the same issue for both Pharo
and Squeak. The problem is that PNGReadWriter is making 4 byte large integers,
then passing them as parameters to a primitive. On 64-bit Spur images, the
large integers need to be normalized to turn them into immediate short integers
prior to calling the primitive.

This is a simple change to four methods so you can patch your image locally to
confirm the fix.

HTH,
Dave

On Sun, Jun 18, 2017 at 02:01:08PM +0200, Hilaire wrote:

> The code bellow decodes the PNG picture just fine in P3, in P6 it can't!
>
> I suspect changes in PNGReaderWriter>>nextImage
> However the version shows no history of edit :(
>
> One should add this code below in a test for PNG.
>
>
> PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
> 68 82 0 0 0 48 0 0 0 48 16 6 0 0 0 7 146 37 196 0 0 0 6 98 75 71 68 255
> 255 255 255 255 255 9 88 247 220 0 0 0 9 112 72 89 115 0 0 0 72 0 0 0 72
> 0 70 201 107 62 0 0 1 153 73 68 65 84 120 218 237 155 73 110 195 48 12
> 69 227 162 183 211 9 180 11 130 220 77 39 208 249 210 77 181 8 81 69 19
> 39 169 255 109 12 35 137 197 255 105 81 244 144 219 13 0 0 0 0 0 116 16
> 66 8 33 188 94 214 113 120 99 214 151 111 238 1 115 206 57 231 235 178
> 54 68 10 238 19 112 58 1 189 1 238 158 16 233 25 255 37 117 224 221 141
> 215 210 193 158 128 83 140 215 210 181 156 0 26 216 169 139 180 155 210
> 218 50 184 124 126 74 34 122 245 204 234 101 207 224 41 221 145 150 14
> 49 67 118 77 132 118 220 98 93 208 168 64 107 172 226 18 63 19 91 194
> 172 103 132 117 124 106 194 117 132 210 227 215 143 103 109 124 65 173 4
> 181 4 173 149 128 254 223 121 49 190 160 190 6 212 4 126 22 94 12 163 91
> 173 241 229 112 219 141 188 51 106 184 223 46 139 162 62 3 164 137 49
> 198 24 253 117 89 219 241 183 145 181 82 180 94 154 192 47 212 248 247
> 253 209 45 152 102 205 120 36 130 137 182 193 159 19 5 22 233 53 158 126
> 31 48 209 54 190 181 15 8 189 247 215 71 141 174 25 127 218 243 137 105
> 168 17 53 99 164 140 247 154 8 183 119 67 139 177 41 165 148 210 117 209
> 125 233 241 181 16 187 18 158 21 254 124 62 30 247 251 186 241 173 113
> 122 227 148 70 237 145 100 175 33 210 120 139 207 205 237 232 255 22 71
> 129 45 16 60 3 158 163 123 6 140 214 74 239 198 207 198 201 189 102 12
> 151 32 26 128 155 23 150 22 105 189 96 38 181 88 31 211 206 113 163 165
> 151 109 17 182 110 231 118 213 193 222 5 237 154 8 171 184 217 254 31
> 176 123 9 114 255 146 177 187 128 224 3 0 0 0 0 192 198 252 0 102 116 72
> 96 211 171 62 8 0 0 0 0 73 69 78 68 174 66 96 130) asByteArray
>
>
>
> --
> Dr. Geo
> http://drgeo.eu
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Stephane Ducasse-3
Thanks David.
Once hilaire confirms it can you create a bug entry in pharo bug tracker?

S.

On Sun, Jun 18, 2017 at 9:37 PM, David T. Lewis <[hidden email]> wrote:

> Hi Hilaire,
>
> I confirmed this on Squeak, and added a new test based on your example.
>
> The test is at
>   http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194766.html,
>
> and the fix is
>   http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194767.html
>
> I did not check a Pharo image, but I expect is the same issue for both Pharo
> and Squeak. The problem is that PNGReadWriter is making 4 byte large integers,
> then passing them as parameters to a primitive. On 64-bit Spur images, the
> large integers need to be normalized to turn them into immediate short integers
> prior to calling the primitive.
>
> This is a simple change to four methods so you can patch your image locally to
> confirm the fix.
>
> HTH,
> Dave
>
> On Sun, Jun 18, 2017 at 02:01:08PM +0200, Hilaire wrote:
>> The code bellow decodes the PNG picture just fine in P3, in P6 it can't!
>>
>> I suspect changes in PNGReaderWriter>>nextImage
>> However the version shows no history of edit :(
>>
>> One should add this code below in a test for PNG.
>>
>>
>> PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
>> 68 82 0 0 0 48 0 0 0 48 16 6 0 0 0 7 146 37 196 0 0 0 6 98 75 71 68 255
>> 255 255 255 255 255 9 88 247 220 0 0 0 9 112 72 89 115 0 0 0 72 0 0 0 72
>> 0 70 201 107 62 0 0 1 153 73 68 65 84 120 218 237 155 73 110 195 48 12
>> 69 227 162 183 211 9 180 11 130 220 77 39 208 249 210 77 181 8 81 69 19
>> 39 169 255 109 12 35 137 197 255 105 81 244 144 219 13 0 0 0 0 0 116 16
>> 66 8 33 188 94 214 113 120 99 214 151 111 238 1 115 206 57 231 235 178
>> 54 68 10 238 19 112 58 1 189 1 238 158 16 233 25 255 37 117 224 221 141
>> 215 210 193 158 128 83 140 215 210 181 156 0 26 216 169 139 180 155 210
>> 218 50 184 124 126 74 34 122 245 204 234 101 207 224 41 221 145 150 14
>> 49 67 118 77 132 118 220 98 93 208 168 64 107 172 226 18 63 19 91 194
>> 172 103 132 117 124 106 194 117 132 210 227 215 143 103 109 124 65 173 4
>> 181 4 173 149 128 254 223 121 49 190 160 190 6 212 4 126 22 94 12 163 91
>> 173 241 229 112 219 141 188 51 106 184 223 46 139 162 62 3 164 137 49
>> 198 24 253 117 89 219 241 183 145 181 82 180 94 154 192 47 212 248 247
>> 253 209 45 152 102 205 120 36 130 137 182 193 159 19 5 22 233 53 158 126
>> 31 48 209 54 190 181 15 8 189 247 215 71 141 174 25 127 218 243 137 105
>> 168 17 53 99 164 140 247 154 8 183 119 67 139 177 41 165 148 210 117 209
>> 125 233 241 181 16 187 18 158 21 254 124 62 30 247 251 186 241 173 113
>> 122 227 148 70 237 145 100 175 33 210 120 139 207 205 237 232 255 22 71
>> 129 45 16 60 3 158 163 123 6 140 214 74 239 198 207 198 201 189 102 12
>> 151 32 26 128 155 23 150 22 105 189 96 38 181 88 31 211 206 113 163 165
>> 151 109 17 182 110 231 118 213 193 222 5 237 154 8 171 184 217 254 31
>> 176 123 9 114 255 146 177 187 128 224 3 0 0 0 0 192 198 252 0 102 116 72
>> 96 211 171 62 8 0 0 0 0 73 69 78 68 174 66 96 130) asByteArray
>>
>>
>>
>> --
>> Dr. Geo
>> http://drgeo.eu
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

HilaireFernandes
Hi David, Steph,

The fix works fine on P6 64 bits too!

Thanks

Hilaire

Le 19/06/2017 à 08:10, Stephane Ducasse a écrit :
> Thanks David.
> Once hilaire confirms it can you create a bug entry in pharo bug tracker?
>
> S.

--
Dr. Geo
http://drgeo.eu


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

David T. Lewis
In reply to this post by Stephane Ducasse-3
I opened new issue 20167 for this.

Dave


On Mon, Jun 19, 2017 at 08:10:20AM +0200, Stephane Ducasse wrote:

> Thanks David.
> Once hilaire confirms it can you create a bug entry in pharo bug tracker?
>
> S.
>
> On Sun, Jun 18, 2017 at 9:37 PM, David T. Lewis <[hidden email]> wrote:
> > Hi Hilaire,
> >
> > I confirmed this on Squeak, and added a new test based on your example.
> >
> > The test is at
> >   http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194766.html,
> >
> > and the fix is
> >   http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194767.html
> >
> > I did not check a Pharo image, but I expect is the same issue for both Pharo
> > and Squeak. The problem is that PNGReadWriter is making 4 byte large integers,
> > then passing them as parameters to a primitive. On 64-bit Spur images, the
> > large integers need to be normalized to turn them into immediate short integers
> > prior to calling the primitive.
> >
> > This is a simple change to four methods so you can patch your image locally to
> > confirm the fix.
> >
> > HTH,
> > Dave
> >
> > On Sun, Jun 18, 2017 at 02:01:08PM +0200, Hilaire wrote:
> >> The code bellow decodes the PNG picture just fine in P3, in P6 it can't!
> >>
> >> I suspect changes in PNGReaderWriter>>nextImage
> >> However the version shows no history of edit :(
> >>
> >> One should add this code below in a test for PNG.
> >>
> >>
> >> PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
> >> 68 82 0 0 0 48 0 0 0 48 16 6 0 0 0 7 146 37 196 0 0 0 6 98 75 71 68 255
> >> 255 255 255 255 255 9 88 247 220 0 0 0 9 112 72 89 115 0 0 0 72 0 0 0 72
> >> 0 70 201 107 62 0 0 1 153 73 68 65 84 120 218 237 155 73 110 195 48 12
> >> 69 227 162 183 211 9 180 11 130 220 77 39 208 249 210 77 181 8 81 69 19
> >> 39 169 255 109 12 35 137 197 255 105 81 244 144 219 13 0 0 0 0 0 116 16
> >> 66 8 33 188 94 214 113 120 99 214 151 111 238 1 115 206 57 231 235 178
> >> 54 68 10 238 19 112 58 1 189 1 238 158 16 233 25 255 37 117 224 221 141
> >> 215 210 193 158 128 83 140 215 210 181 156 0 26 216 169 139 180 155 210
> >> 218 50 184 124 126 74 34 122 245 204 234 101 207 224 41 221 145 150 14
> >> 49 67 118 77 132 118 220 98 93 208 168 64 107 172 226 18 63 19 91 194
> >> 172 103 132 117 124 106 194 117 132 210 227 215 143 103 109 124 65 173 4
> >> 181 4 173 149 128 254 223 121 49 190 160 190 6 212 4 126 22 94 12 163 91
> >> 173 241 229 112 219 141 188 51 106 184 223 46 139 162 62 3 164 137 49
> >> 198 24 253 117 89 219 241 183 145 181 82 180 94 154 192 47 212 248 247
> >> 253 209 45 152 102 205 120 36 130 137 182 193 159 19 5 22 233 53 158 126
> >> 31 48 209 54 190 181 15 8 189 247 215 71 141 174 25 127 218 243 137 105
> >> 168 17 53 99 164 140 247 154 8 183 119 67 139 177 41 165 148 210 117 209
> >> 125 233 241 181 16 187 18 158 21 254 124 62 30 247 251 186 241 173 113
> >> 122 227 148 70 237 145 100 175 33 210 120 139 207 205 237 232 255 22 71
> >> 129 45 16 60 3 158 163 123 6 140 214 74 239 198 207 198 201 189 102 12
> >> 151 32 26 128 155 23 150 22 105 189 96 38 181 88 31 211 206 113 163 165
> >> 151 109 17 182 110 231 118 213 193 222 5 237 154 8 171 184 217 254 31
> >> 176 123 9 114 255 146 177 187 128 224 3 0 0 0 0 192 198 252 0 102 116 72
> >> 96 211 171 62 8 0 0 0 0 73 69 78 68 174 66 96 130) asByteArray
> >>
> >>
> >>
> >> --
> >> Dr. Geo
> >> http://drgeo.eu
> >>
> >

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Sven Van Caekenberghe-2
Thx !

> On 19 Jun 2017, at 14:00, David T. Lewis <[hidden email]> wrote:
>
> I opened new issue 20167 for this.
>
> Dave
>
>
> On Mon, Jun 19, 2017 at 08:10:20AM +0200, Stephane Ducasse wrote:
>> Thanks David.
>> Once hilaire confirms it can you create a bug entry in pharo bug tracker?
>>
>> S.
>>
>> On Sun, Jun 18, 2017 at 9:37 PM, David T. Lewis <[hidden email]> wrote:
>>> Hi Hilaire,
>>>
>>> I confirmed this on Squeak, and added a new test based on your example.
>>>
>>> The test is at
>>>  http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194766.html,
>>>
>>> and the fix is
>>>  http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194767.html
>>>
>>> I did not check a Pharo image, but I expect is the same issue for both Pharo
>>> and Squeak. The problem is that PNGReadWriter is making 4 byte large integers,
>>> then passing them as parameters to a primitive. On 64-bit Spur images, the
>>> large integers need to be normalized to turn them into immediate short integers
>>> prior to calling the primitive.
>>>
>>> This is a simple change to four methods so you can patch your image locally to
>>> confirm the fix.
>>>
>>> HTH,
>>> Dave
>>>
>>> On Sun, Jun 18, 2017 at 02:01:08PM +0200, Hilaire wrote:
>>>> The code bellow decodes the PNG picture just fine in P3, in P6 it can't!
>>>>
>>>> I suspect changes in PNGReaderWriter>>nextImage
>>>> However the version shows no history of edit :(
>>>>
>>>> One should add this code below in a test for PNG.
>>>>
>>>>
>>>> PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72
>>>> 68 82 0 0 0 48 0 0 0 48 16 6 0 0 0 7 146 37 196 0 0 0 6 98 75 71 68 255
>>>> 255 255 255 255 255 9 88 247 220 0 0 0 9 112 72 89 115 0 0 0 72 0 0 0 72
>>>> 0 70 201 107 62 0 0 1 153 73 68 65 84 120 218 237 155 73 110 195 48 12
>>>> 69 227 162 183 211 9 180 11 130 220 77 39 208 249 210 77 181 8 81 69 19
>>>> 39 169 255 109 12 35 137 197 255 105 81 244 144 219 13 0 0 0 0 0 116 16
>>>> 66 8 33 188 94 214 113 120 99 214 151 111 238 1 115 206 57 231 235 178
>>>> 54 68 10 238 19 112 58 1 189 1 238 158 16 233 25 255 37 117 224 221 141
>>>> 215 210 193 158 128 83 140 215 210 181 156 0 26 216 169 139 180 155 210
>>>> 218 50 184 124 126 74 34 122 245 204 234 101 207 224 41 221 145 150 14
>>>> 49 67 118 77 132 118 220 98 93 208 168 64 107 172 226 18 63 19 91 194
>>>> 172 103 132 117 124 106 194 117 132 210 227 215 143 103 109 124 65 173 4
>>>> 181 4 173 149 128 254 223 121 49 190 160 190 6 212 4 126 22 94 12 163 91
>>>> 173 241 229 112 219 141 188 51 106 184 223 46 139 162 62 3 164 137 49
>>>> 198 24 253 117 89 219 241 183 145 181 82 180 94 154 192 47 212 248 247
>>>> 253 209 45 152 102 205 120 36 130 137 182 193 159 19 5 22 233 53 158 126
>>>> 31 48 209 54 190 181 15 8 189 247 215 71 141 174 25 127 218 243 137 105
>>>> 168 17 53 99 164 140 247 154 8 183 119 67 139 177 41 165 148 210 117 209
>>>> 125 233 241 181 16 187 18 158 21 254 124 62 30 247 251 186 241 173 113
>>>> 122 227 148 70 237 145 100 175 33 210 120 139 207 205 237 232 255 22 71
>>>> 129 45 16 60 3 158 163 123 6 140 214 74 239 198 207 198 201 189 102 12
>>>> 151 32 26 128 155 23 150 22 105 189 96 38 181 88 31 211 206 113 163 165
>>>> 151 109 17 182 110 231 118 213 193 222 5 237 154 8 171 184 217 254 31
>>>> 176 123 9 114 255 146 177 187 128 224 3 0 0 0 0 192 198 252 0 102 116 72
>>>> 96 211 171 62 8 0 0 0 0 73 69 78 68 174 66 96 130) asByteArray
>>>>
>>>>
>>>>
>>>> --
>>>> Dr. Geo
>>>> http://drgeo.eu
>>>>
>>>
>


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Ben Coman
In reply to this post by David T. Lewis

On Mon, Jun 19, 2017 at 8:00 PM, David T. Lewis <[hidden email]> wrote:
20167

Thanks Dave.   I've cherry-picked those into an integration slice, but I don't have 64-bit to test on.  
@Hilaire, could you test the slice?

cheers -ben
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Stephane Ducasse-3
Thx guys!
We will tag it for a port back to Pharo60.

On Tue, Jun 20, 2017 at 5:05 AM, Ben Coman <[hidden email]> wrote:

>
> On Mon, Jun 19, 2017 at 8:00 PM, David T. Lewis <[hidden email]> wrote:
>>
>> 20167
>
>
> Thanks Dave.   I've cherry-picked those into an integration slice, but I
> don't have 64-bit to test on.
> @Hilaire, could you test the slice?
>
> cheers -ben

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

HilaireFernandes
In reply to this post by Ben Coman
Almost there...

Le 20/06/2017 à 05:05, Ben Coman a écrit :
> @Hilaire, could you test the slice?
>

--
Dr. Geo
http://drgeo.eu

dependencies.png (40K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Stephane Ducasse-3
Did you check if the file is in the inbox repo?

Stef

On Tue, Jun 20, 2017 at 2:21 PM, Hilaire <[hidden email]> wrote:
> Almost there...
>
> Le 20/06/2017 à 05:05, Ben Coman a écrit :
>> @Hilaire, could you test the slice?
>>
>
> --
> Dr. Geo
> http://drgeo.eu

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Sven Van Caekenberghe-2
It is not, Ben has to redo his slice.

> On 20 Jun 2017, at 18:29, Stephane Ducasse <[hidden email]> wrote:
>
> Did you check if the file is in the inbox repo?
>
> Stef
>
> On Tue, Jun 20, 2017 at 2:21 PM, Hilaire <[hidden email]> wrote:
>> Almost there...
>>
>> Le 20/06/2017 à 05:05, Ben Coman a écrit :
>>> @Hilaire, could you test the slice?
>>>
>>
>> --
>> Dr. Geo
>> http://drgeo.eu
>


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

Ben Coman
This is strange, since the slice upload seemed to go smoothly, if a bit slow - but no errors.
I've uploaded the missing mcz, so the existing slice should now work.

cheers -ben


On Wed, Jun 21, 2017 at 12:45 AM, Sven Van Caekenberghe <[hidden email]> wrote:
It is not, Ben has to redo his slice.

> On 20 Jun 2017, at 18:29, Stephane Ducasse <[hidden email]> wrote:
>
> Did you check if the file is in the inbox repo?
>
> Stef
>
> On Tue, Jun 20, 2017 at 2:21 PM, Hilaire <[hidden email]> wrote:
>> Almost there...
>>
>> Le 20/06/2017 à 05:05, Ben Coman a écrit :
>>> @Hilaire, could you test the slice?
>>>
>>
>> --
>> Dr. Geo
>> http://drgeo.eu
>



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Regression with PNGReaderWriter in P6

HilaireFernandes
It is a go here. Thanks


Le 21/06/2017 à 04:56, Ben Coman a écrit :
> This is strange, since the slice upload seemed to go smoothly, if a bit
> slow - but no errors.
> I've uploaded the missing mcz, so the existing slice should now work.
>
> cheers -ben
>

--
Dr. Geo
http://drgeo.eu


Loading...