https://pharo.fogbugz.com/default.asp?15399Fix in inbox: SLICE-Issue-15399-SmalltalkImage-Thin-Proliferation-of-File-Access-Messages-SeanDeNigris.2
### Motivation
There was a proliferation of methods in SmalltalkImage for accessing files like sources, changes, and image. The problems were twofold:
1. The interface was complicated with the only benefit being saving a few characters of typing - not worth it! In particular, #vmDirectory instead of "vm directory" seems particularly not-worth-it.
2. It was encouraging strange code, like in ScriptLoader, where the name was taken, and because we were dealing with strings instead of real file objects, #basenameWithoutIndicator was reimplemented `Smalltalk shortImageName copyUpToLast: $.`. And then CodeHolder `sourcesName := Smalltalk sourcesName asFileReference basename.` was using it to reconstruct a real file object which could easily have been gotten via #imageFile.
### Changes
#### This version
- Deprecate #changesName, #shortImageName, #sourcesName, #vmBinary, and #vmDirectory. Saving a few characters of typing is not worth the complication of interface.
- Move all deprecated methods into Deprecated50 package
- Update all users
- clean up inconsistently named protocols
- [OT]: Enhance #basenameWithoutExtension comment
#### v. 1
- deprecated SmalltalkImage>>imageName
- removed duplicated primitive
- changed wrong comment
Cheers,
Sean
Locked
