[Request for comment] Hermes package
Locked
[Request for comment] Hermes package
 
|
... to all participating authors of the Hermes package:
PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A POLISHED PHARO 7 RELEASE So many uncommented classes in there today... We can do better and we should. I dont ask for detailed documentation but a single comment why the class is there or what it should care about is often already enough. If you have time to write code then you also have the time to write a simple class comment! So please do you homework (which is a general request to authors of other packages as well) Bye T. |
Re: [Request for comment] Hermes package
|
|
Hi, Sorry I have missed the comments. I will add them as soon as possible. You are right we should improve the quality, thanks for checking it and remembering everybody. Cheers, On Wed, Feb 28, 2018 at 10:42 AM, Torsten Bergmann <[hidden email]> wrote: ... to all participating authors of the Hermes package: Pablo Tesone.
[hidden email] |
Re: [Request for comment] Hermes package
|
|
Thanks for the quick feedback. Here is the associated issue: https://pharo.fogbugz.com/f/cases/21442/Add-class-comments-to-Hermes-package
tagged with "Must fix" ;)
Thanks T. Gesendet: Mittwoch, 28. Februar 2018 um 11:02 Uhr
Von: "[hidden email]" <[hidden email]> An: "Pharo Development List" <[hidden email]> Betreff: Re: [Pharo-dev] [Request for comment] Hermes package Hi,
Sorry I have missed the comments. I will add them as soon as possible.
You are right we should improve the quality, thanks for checking it and remembering everybody.
Cheers,
On Wed, Feb 28, 2018 at 10:42 AM, Torsten Bergmann <[hidden email]> wrote:
... to all participating authors of the Hermes package: Pablo Tesone.
[hidden email] |
|
|
In reply to this post by Torsten Bergmann
Side question: What is Hermes?
Alexandre > On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <[hidden email]> wrote: > > ... to all participating authors of the Hermes package: > > PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A > POLISHED PHARO 7 RELEASE > > So many uncommented classes in there today... > > We can do better and we should. I dont ask for detailed documentation > but a single comment why the class is there or what it should care > about is often already enough. > > If you have time to write code then you also have the time to write > a simple class comment! > > So please do you homework (which is a general request to authors > of other packages as well) > > Bye > T. > |
Re: [Request for comment] Hermes package
|
|
Hermes is a private binary format that is used to load compiled code
when there is no compiler during the bootstrap. So basically hermes is loading the compiler to be able to compile other packages. Stef On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel <[hidden email]> wrote: > Side question: What is Hermes? > > Alexandre > >> On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <[hidden email]> wrote: >> >> ... to all participating authors of the Hermes package: >> >> PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A >> POLISHED PHARO 7 RELEASE >> >> So many uncommented classes in there today... >> >> We can do better and we should. I dont ask for detailed documentation >> but a single comment why the class is there or what it should care >> about is often already enough. >> >> If you have time to write code then you also have the time to write >> a simple class comment! >> >> So please do you homework (which is a general request to authors >> of other packages as well) >> >> Bye >> T. >> > > |
Re: [Request for comment] Hermes package
|
|
While it is very bootstrap oriented library it would be better to rename it to BootstapCodeLoader. Or PharoBootstrap-CodeLoader because we already use this prefix 2018-03-01 13:20 GMT+01:00 Stephane Ducasse <[hidden email]>: Hermes is a private binary format that is used to load compiled code |
Re: [Request for comment] Hermes package
|
|
+1
On Thu, Mar 1, 2018 at 2:42 PM, Denis Kudriashov <[hidden email]> wrote: > While it is very bootstrap oriented library it would be better to rename it > to BootstapCodeLoader. > Or PharoBootstrap-CodeLoader because we already use this prefix > > 2018-03-01 13:20 GMT+01:00 Stephane Ducasse <[hidden email]>: >> >> Hermes is a private binary format that is used to load compiled code >> when there is no compiler during the bootstrap. >> So basically hermes is loading the compiler to be able to compile >> other packages. >> >> Stef >> >> On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel >> <[hidden email]> wrote: >> > Side question: What is Hermes? >> > >> > Alexandre >> > >> >> On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <[hidden email]> wrote: >> >> >> >> ... to all participating authors of the Hermes package: >> >> >> >> PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A >> >> POLISHED PHARO 7 RELEASE >> >> >> >> So many uncommented classes in there today... >> >> >> >> We can do better and we should. I dont ask for detailed documentation >> >> but a single comment why the class is there or what it should care >> >> about is often already enough. >> >> >> >> If you have time to write code then you also have the time to write >> >> a simple class comment! >> >> >> >> So please do you homework (which is a general request to authors >> >> of other packages as well) >> >> >> >> Bye >> >> T. >> >> >> > >> > >> > |
Re: [Request for comment] Hermes package
|
|
Nice Idea, I have added comments to the packages, classes and methods. This will be in the new version that will be integrated with the new Traits implementation. I am still cleaning some comments that Denis and Pavel have done and we can integrate it. Then we change the name, I liked BootstrapCodeLoader, I think I can find a non conflicting prefix. Cheers. On Thu, Mar 1, 2018 at 4:29 PM, Stephane Ducasse <[hidden email]> wrote: +1 Pablo Tesone.
[hidden email] |
Re: [Request for comment] Hermes package
|
|
Thanks Pablo this is cool!
On Thu, Mar 1, 2018 at 4:42 PM, [hidden email] <[hidden email]> wrote: > Nice Idea, I have added comments to the packages, classes and methods. This > will be in the new version that will be integrated with the new Traits > implementation. > I am still cleaning some comments that Denis and Pavel have done and we can > integrate it. > > Then we change the name, I liked BootstrapCodeLoader, I think I can find a > non conflicting prefix. > > Cheers. > > On Thu, Mar 1, 2018 at 4:29 PM, Stephane Ducasse <[hidden email]> > wrote: >> >> +1 >> >> On Thu, Mar 1, 2018 at 2:42 PM, Denis Kudriashov <[hidden email]> >> wrote: >> > While it is very bootstrap oriented library it would be better to rename >> > it >> > to BootstapCodeLoader. >> > Or PharoBootstrap-CodeLoader because we already use this prefix >> > >> > 2018-03-01 13:20 GMT+01:00 Stephane Ducasse <[hidden email]>: >> >> >> >> Hermes is a private binary format that is used to load compiled code >> >> when there is no compiler during the bootstrap. >> >> So basically hermes is loading the compiler to be able to compile >> >> other packages. >> >> >> >> Stef >> >> >> >> On Wed, Feb 28, 2018 at 4:55 PM, Alexandre Bergel >> >> <[hidden email]> wrote: >> >> > Side question: What is Hermes? >> >> > >> >> > Alexandre >> >> > >> >> >> On Feb 28, 2018, at 1:42 AM, Torsten Bergmann <[hidden email]> >> >> >> wrote: >> >> >> >> >> >> ... to all participating authors of the Hermes package: >> >> >> >> >> >> PLEASE COMMENT YOUR CLASSES SO WE CAN CLEAN UP AND PREPARE A >> >> >> POLISHED PHARO 7 RELEASE >> >> >> >> >> >> So many uncommented classes in there today... >> >> >> >> >> >> We can do better and we should. I dont ask for detailed >> >> >> documentation >> >> >> but a single comment why the class is there or what it should care >> >> >> about is often already enough. >> >> >> >> >> >> If you have time to write code then you also have the time to write >> >> >> a simple class comment! >> >> >> >> >> >> So please do you homework (which is a general request to authors >> >> >> of other packages as well) >> >> >> >> >> >> Bye >> >> >> T. >> >> >> >> >> > >> >> > >> >> >> > >> > > > > -- > Pablo Tesone. > [hidden email] |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |