STS bug

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

STS bug

Chris Uppal-3
I'm not sure where this should be reported, nor to whom, so I'll write it here
and see what happens...

There is a bug in STS when displaying the difference between two versions of a
package if one of the pre-load (etc) scripts has changed.

To reproduce:  create a package, version it, add a pre-load script, version it
again.  Now browse the differences between the two versions.  You should get
walkbacks (lot's of 'em -- be warned !) from the ListView used to display the
changes.  The problem is that the difference between two scripts seems to be
represented as a vanilla StsChangeNode where the #rightEdition and #leftEdition
are Strings rather than some kind of StsEdition.

As a temporary fix, removing all sends of #leftEdition: and #rightEdition: from
StsPackageEdition>>compareScripts:from:with:from:on: will at least allow the
diff browser to work.  I doubt if that's the correct solution -- I'd expect the
#xxxEdition: to point to the corresponding StsPackageEditions.

    -- chris


Reply | Threaded
Open this post in threaded view
|

Re: STS bug

David Gorisek-2
I have already fixed this bug plus quite a few others. I will send you a
new version of STS via e-mail.

Best regards,

David Gorisek


Chris Uppal wrote:

> I'm not sure where this should be reported, nor to whom, so I'll write it here
> and see what happens...
>
> There is a bug in STS when displaying the difference between two versions of a
> package if one of the pre-load (etc) scripts has changed.
>
> To reproduce:  create a package, version it, add a pre-load script, version it
> again.  Now browse the differences between the two versions.  You should get
> walkbacks (lot's of 'em -- be warned !) from the ListView used to display the
> changes.  The problem is that the difference between two scripts seems to be
> represented as a vanilla StsChangeNode where the #rightEdition and #leftEdition
> are Strings rather than some kind of StsEdition.
>
> As a temporary fix, removing all sends of #leftEdition: and #rightEdition: from
> StsPackageEdition>>compareScripts:from:with:from:on: will at least allow the
> diff browser to work.  I doubt if that's the correct solution -- I'd expect the
> #xxxEdition: to point to the corresponding StsPackageEditions.
>
>     -- chris
>
>


Reply | Threaded
Open this post in threaded view
|

Re: STS bug

Chris Uppal-3
David,

> I have already fixed this bug plus quite a few others. I will send you a
> new version of STS via e-mail.

Thank you.  The email has just arrived.

    -- chris


Reply | Threaded
Open this post in threaded view
|

Re: STS bug

Andy Bower-3
In reply to this post by David Gorisek-2
David, Chris

> I have already fixed this bug plus quite a few others. I will send
> you a new version of STS via e-mail.

I'll release another B2 version (probably PL2) soonish to fix these
problems. I think the changes are probably too great to distribute via
Live Update.

--
Andy Bower
Dolphin Support
www.object-arts.com