Smalltalk › Cincom › VisualWorks

ScrollWrapper>>setOrigin: inappropriately sends "self repairDamages"

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Terry Raymond

ScrollWrapper>>setOrigin: inappropriately sends "self repairDamages"

It appears that in VW 7.9 #setOrigin: was modified to send “self repairDamages”.

Well, under some situations when you maximize the window it is not properly displayed.

Also, repair damages occurs immediately. Generally speaking, this is not a good way

to update the display. An event that causes a model’s state to change should not

update the display but simply update state and then post an invalidate. On the

next event cycle the display should be updated. If some parts of the model immediately

update the display while other post an invalidate you can get a mess.

Terry

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI 02878

(401) 624-4517 [hidden email]

===========================================================

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Thomas Brodt-2

Re: ScrollWrapper>>setOrigin: inappropriately sends "self repairDamages"

I can also confirm that removing the call to repairDamages resolved a problem in our app.

With the invocation of repairDamages, the layout of the subcanvases was messed up. The widgets were painted twice over each other with two different layouts for two different window extents. This effect was new after our port from 7.6 to 7.9.1.

As soon as we changed the setOrigin: method in ScrollWrapper as Terry proposed, the layout was fine again.

Is there an AR for 7.10 for this issue?

Thomas

Am 08.03.2013 20:49, schrieb Terry Raymond:

It appears that in VW 7.9 #setOrigin: was modified to send “self repairDamages”.

Well, under some situations when you maximize the window it is not properly displayed.

Also, repair damages occurs immediately. Generally speaking, this is not a good way

to update the display. An event that causes a model’s state to change should not

update the display but simply update state and then post an invalidate. On the

next event cycle the display should be updated. If some parts of the model immediately

update the display while other post an invalidate you can get a mess.

Terry

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI 02878

(401) 624-4517 [hidden email]

===========================================================
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Maarten Mostert

Re: ScrollWrapper>>setOrigin: inappropriately sends "self repairDamages"

Well If I make this change I find myself with an empty plugable adapter and a black screen ?

@+Maarten,

> "Thomas Brodt" <[hidden email]> |

It appears that in VW 7.9 #setOrigin: was modified to send “self repairDamages”.

Well, under some situations when you maximize the window it is not properly displayed.

Also, repair damages occurs immediately. Generally speaking, this is not a good way

to update the display. An event that causes a model’s state to change should not

update the display but simply update state and then post an invalidate. On the

next event cycle the display should be updated. If some parts of the model immediately

update the display while other post an invalidate you can get a mess.

Terry

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI 02878

(401) 624-4517 [hidden email]

===========================================================

_______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc