Smalltalk › Instantiations

Seaside WASstServerAdaptor bug

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Leo O.

Seaside WASstServerAdaptor bug

Hi All,

I think there is a small but dangerous bug in the WASstServerAdaptor class. The adaptor should respond all requests in a safe threading environment, but the sstRequest instance variable in this part of the #process: method, prevents this.

process: aNativeRequest

| response |

sstRequest := aNativeRequest.

self stats incrementCurrentTransactions.

[ response := super process: aNativeRequest ]

ensure: [ self stats decrementCurrentTransactions ].

^ response

A clean solution could be transform this instance variable into a temporal one, rewriting some others methods in the class to recieve the sstRequest later.

Regards,

Leo

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/-OGrvNwxY6YJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.

John O'Keefe-3

Re: Seaside WASstServerAdaptor bug

Leo -

You are correct and we are already working on a solution.

John

On Friday, March 9, 2012 7:55:54 AM UTC-5, Leo O. wrote:

Hi All,

I think there is a small but dangerous bug in the WASstServerAdaptor class. The adaptor should respond all requests in a safe threading environment, but the sstRequest instance variable in this part of the #process: method, prevents this.

process: aNativeRequest

| response |

sstRequest := aNativeRequest.
self stats incrementCurrentTransactions.
[ response := super process: aNativeRequest ]
ensure: [ self stats decrementCurrentTransactions ].
^ response

A clean solution could be transform this instance variable into a temporal one, rewriting some others methods in the class to recieve the sstRequest later.

Regards,
Leo

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/2InkKIYQwtoJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.

John O'Keefe-3

Re: Seaside WASstServerAdaptor bug (Case 49011)

Leo -

See https://groups.google.com/forum/#!topic/va-smalltalk/bXqrgcnqaeM for a patch.

John

On Friday, March 9, 2012 3:22:21 PM UTC-5, John O'Keefe wrote:

Leo -

You are correct and we are already working on a solution.

John

On Friday, March 9, 2012 7:55:54 AM UTC-5, Leo O. wrote:
Hi All,

I think there is a small but dangerous bug in the WASstServerAdaptor class. The adaptor should respond all requests in a safe threading environment, but the sstRequest instance variable in this part of the #process: method, prevents this.

process: aNativeRequest

| response |

sstRequest := aNativeRequest.
self stats incrementCurrentTransactions.
[ response := super process: aNativeRequest ]
ensure: [ self stats decrementCurrentTransactions ].
^ response

A clean solution could be transform this instance variable into a temporal one, rewriting some others methods in the class to recieve the sstRequest later.

Regards,
Leo

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/cNbcAcvZHgMJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.

Leo O.

Re: Seaside WASstServerAdaptor bug

In reply to this post by Leo O.

Thanks John !

I have just tested it and works fine.

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/lhm8q2yODVsJ.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.