[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Lukas Renggli
Is there a particular reason that you added this method?

As you can see in the method comment of #url: the variable can also
contain a string, so your method does not necessarily return what it
says.

Also consider adding a method comment and tests for any public method.

Lukas

On 21 February 2010 18:41,
<[hidden email]> wrote:

> Gerhard Obermann uploaded a new version of Grease-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>
> ==================== Summary ====================
>
> Name: Grease-Core-obi.29
> Author: obi
> Time: 21 February 2010, 6:43:17 pm
> UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
> Ancestors: Grease-Core-lr.28
>
> - add direct accessing method for url
>
> =============== Diff against Grease-Core-lr.28 ===============
>
> Item was added:
> + ----- Method: GRPackage>>urlSelector (in category 'accessing') -----
> + urlSelector
> +       ^ url!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email [hidden email]
> http://lists.seaside.st/listinfo/commits
>



--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Gerhard Obermann
Because I want to do something like this:

WADevelopment allPackages select: [:each | each urlSelector = #seasideUrl ]

I need all seaside basic packages to be able to update the packages using Gofer.

Gerhard

On Sun, Feb 21, 2010 at 6:56 PM, Lukas Renggli <[hidden email]> wrote:
Is there a particular reason that you added this method?

As you can see in the method comment of #url: the variable can also
contain a string, so your method does not necessarily return what it
says.

Also consider adding a method comment and tests for any public method.

Lukas

On 21 February 2010 18:41,
<[hidden email]> wrote:
> Gerhard Obermann uploaded a new version of Grease-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>
> ==================== Summary ====================
>
> Name: Grease-Core-obi.29
> Author: obi
> Time: 21 February 2010, 6:43:17 pm
> UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
> Ancestors: Grease-Core-lr.28
>
> - add direct accessing method for url
>
> =============== Diff against Grease-Core-lr.28 ===============
>
> Item was added:
> + ----- Method: GRPackage>>urlSelector (in category 'accessing') -----
> + urlSelector
> +       ^ url!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email [hidden email]
> http://lists.seaside.st/listinfo/commits
>



--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev


_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Lukas Renggli
What about

   WADevelopment loadPackages: WADevelopment allPackages

?

We should not misuse internal state for unrelated things. This
happened before with the license that was used to find the the
repository URL, which was really ugly to fix.

Lukas

On 21 February 2010 20:43, Gerhard Obermann <[hidden email]> wrote:

> Because I want to do something like this:
>
> WADevelopment allPackages select: [:each | each urlSelector = #seasideUrl ]
>
> I need all seaside basic packages to be able to update the packages using
> Gofer.
>
> Gerhard
>
> On Sun, Feb 21, 2010 at 6:56 PM, Lukas Renggli <[hidden email]> wrote:
>>
>> Is there a particular reason that you added this method?
>>
>> As you can see in the method comment of #url: the variable can also
>> contain a string, so your method does not necessarily return what it
>> says.
>>
>> Also consider adding a method comment and tests for any public method.
>>
>> Lukas
>>
>> On 21 February 2010 18:41,
>> <[hidden email]> wrote:
>> > Gerhard Obermann uploaded a new version of Grease-Core to project
>> > Seaside 3.0:
>> > http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: Grease-Core-obi.29
>> > Author: obi
>> > Time: 21 February 2010, 6:43:17 pm
>> > UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
>> > Ancestors: Grease-Core-lr.28
>> >
>> > - add direct accessing method for url
>> >
>> > =============== Diff against Grease-Core-lr.28 ===============
>> >
>> > Item was added:
>> > + ----- Method: GRPackage>>urlSelector (in category 'accessing') -----
>> > + urlSelector
>> > +       ^ url!
>> >
>> >
>> > _______________________________________________
>> > commits mailing list
>> > To unsubscribe, email [hidden email]
>> > http://lists.seaside.st/listinfo/commits
>> >
>>
>>
>>
>> --
>> Lukas Renggli
>> http://www.lukas-renggli.ch
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>



--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Julian Fitzell-2
Yeah, just because it's being stored in the Seaside repo, doesn't mean
it's a "seaside basic package" and, conversely, some seaside packages
are not in that repo.

If this is really needed, we should add proper meta-data that
specifies a group or a project or something. But I'm still not really
happy with WAPackage and reluctant to keep adding functionality to it.
:)

Julian

On Sun, Feb 21, 2010 at 2:07 PM, Lukas Renggli <[hidden email]> wrote:

> What about
>
>   WADevelopment loadPackages: WADevelopment allPackages
>
> ?
>
> We should not misuse internal state for unrelated things. This
> happened before with the license that was used to find the the
> repository URL, which was really ugly to fix.
>
> Lukas
>
> On 21 February 2010 20:43, Gerhard Obermann <[hidden email]> wrote:
>> Because I want to do something like this:
>>
>> WADevelopment allPackages select: [:each | each urlSelector = #seasideUrl ]
>>
>> I need all seaside basic packages to be able to update the packages using
>> Gofer.
>>
>> Gerhard
>>
>> On Sun, Feb 21, 2010 at 6:56 PM, Lukas Renggli <[hidden email]> wrote:
>>>
>>> Is there a particular reason that you added this method?
>>>
>>> As you can see in the method comment of #url: the variable can also
>>> contain a string, so your method does not necessarily return what it
>>> says.
>>>
>>> Also consider adding a method comment and tests for any public method.
>>>
>>> Lukas
>>>
>>> On 21 February 2010 18:41,
>>> <[hidden email]> wrote:
>>> > Gerhard Obermann uploaded a new version of Grease-Core to project
>>> > Seaside 3.0:
>>> > http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>>> >
>>> > ==================== Summary ====================
>>> >
>>> > Name: Grease-Core-obi.29
>>> > Author: obi
>>> > Time: 21 February 2010, 6:43:17 pm
>>> > UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
>>> > Ancestors: Grease-Core-lr.28
>>> >
>>> > - add direct accessing method for url
>>> >
>>> > =============== Diff against Grease-Core-lr.28 ===============
>>> >
>>> > Item was added:
>>> > + ----- Method: GRPackage>>urlSelector (in category 'accessing') -----
>>> > + urlSelector
>>> > +       ^ url!
>>> >
>>> >
>>> > _______________________________________________
>>> > commits mailing list
>>> > To unsubscribe, email [hidden email]
>>> > http://lists.seaside.st/listinfo/commits
>>> >
>>>
>>>
>>>
>>> --
>>> Lukas Renggli
>>> http://www.lukas-renggli.ch
>>> _______________________________________________
>>> seaside-dev mailing list
>>> [hidden email]
>>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>>
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>>
>
>
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Gerhard Obermann
WADevelopment loadPackages: WADevelopment allPackages

always loads all packages currently defined in GRPackage.
Mostly I dont want to update all packages at the same time.

E.g. I would prefer to update only the seaside core packages,
and not e.g. Magritte or some seaside addOns.
So adding an instVar to GRPackage would be an option.
Or maybe adding a subclass to GRPackage.

Gerhard




On Sun, Feb 21, 2010 at 11:12 PM, Julian Fitzell <[hidden email]> wrote:
Yeah, just because it's being stored in the Seaside repo, doesn't mean
it's a "seaside basic package" and, conversely, some seaside packages
are not in that repo.

If this is really needed, we should add proper meta-data that
specifies a group or a project or something. But I'm still not really
happy with WAPackage and reluctant to keep adding functionality to it.
:)

Julian

On Sun, Feb 21, 2010 at 2:07 PM, Lukas Renggli <[hidden email]> wrote:
> What about
>
>   WADevelopment loadPackages: WADevelopment allPackages
>
> ?
>
> We should not misuse internal state for unrelated things. This
> happened before with the license that was used to find the the
> repository URL, which was really ugly to fix.
>
> Lukas
>
> On 21 February 2010 20:43, Gerhard Obermann <[hidden email]> wrote:
>> Because I want to do something like this:
>>
>> WADevelopment allPackages select: [:each | each urlSelector = #seasideUrl ]
>>
>> I need all seaside basic packages to be able to update the packages using
>> Gofer.
>>
>> Gerhard
>>
>> On Sun, Feb 21, 2010 at 6:56 PM, Lukas Renggli <[hidden email]> wrote:
>>>
>>> Is there a particular reason that you added this method?
>>>
>>> As you can see in the method comment of #url: the variable can also
>>> contain a string, so your method does not necessarily return what it
>>> says.
>>>
>>> Also consider adding a method comment and tests for any public method.
>>>
>>> Lukas
>>>
>>> On 21 February 2010 18:41,
>>> <[hidden email]> wrote:
>>> > Gerhard Obermann uploaded a new version of Grease-Core to project
>>> > Seaside 3.0:
>>> > http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>>> >
>>> > ==================== Summary ====================
>>> >
>>> > Name: Grease-Core-obi.29
>>> > Author: obi
>>> > Time: 21 February 2010, 6:43:17 pm
>>> > UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
>>> > Ancestors: Grease-Core-lr.28
>>> >
>>> > - add direct accessing method for url
>>> >
>>> > =============== Diff against Grease-Core-lr.28 ===============
>>> >
>>> > Item was added:
>>> > + ----- Method: GRPackage>>urlSelector (in category 'accessing') -----
>>> > + urlSelector
>>> > +       ^ url!
>>> >
>>> >
>>> > _______________________________________________
>>> > commits mailing list
>>> > To unsubscribe, email [hidden email]
>>> > http://lists.seaside.st/listinfo/commits
>>> >
>>>
>>>
>>>
>>> --
>>> Lukas Renggli
>>> http://www.lukas-renggli.ch
>>> _______________________________________________
>>> seaside-dev mailing list
>>> [hidden email]
>>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>>
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>>
>
>
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev


_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

Julian Fitzell-2
I tried having subclasses when I did the Pier and Magritte ports but
it was a pain because you couldn't resolve dependencies from, say,
Magritte packages on Seaside packages.

There used to be a method on WADevelopment that returned the Seaside
packages - seems lukas refactored it away. :) Perhaps we could just
add something like that back?

Can we revert the change that began this discussion in the meantime?
This isn't the highest priority and I think Lukas is right that
#urlSelector is a poor interface (it isn't always a selector).

Julian

On Sun, Feb 21, 2010 at 10:48 PM, Gerhard Obermann <[hidden email]> wrote:

> WADevelopment loadPackages: WADevelopment allPackages
>
> always loads all packages currently defined in GRPackage.
> Mostly I dont want to update all packages at the same time.
>
> E.g. I would prefer to update only the seaside core packages,
> and not e.g. Magritte or some seaside addOns.
> So adding an instVar to GRPackage would be an option.
> Or maybe adding a subclass to GRPackage.
>
> Gerhard
>
>
>
>
> On Sun, Feb 21, 2010 at 11:12 PM, Julian Fitzell <[hidden email]> wrote:
>>
>> Yeah, just because it's being stored in the Seaside repo, doesn't mean
>> it's a "seaside basic package" and, conversely, some seaside packages
>> are not in that repo.
>>
>> If this is really needed, we should add proper meta-data that
>> specifies a group or a project or something. But I'm still not really
>> happy with WAPackage and reluctant to keep adding functionality to it.
>> :)
>>
>> Julian
>>
>> On Sun, Feb 21, 2010 at 2:07 PM, Lukas Renggli <[hidden email]> wrote:
>> > What about
>> >
>> >   WADevelopment loadPackages: WADevelopment allPackages
>> >
>> > ?
>> >
>> > We should not misuse internal state for unrelated things. This
>> > happened before with the license that was used to find the the
>> > repository URL, which was really ugly to fix.
>> >
>> > Lukas
>> >
>> > On 21 February 2010 20:43, Gerhard Obermann <[hidden email]> wrote:
>> >> Because I want to do something like this:
>> >>
>> >> WADevelopment allPackages select: [:each | each urlSelector =
>> >> #seasideUrl ]
>> >>
>> >> I need all seaside basic packages to be able to update the packages
>> >> using
>> >> Gofer.
>> >>
>> >> Gerhard
>> >>
>> >> On Sun, Feb 21, 2010 at 6:56 PM, Lukas Renggli <[hidden email]>
>> >> wrote:
>> >>>
>> >>> Is there a particular reason that you added this method?
>> >>>
>> >>> As you can see in the method comment of #url: the variable can also
>> >>> contain a string, so your method does not necessarily return what it
>> >>> says.
>> >>>
>> >>> Also consider adding a method comment and tests for any public method.
>> >>>
>> >>> Lukas
>> >>>
>> >>> On 21 February 2010 18:41,
>> >>> <[hidden email]> wrote:
>> >>> > Gerhard Obermann uploaded a new version of Grease-Core to project
>> >>> > Seaside 3.0:
>> >>> > http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>> >>> >
>> >>> > ==================== Summary ====================
>> >>> >
>> >>> > Name: Grease-Core-obi.29
>> >>> > Author: obi
>> >>> > Time: 21 February 2010, 6:43:17 pm
>> >>> > UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
>> >>> > Ancestors: Grease-Core-lr.28
>> >>> >
>> >>> > - add direct accessing method for url
>> >>> >
>> >>> > =============== Diff against Grease-Core-lr.28 ===============
>> >>> >
>> >>> > Item was added:
>> >>> > + ----- Method: GRPackage>>urlSelector (in category 'accessing')
>> >>> > -----
>> >>> > + urlSelector
>> >>> > +       ^ url!
>> >>> >
>> >>> >
>> >>> > _______________________________________________
>> >>> > commits mailing list
>> >>> > To unsubscribe, email [hidden email]
>> >>> > http://lists.seaside.st/listinfo/commits
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Lukas Renggli
>> >>> http://www.lukas-renggli.ch
>> >>> _______________________________________________
>> >>> seaside-dev mailing list
>> >>> [hidden email]
>> >>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >>
>> >>
>> >> _______________________________________________
>> >> seaside-dev mailing list
>> >> [hidden email]
>> >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Lukas Renggli
>> > http://www.lukas-renggli.ch
>> > _______________________________________________
>> > seaside-dev mailing list
>> > [hidden email]
>> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

new session

Carlos Crosetti-3
In reply to this post by Lukas Renggli
Hi, I would liket to launch the action from the "New Session" button from an
anchor in my aplicatio, how can I accomplsh that?

Thanks, Carlos


_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

RSRSR2 demo

Carlos Crosetti-3
In reply to this post by Lukas Renggli
Hi, who may provide the steps to launch the R2RSR2 demo, the RRChangesDemo
initialize is not registering the app in the /seaside namespace, regards,
Carlos


_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: RSRSR2 demo

Dale
Carlos,

Try tacking changes.rss (I think, the exact string can be found on the configuration page) onto your URL.

  http://xxx/seaside/changes.rss

Should work...

Dale
----- "Carlos Crosetti" <[hidden email]> wrote:

| Hi, who may provide the steps to launch the R2RSR2 demo, the
| RRChangesDemo
| initialize is not registering the app in the /seaside namespace,
| regards,
| Carlos
|
|
| _______________________________________________
| seaside-dev mailing list
| [hidden email]
| http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: new session

Julian Fitzell-2
In reply to this post by Carlos Crosetti-3
Hi Carlos,

This would be better posted on the seaside list instead of seaside-dev
(which is for discussion about the development *of* Seaside itself),
but to answer your question, something like (untested):

renderContentOn: html
   html anchor
      url: (self application url);
      with: 'New Session'

ought to do it (unless you're using session cookies - then you'd need
a callback to delete the cookie first).

Julian

On Tue, Feb 23, 2010 at 1:49 PM, Carlos Crosetti
<[hidden email]> wrote:

> Hi, I would liket to launch the action from the "New Session" button from an
> anchor in my aplicatio, how can I accomplsh that?
>
> Thanks, Carlos
>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: RSRSR2 demo

Carlos Crosetti-3
In reply to this post by Dale
Thakns Dae.

Incommented RRChangesDemo class >> intitialize.

I need a code review of method RRChangesDemo>>baseUrl as I cannot go further
from a notifier showing at that point.

Carlos

----- Original Message -----
From: "Dale Henrichs" <[hidden email]>
To: "Seaside - developer list" <[hidden email]>
Sent: Tuesday, February 23, 2010 7:18 PM
Subject: Re: [Seaside-dev] RSRSR2 demo


> Carlos,
>
> Try tacking changes.rss (I think, the exact string can be found on the
> configuration page) onto your URL.
>
>  http://xxx/seaside/changes.rss
>
> Should work...
>
> Dale
> ----- "Carlos Crosetti" <[hidden email]> wrote:
>
> | Hi, who may provide the steps to launch the R2RSR2 demo, the
> | RRChangesDemo
> | initialize is not registering the app in the /seaside namespace,
> | regards,
> | Carlos
> |
> |
> | _______________________________________________
> | seaside-dev mailing list
> | [hidden email]
> | http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>


_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev