Smalltalk › Frameworks & Tools › Seaside › Seaside Development

Seaside on Pharo4: nesting exceptions

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Johan Brichau-2

Seaside on Pharo4: nesting exceptions

Hi Philippe,

On Pharo4, the testExceptionHandlerNesting is failing.

It seems that Pharo4 now has the ANSI behavior for exception lookup [3].

Though this test is failing, I still get the expected behavior from WAWalkbackErrorHandler (i.e. opening a debugger on the right spot in the stack).

I think this is because of the workarounds introduced in [1][2].

But then I wonder about what this test is supposed to do: it is now checking for the presence of the non-ANSI lookup behaviour.

Mind that this test also fails on Gemstone, where it was rewritten in a way to not fail.

I was already puzzled by that before actually..

So, what is this failing test supposed to say? :)

[1] https://code.google.com/p/seaside/issues/detail?id=636

[2] https://github.com/SeasideSt/googlecode-seaside-export/issues/636

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Philippe Marschall

Re: Seaside on Pharo4: nesting exceptions

On Sat, Apr 4, 2015 at 3:37 PM, Johan Brichau <[hidden email]> wrote:
> Hi Philippe,
>
> On Pharo4, the testExceptionHandlerNesting is failing.
> It seems that Pharo4 now has the ANSI behavior for exception lookup [3].
>
> Though this test is failing, I still get the expected behavior from
> WAWalkbackErrorHandler (i.e. opening a debugger on the right spot in the
> stack).

I think we should test for this.

> I think this is because of the workarounds introduced in [1][2].
>
> But then I wonder about what this test is supposed to do: it is now checking
> for the presence of the non-ANSI lookup behaviour.

That does not make much sense.

> Mind that this test also fails on Gemstone, where it was rewritten in a way
> to not fail.
> I was already puzzled by that before actually..
>
> So, what is this failing test supposed to say? :)

Dunno.

Cheers
Philippe
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Johan Brichau-2

Re: Seaside on Pharo4: nesting exceptions

Hey Philippe,

You wrote the test :)
Though, understandably, I don’t recall what I wrote 4 years ago either :)

I’ll take another fresh look just to make sure

Johan

> On 06 Apr 2015, at 20:39, Philippe Marschall <[hidden email]> wrote:
>
> On Sat, Apr 4, 2015 at 3:37 PM, Johan Brichau <[hidden email]> wrote:
>> Hi Philippe,
>>
>> On Pharo4, the testExceptionHandlerNesting is failing.
>> It seems that Pharo4 now has the ANSI behavior for exception lookup [3].
>>
>> Though this test is failing, I still get the expected behavior from
>> WAWalkbackErrorHandler (i.e. opening a debugger on the right spot in the
>> stack).
>
> I think we should test for this.
>
>> I think this is because of the workarounds introduced in [1][2].
>>
>> But then I wonder about what this test is supposed to do: it is now checking
>> for the presence of the non-ANSI lookup behaviour.
>
> That does not make much sense.
>
>> Mind that this test also fails on Gemstone, where it was rewritten in a way
>> to not fail.
>> I was already puzzled by that before actually..
>>
>> So, what is this failing test supposed to say? :)
>
> Dunno.
>
> Cheers
> Philippe
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Philippe Marschall

Re: Seaside on Pharo4: nesting exceptions

On Mon, Apr 6, 2015 at 8:48 PM, Johan Brichau <[hidden email]> wrote:
> Hey Philippe,
>
> You wrote the test :)

No, I'm sure I just reformatted it ;-)

> Though, understandably, I don’t recall what I wrote 4 years ago either :)

Funny story, this actually came up last ESUG when Andres Valloud
changed the Pharo exception handling to ANSI during CampSmalltalk.

Cheers
Philippe
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev