Show Actions of a SystemWindow: bug?

Hello!

I was fooling around with the latest rc3 image and I tried to use the "show actions" option in the menu of a SystemWindow and got this:

MessageNotUnderstood: ToolSet class>>openMessageList:name:autoSelect:

ToolSet class(Object)>>doesNotUnderstand: #openMessageList:name:autoSelect:

SystemWindow(Morph)>>showActions

[] in ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent:

BlockClosure>>ensure:

CursorWithMask(Cursor)>>showWhile:

ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent:

ToggleMenuItemMorph(MenuItemMorph)>>mouseUp:

ToggleMenuItemMorph(MenuItemMorph)>>handleMouseUp:

MouseButtonEvent>>sentTo:

...

This is the code in SystemWindow>>showActions:

showActions

"Put up a message list browser of all the code that this morph  

would run for mouseUp, mouseDown, mouseMove, mouseEnter,  

mouseLeave, and  

mouseLinger. tk 9/13/97"

| list cls selector adder |

list := SortedCollection new.

adder := [:mrClass :mrSel | list

add: (MethodReference new setStandardClass: mrClass methodSymbol: mrSel)].

"the eventHandler"

self eventHandler

ifNotNil: [list := self eventHandler methodRefList.

(self eventHandler handlesMouseDown: nil)

ifFalse: [adder value: HandMorph value: #grabMorph:]].

"If not those, then non-default raw events"

#(#keyStroke: #mouseDown: #mouseEnter: #mouseLeave: #mouseMove: #mouseUp: #doButtonAction )

do: [:sel | 

cls := self class whichClassIncludesSelector: sel.

cls

ifNotNil: ["want more than default behavior"

cls == Morph

ifFalse: [adder value: cls value: sel]]].

"The mechanism on a Button"

(self respondsTo: #actionSelector)

ifTrue: ["A button"

selector := self actionSelector.

cls := self target class whichClassIncludesSelector: selector.

cls

ifNotNil: ["want more than default behavior"

cls == Morph

ifFalse: [adder value: cls value: selector]]].

ToolSet openMessageList: list name: 'Actions of ' , self printString autoSelect: false

Shouldn't the last line be MessageSet openMessageList: list name: 'Actions of ' , self printString autoSelect: nil ? I tried it and it seemed to work OK, although I never tried that option before so I don't know what was it's original behaviour.

Cheers!

Carla.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Hello!

I was fooling around with the latest rc3 image and I tried to use the "show actions" option in the menu of a SystemWindow and got this:

MessageNotUnderstood: ToolSet class>>openMessageList:name:autoSelect:

ToolSet class(Object)>>doesNotUnderstand: #openMessageList:name:autoSelect:

SystemWindow(Morph)>>showActions

[] in ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent:

BlockClosure>>ensure:

CursorWithMask(Cursor)>>showWhile:

ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent:

ToggleMenuItemMorph(MenuItemMorph)>>mouseUp:

ToggleMenuItemMorph(MenuItemMorph)>>handleMouseUp:

MouseButtonEvent>>sentTo:

...

This is the code in SystemWindow>>showActions:

ToolSet openMessageList: list name: 'Actions of ' , self printString autoSelect: false

Shouldn't the last line be MessageSet openMessageList: list name: 'Actions of ' , self printString autoSelect: nil ? I tried it and it seemed to work OK, although I never tried that option before so I don't know what was it's original behaviour.

Cheers!

Carla.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Whoops! It is Morph>> showActions :P

I'll submit the bug and the fix :)

I don't usually use that menu either, but I was playing with Morphs and I recalled that I had seen that menu before and it could be usefull. Actually, I didn't remember how to open it, I tried several key combinations until I got it, hehehe.

On Wed, Apr 7, 2010 at 10:45 AM, Stéphane Ducasse <[hidden email]> wrote:

add a bug entry :)

On Apr 7, 2010, at 3:11 PM, Mariano Martinez Peck wrote:

>
>
> 2010/4/6 Carla F. Griggio <[hidden email]>
> Hello!
>
> I was fooling around with the latest rc3 image and I tried to use the "show actions" option in the menu of a SystemWindow and got this:
>
> MessageNotUnderstood: ToolSet class>>openMessageList:name:autoSelect:
> ToolSet class(Object)>>doesNotUnderstand: #openMessageList:name:autoSelect:
> SystemWindow(Morph)>>showActions
> [] in ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent:
> BlockClosure>>ensure:
> CursorWithMask(Cursor)>>showWhile:
> ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent:
> ToggleMenuItemMorph(MenuItemMorph)>>mouseUp:
> ToggleMenuItemMorph(MenuItemMorph)>>handleMouseUp:
> MouseButtonEvent>>sentTo:
> ...
>
> This is the code in SystemWindow>>showActions:
>
>
> Actually, it is Morph >> showActions   ;)
>
>
>
>
>       ToolSet openMessageList: list name: 'Actions of ' , self printString autoSelect: false
>
> Shouldn't the last line be MessageSet openMessageList: list name: 'Actions of ' , self printString autoSelect: nil ? I tried it and it seemed to work OK, although I never tried that option before so I don't know what was it's original behaviour.
>
>
>
> I think your change is correct and it works.
> It is funny it is almost the first time in my life I do a ctrl + click hahaha  I saw that menu one or two times in my life :)
>
> Even more, I checked and it is broken since, at least, Squeak 3.9 haha
>
> So..Carla, can you open a bug ticket and submit the fix ?
>
> http://www.pharo-project.org/community/issue-tracking
>
> Thanks  and good catch!
>
> Mariano
>
>
> Cheers!
> Carla.
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project