Simple warnings in Roassal

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Simple warnings in Roassal

Andre Hora
Hello Alex,

Some simple warnings found in Roassal:

Warning: call #sourceCode instead of #getSource for compiledMethods

ROEaselMorphic>>getExampleSourceFor:
ROEaselMorphic>>scriptPreambuleForMethod:
ROMondrianExample>>methodComplexityFor:on:
ROMondrianExample>>methodComplexityOn:


I can fix if it is ok for you..

regards,

--
Andre Hora

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Simple warnings in Roassal

Andre Hora
Also,

calls to:

self assert: a = b

could be changed to:

 self assert: a equals: b



Here you can find an transformation rule to do that:

Gofer new
  squeaksource: 'FindBugs';
  package: 'MiningLintRules-PharoMigrationAuto';
  load.


On Fri, May 3, 2013 at 2:16 PM, Andre Hora <[hidden email]> wrote:
Hello Alex,

Some simple warnings found in Roassal:

Warning: call #sourceCode instead of #getSource for compiledMethods

ROEaselMorphic>>getExampleSourceFor:
ROEaselMorphic>>scriptPreambuleForMethod:
ROMondrianExample>>methodComplexityFor:on:
ROMondrianExample>>methodComplexityOn:


I can fix if it is ok for you..

regards,

--
Andre Hora



--
Andre Hora

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Simple warnings in Roassal

abergel
In reply to this post by Andre Hora
Hi Andre,

Thanks for this! This is now part of Roassal 1.345

Cheers,
Alexandre


On May 3, 2013, at 8:16 AM, Andre Hora <[hidden email]> wrote:

> Hello Alex,
>
> Some simple warnings found in Roassal:
>
> Warning: call #sourceCode instead of #getSource for compiledMethods
>
> ROEaselMorphic>>getExampleSourceFor:
> ROEaselMorphic>>scriptPreambuleForMethod:
> ROMondrianExample>>methodComplexityFor:on:
> ROMondrianExample>>methodComplexityOn:
>
>
> I can fix if it is ok for you..
>
> regards,
>
> --
> Andre Hora
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev