Small bug in WebUser

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Small bug in WebUser

Martin Polák
Hi Janko,

I found small bug in class WebUser. I'm using Aida6.3-beta1.8  on Pharo and in class WebUser there is method isLoggedIn implemented as follows:

WebUser>>isLoggedIn
        ^self loginHistory notEmpty
                and: [(self loginHistory last at: 1) = #login]

but in class DailyCollection (which is class of loginHistory), there is no such method notEmpty. So I changed it little and now it works:

isLoggedIn
        ^self loginHistory isEmpty not
                and: [(self loginHistory last at: 1) = #login]

Hope it helps.

Martin
_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida
Reply | Threaded
Open this post in threaded view
|

Re: Small bug in WebUser

Janko Mivšek
Martin, thanks a lot for this patch, specially because it happens that I
just encounter this bug few days ago and exception waited to me until I
saw you patch. So you just spare me some time!

This patch is now in Aida and I'll doing interim release with some other
changes right now.

And you now deserve to be on the list of contributors
http://www.aidaweb.si/contributors.html :)

S, Martin Polák piše:

> Hi Janko,
>
> I found small bug in class WebUser. I'm using Aida6.3-beta1.8  on Pharo and in class WebUser there is method isLoggedIn implemented as follows:
>
> WebUser>>isLoggedIn
> ^self loginHistory notEmpty
> and: [(self loginHistory last at: 1) = #login]
>
> but in class DailyCollection (which is class of loginHistory), there is no such method notEmpty. So I changed it little and now it works:
>
> isLoggedIn
> ^self loginHistory isEmpty not
> and: [(self loginHistory last at: 1) = #login]
>
> Hope it helps.
>
> Martin
> _______________________________________________
> Aida mailing list
> [hidden email]
> http://lists.aidaweb.si/mailman/listinfo/aida
>

--
Janko Mivšek
Aida/Web
Smalltalk Web Application Server
http://www.aidaweb.si
_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida
Reply | Threaded
Open this post in threaded view
|

Re: Small bug in WebUser

Martin Polák
Janko, it's great to hear, that my little patch helped you. I'm proud Aida contributor now :)

Martin


8. 8. 2011 v 11:09, Janko Mivšek:

> Martin, thanks a lot for this patch, specially because it happens that I
> just encounter this bug few days ago and exception waited to me until I
> saw you patch. So you just spare me some time!
>
> This patch is now in Aida and I'll doing interim release with some other
> changes right now.
>
> And you now deserve to be on the list of contributors
> http://www.aidaweb.si/contributors.html :)
>

_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida