SmallLint journey: another rule :)

Hi

I'm trying the Temporaries read before written and I have the impression that I found a bug in the
RBReadBeforeWrittenTester class
because it flags connections (but connections is not a temp but an instance variable).

Did anybody experience the same?

Stef

listenLoop
        "Private! This loop is run in a separate process. It will establish up to maxQueueLength connections on the given port."
        "Details: When out of sockets or queue is full, retry more frequently, since a socket may become available, space may open in the queue, or a previously queued connection may be aborted by the client, making it available for a fresh connection."
        "Note: If the machine is disconnected from the network while the server is running, the currently waiting socket will go from 'isWaitingForConnection' to 'unconnected', and attempts to create new sockets will fail. When this happens, delete the broken socket and keep trying to create a socket in case the network connection is re-established. Connecting and disconnecting was tested under PPP on Mac system 8.1. It is not if this will work on other platforms.
       
        Fixed to not accept the connection if the queue is full (gvc)."


        | newConnection |

        socket := Socket newTCP.
        "We'll accept four simultanous connections at the same time"
        socket listenOn: portNumber backlogSize: 4.
        "If the listener is not valid then the we cannot use the
        BSD style accept() mechanism."
        socket isValid ifFalse: [^self oldStyleListenLoop].
        [true] whileTrue: [
                socket isValid ifFalse: [
                        "socket has stopped listening for some reason"
                        socket destroy.
                        (Delay forMilliseconds: 10) wait.
                        ^self listenLoop ].
                [newConnection := socket waitForAcceptFor: 10]
                        on: ConnectionTimedOut
                        do: [:ex | newConnection := nil].
                (newConnection notNil and: [newConnection isConnected])
                                ifTrue: [(accessSema critical: [connections size < maxQueueLength])
                                                                                ^^^^^^^^^^



                                                ifFalse: [newConnection close. newConnection := nil]]
                        ifFalse: [newConnection := nil].
                (newConnection notNil and: [newConnection isConnected]) ifTrue: [
                        accessSema critical: [connections addLast: newConnection].
                        newConnection := nil.
                        self changed].
                self pruneStaleConnections].

Jan's experience on it :)

!RBTempsReadBeforeWrittenRule class methodsFor:'accessing'!

tagsBasic
    "Return an array of tags (symbols) of given rule. Any rule may
     arbitrary number of tags. Tag values are not predefined/fixed.
     See class documentation for list of common tags"

    ^#( #broken )


On Jan 22, 2013, at 4:16 PM, Stéphane Ducasse wrote:

On 22 Jan 2013, at 20:16, Stéphane Ducasse <[hidden email]> wrote:

> Hi
>
> I'm trying the Temporaries read before written and I have the impression that I found a bug in the
> RBReadBeforeWrittenTester class
> because it flags connections (but connections is not a temp but an instance variable).
>
> Did anybody experience the same?

Yes, I have seen it and I didn't understand…