SnapshotCello feedabck

On Aug 9, 2013, at 10:33 PM, Tudor Girba <[hidden email]> wrote:

I just checked, and there is no problem in the images I work with. Try this in the latest Moose 4.8 image:

Gofer new 

smalltalkhubUser: 'girba' project: 'Snapshotcello';

package: 'ConfigurationOfSnapshotcello';

load.

ConfigurationOfSnapshotcello loadStable.

Snapshotcello new 

configurationClass: ConfigurationOfMoose;

        sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos' 

==> 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

Also, as a test, I produced a couple of weeks ago a version of Moose (4.8-snapshot), and this loaded in a fresh Pharo 2.0 image without any problems.

But with the synectique image I have problem.

And in the latest moose image the computation of repository of MooseAlgos was Moose and it was wrong.

Did you try the expressions I sent you?

with the version prior to my modification?

Stef

Cheers,

Doru

On Fri, Aug 9, 2013 at 4:33 PM, Stéphane Ducasse <[hidden email]> wrote:

Doru

I think that repositoryFor: is bogus


self repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.14''
        >  'http://www.smalltalkhub.com/mc/Moose/Moose/main/'
        while it should return
        'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'


self packagesAndRepositoriesFromConfiguration
returns an OrderedCollection(#('ConfigurationOfFourDParser' 'http://smalltalkhub.com/mc/Synectique/FourD/main/') #('ConfigurationOfFourDEntities' 'http://smalltalkhub.com/mc/Synectique/FourD/main/') #('ConfigurationOfSynectiqueBrowser' 'http://www.smalltalkhub.com/mc/Synectique/Core/main/') #('ConfigurationOfSynectiqueEntities' 'http://smalltalkhub.com/mc/Synectique/Core/main/') #('ConfigurationOfBabyMock' 'http://smalltalkhub.com/mc/zeroflag/BabyMock/main/') #('ConfigurationOfMoose' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('BabyMock-Core' 'http://smalltalkhub.com/mc/zeroflag/BabyMock/main/') #('ConfigurationOfFame' 'http://www.smalltalkhub.com/mc/Moose/Fame/main/') #('ConfigurationOfRoassal' 'http://www.smalltalkhub.com/mc/ObjectProfile/Roassal/main/') #('ConfigurationOfXMLParser' 'http://www.smalltalkhub.com/mc/PharoExtras/XMLParser/main/') #('ConfigurationOfPetitParser' 'http://www.smalltalkhub.com/mc/Moose/PetitParser/main/') #('ConfigurationOfSmallDude' 'http://www.smalltalkhub.com/mc/Moose/SmallDude/main/') #('ConfigurationOfGlamour' 'http://www.smalltalkhub.com/mc/Moose/Glamour/main/') #('ConfigurationOfMetanool' 'http://www.smalltalkhub.com/mc/Moose/Metanool/main/') #('ConfigurationOfRoelTyper' 'http://www.smalltalkhub.com/mc/RMoD/RoelTyper/main/') #('ConfigurationOfGToolkit' 'http://www.smalltalkhub.com/mc/Moose/GToolkit/main/') #('ConfigurationOfMooseAlgos' 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/') #('ConfigurationOfMondrian' 'http://www.smalltalkhub.com/mc/Moose/Mondrian/main/') #('ConfigurationOfPetitSQLParser' 'http://www.smalltalkhub.com/mc/Moose/PetitSQLParser/main/') #('ConfigurationOfMerlin' 'http://www.smalltalkhub.com/mc/Moose/Merlin/main/') #('ConfigurationOfDSM' 'http://www.smalltalkhub.com/mc/Moose/DSM/main/') #('ConfigurationOfEyeSee' 'http://www.smalltalkhub.com/mc/Moose/EyeSee/main/') #('OSProcess' 'http://www.squeaksource.com/OSProcess/') #('Moose-Help' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Famix-Specifications' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Arki-Reporter-Core' 'http://www.smalltalkhub.com/mc/Moose/Arki/main/') #('Arki-Tests-Reporter' 'http://www.smalltalkhub.com/mc/Moose/Arki/main/') #('Famix-Tests-C' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Famix-Tests-Extensions' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Dynamix-Tests-Core' 'http://www.smalltalkhub.com/mc/Moose/DynaMoose/main/') #('Moose-TestResources-Reference-Core' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-Reference-PackageOne' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-LAN' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-LCOM' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-CategoryImporter' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P4FullInteracted' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P6InteractedReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P5FullReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P1FullReferencer' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P2InteractedReferencerReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P3InteractedReferencer' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P7ReferencerReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P8FullReferencer' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P9FullReferencer' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P10InteractedReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P11FullReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P12FullReferencer' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P13FullReferencer' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-P14FullReferee' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-KGB-PExtensions' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-PackageBlueprint-P1' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-PackageBlueprint-P2' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-PackageBlueprint-P3' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-TestResources-PackageBlueprint-P4' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('Moose-Tests-MonticelloImporter' 'http://www.smalltalkhub.com/mc/Moose/Moose/main/') #('ConfigurationOfMagritte3' 'http://source.lukas-renggli.ch/magritte3/') #('ConfigurationOfGrease' 'http://www.squeaksource.com/MetacelloRepository/') #('Grease-Core' 'http:/...etc…


I saw that there were some changes in the definition of repositoryFor: compared to the version

We have now

self packagesAndRepositoriesFromConfiguration
                        select: [:each | ( (each first, '*') match: 'ConfigurationOfMooseAlgos')]



And may be it should be

repositoryFor: aString
        ^ (self packagesAndRepositoriesFromConfiguration
                        detect: [:each | ( (each first, '-*') match: aString)]
                        ifNone: [self error: 'No repository found for ', aString]) second


Now I wonder if we could not ask the working copy to get its name
like that we can have

        from the configuration
                #(ConifgurationOfMooseAlgos  'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/')

        and from the working copy

                #(ConifgurationOfMooseAlgos  'ConifgurationOfMooseAlgos-TudorGibar.14')

and we do not have to match.

What do you think?

>>
>> The packages are dirty in the Moose image on jenkins.
>>
>> Are you trying with Pharo 2.0?
>>
>> Did you try with empty package cache?
>> Because I'm retrying with a clean Pharo20 image.
>>
>> In fact I have three problems:
>>      - MooseAlgos repo is not Moose but MooseAlgos and I have to check why.
>>      - I have problem with Metacallo not having the repositories set up and then it cannot resolve packages
>>      - Dependencies order (when I have empty package -
>>              I have Metanool-Core that depends from MooseEntity
>>      :(
>
> I have the impression that the cache does not affect the load so this is already one variable less.
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Doru 

Two points to answers (do not read this email if you are in hurry)

===================================================

Point 1 

=====

can you have a look at at my 23 commit changes?

Because I think that the logic is more robust:

Doing a join is too me more robust than a match.

As I already say it 

we want (version repo package)

and we have 

from the config repo package

and now we are taking from the image version and look for the package with a match

what I did is:

from the config repo package

from the image version package

Like that there is no possibility of mismatch

I will check why I got the other problems. It is probably in the configuration of synectique projects but still

having this match is a source of error. 

Point 2

=======================================================

Then I do not understand why Metanool does not list MooseCore as a dependency?

Could you reply to these points?

Stef

PS: I wrote the following in a previous mail

don't you think that Metanool should depend on Moose? Since it uses MooseEntity. 

baseline10: spec 
<version: '1.0-baseline'>

spec for: #common do: [
spec blessing: #baseline.
spec repository: 'http://www.smalltalkhub.com/mc/Moose/Metanool/main'.
spec
package: 'Metanool-Core' with: [spec requires: #('Fame' 'Magritte3')];
package: 'Metanool-Tests-Core' with: [spec requires: #('Metanool-Core')].
spec group: 'Core' with: #(
'Metanool-Core').
spec group: 'Tests' with: #(
" 'Magritte-Tests-Model'"
'Metanool-Tests-Core'). 
spec project: 'Magritte3' with: [
spec
className: 'ConfigurationOfMagritte3';
file: 'ConfigurationOfMagritte3';
version: #stable;
repository: 'http://source.lukas-renggli.ch/magritte3';
loads: #('Magritte-Model' 'Magritte-Tests-Model' 'Magritte-Morph' 'Magritte-Pharo-Model') ].
spec project: 'Fame' with: [
spec
className: 'ConfigurationOfFame';
version: #development;
file:  'ConfigurationOfFame';
repository: 'http://www.smalltalkhub.com/mc/Moose/Fame/main' ].
]

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

On Aug 10, 2013, at 9:28 AM, Tudor Girba <[hidden email]> wrote:

Hi,

Yes, indeed, Metanool should depend on Moose-Core. I will look into it before the release. Maybe I will merge Metanool with Moose-Finder.

As for Point 1, I will look into it.

Thanks

I'm going over all the configuration of Synectique today to see if there is a problem because I want to understand.

Cheers,

Doru

On Sat, Aug 10, 2013 at 9:22 AM, Stéphane Ducasse <[hidden email]> wrote:

Doru 

Two points to answers (do not read this email if you are in hurry)

===================================================

Point 1 

=====

can you have a look at at my 23 commit changes?

Because I think that the logic is more robust:

Doing a join is too me more robust than a match.

As I already say it 

we want (version repo package)

and we have 

from the config repo package

and now we are taking from the image version and look for the package with a match

what I did is:

from the config repo package

from the image version package

Like that there is no possibility of mismatch

I will check why I got the other problems. It is probably in the configuration of synectique projects but still

having this match is a source of error. 

Point 2

=======================================================

Then I do not understand why Metanool does not list MooseCore as a dependency?

Could you reply to these points?

Stef

PS: I wrote the following in a previous mail

don't you think that Metanool should depend on Moose? Since it uses MooseEntity. 

baseline10: spec 
<version: '1.0-baseline'>

spec for: #common do: [
spec blessing: #baseline.
spec repository: 'http://www.smalltalkhub.com/mc/Moose/Metanool/main'.
spec
package: 'Metanool-Core' with: [spec requires: #('Fame' 'Magritte3')];
package: 'Metanool-Tests-Core' with: [spec requires: #('Metanool-Core')].
spec group: 'Core' with: #(
'Metanool-Core').
spec group: 'Tests' with: #(
" 'Magritte-Tests-Model'"
'Metanool-Tests-Core'). 
spec project: 'Magritte3' with: [
spec
className: 'ConfigurationOfMagritte3';
file: 'ConfigurationOfMagritte3';
version: #stable;
repository: 'http://source.lukas-renggli.ch/magritte3';
loads: #('Magritte-Model' 'Magritte-Tests-Model' 'Magritte-Morph' 'Magritte-Pharo-Model') ].
spec project: 'Fame' with: [
spec
className: 'ConfigurationOfFame';
version: #development;
file:  'ConfigurationOfFame';
repository: 'http://www.smalltalkhub.com/mc/Moose/Fame/main' ].
]

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--

www.tudorgirba.com

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Gofer new 

smalltalkhubUser: 'girba' project: 'Snapshotcello';

package: 'ConfigurationOfSnapshotcello';

load.

ConfigurationOfSnapshotcello loadStable.

Snapshotcello new 

configurationClass: ConfigurationOfMoose;

        sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos' 

==> 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

doru

I just checked because you put a doubt in my mind but I was right

repositoryFor: is for versioned package not package names

so the real case (in fact I put a transcript while snapshotting Moose) is 

Snapshotcello new 

configurationClass: ConfigurationOfMoose;

        sourceVersion: #development;

repositoryFor: 'ConfigurationOfFame-TudorGirba.19'

With Snapshotcello 20

Snapshotcello new 

configurationClass: ConfigurationOfFourDBrowser;

sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'   

>>> 'http://www.smalltalkhub.com/mc/Moose/Moose/main/'

With Snapshotcello 23 (my favorite solution but I need your look)

Snapshotcello new 

configurationClass: ConfigurationOfFourDBrowser;

sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'   

>>> 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

With Snapshotcello21 (improving the match to cut at '-') 

Snapshotcello new 

configurationClass: ConfigurationOfFourDBrowser;

sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'     

'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

I was afraid that my changes was just fixing the consequences of a problem in the method computePackagesAndRepositoriesFromConfiguration

but it is correct. What metacello gives us back is a correct list of pairs.

Stef

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Ok, I see the problem now, although is not reproducible in the case of ConfigurationOfMoose simply because of the load order I think. But, the bug was clearly present.

I looked at your code and it fixed the problem. However, I now took a step back and I realize that we are working on the wrong model :). All the information we need is in the working copies, so I removed all intermediary string-based collections and I am only using a collection of working copies. It seems to work fine. I pushed it as stable. Could you have a look?

Cheers,

Doru

On Sat, Aug 10, 2013 at 6:14 PM, Stéphane Ducasse <[hidden email]> wrote:

Gofer new 

smalltalkhubUser: 'girba' project: 'Snapshotcello';

package: 'ConfigurationOfSnapshotcello';

load.

ConfigurationOfSnapshotcello loadStable.

Snapshotcello new 

configurationClass: ConfigurationOfMoose;

        sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos' 

==> 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

doru

I just checked because you put a doubt in my mind but I was right

repositoryFor: is for versioned package not package names

so the real case (in fact I put a transcript while snapshotting Moose) is 

Snapshotcello new 

configurationClass: ConfigurationOfMoose;

        sourceVersion: #development;

repositoryFor: 'ConfigurationOfFame-TudorGirba.19'

With Snapshotcello 20

Snapshotcello new 

configurationClass: ConfigurationOfFourDBrowser;

sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'   

>>> 'http://www.smalltalkhub.com/mc/Moose/Moose/main/'

With Snapshotcello 23 (my favorite solution but I need your look)

Snapshotcello new 

configurationClass: ConfigurationOfFourDBrowser;

sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'   

>>> 'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

With Snapshotcello21 (improving the match to cut at '-') 

Snapshotcello new 

configurationClass: ConfigurationOfFourDBrowser;

sourceVersion: #development;

repositoryFor: 'ConfigurationOfMooseAlgos-TudorGirba.34'     

'http://www.smalltalkhub.com/mc/Moose/MooseAlgos/main/'

I was afraid that my changes was just fixing the consequences of a problem in the method computePackagesAndRepositoriesFromConfiguration

but it is correct. What metacello gives us back is a correct list of pairs.

Stef

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--

www.tudorgirba.com

"Every thing has its own flow"