Smalltalk › Pharo › Pharo Smalltalk Developers

SocketPlugin: ignoring unknown option 'TCP_CORK'

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Philippe Marschall-2-3

SocketPlugin: ignoring unknown option 'TCP_CORK'

Hi

I had this crazy idea, what instead of buffering at the application
level I use the native buffer of the socket? I would be doing more or
less this:

set TCP_CORK to 1
set TCP_NODELAY to 0

do individual writes

set TCP_CORK to 0
set TCP_NODELAY to 1

do last write

goto 1

(use TCP_NOWAIT and TCP_NOPUSH on BSD/MacOS)

I hacked something together and tried to push it through some benchmarks
but the SocketPlugin was not very impressed:

SocketPlugin: ignoring unknown option 'TCP_CORK'

This is on Linux with Cog.

Cheers
Philippe

Eliot Miranda-2

Re: SocketPlugin: ignoring unknown option 'TCP_CORK'

Hi Phillipe,

you'll need to add TCP_CORK to the list of known options in platforms/unix/plugins/SocketPlugin/sqUnixSocket.c

On Sat, Feb 11, 2012 at 1:51 PM, Philippe Marschall <[hidden email]> wrote:

Hi

I had this crazy idea, what instead of buffering at the application level I use the native buffer of the socket? I would be doing more or less this:

set TCP_CORK to 1
set TCP_NODELAY to 0

do individual writes

set TCP_CORK to 0
set TCP_NODELAY to 1

do last write

goto 1

(use TCP_NOWAIT and TCP_NOPUSH on BSD/MacOS)

I hacked something together and tried to push it through some benchmarks but the SocketPlugin was not very impressed:

SocketPlugin: ignoring unknown option 'TCP_CORK'

This is on Linux with Cog.

Cheers
Philippe

--
best,

Eliot

Philippe Marschall-2

Re: SocketPlugin: ignoring unknown option 'TCP_CORK'

On 02/13/2012 12:08 AM, Eliot Miranda wrote:
>
>
>
>
> Hi Phillipe,
>
> you'll need to add TCP_CORK to the list of known options in
> platforms/unix/plugins/SocketPlugin/sqUnixSocket.c

Do you accept patches? Is the source still at [1]?

[1] http://www.squeakvm.org/svn/squeak/branches/Cog/

Cheers
Philippe

Eliot Miranda-2

Re: SocketPlugin: ignoring unknown option 'TCP_CORK'

On Sun, Feb 12, 2012 at 11:59 PM, Philippe Marschall <[hidden email]> wrote:

On 02/13/2012 12:08 AM, Eliot Miranda wrote:

Hi Phillipe,

you'll need to add TCP_CORK to the list of known options in
platforms/unix/plugins/SocketPlugin/sqUnixSocket.c

Do you accept patches?

With gratitude :)

Is the source still at [1]?

Yes.

[1] http://www.squeakvm.org/svn/squeak/branches/Cog/

Cheers
Philippe

--
best,

Eliot

Philippe Marschall-2-3

Re: SocketPlugin: ignoring unknown option 'TCP_CORK'

On 13.02.2012 19:25, Eliot Miranda wrote:

>
>
> On Sun, Feb 12, 2012 at 11:59 PM, Philippe Marschall
> <[hidden email]
> <mailto:[hidden email]>> wrote:
>
> On 02/13/2012 12:08 AM, Eliot Miranda wrote:
>
>
>
>
>
> Hi Phillipe,
>
> you'll need to add TCP_CORK to the list of known options in
> platforms/unix/plugins/__SocketPlugin/sqUnixSocket.c
>
>
> Do you accept patches?
>
>
> With gratitude :)

There you go, has also TCP_NOPUSH for Mac OS (no, I didn't actually test
that).

Cheers
Philippe

cork.patch (1K) Download Attachment

Eliot Miranda-2

Re: SocketPlugin: ignoring unknown option 'TCP_CORK'

On Mon, Feb 13, 2012 at 1:14 PM, Philippe Marschall <[hidden email]> wrote:

On 13.02.2012 19:25, Eliot Miranda wrote:

On Sun, Feb 12, 2012 at 11:59 PM, Philippe Marschall
<[hidden email]
<mailto:[hidden email]>> wrote:

On 02/13/2012 12:08 AM, Eliot Miranda wrote:

Hi Phillipe,

you'll need to add TCP_CORK to the list of known options in
platforms/unix/plugins/__SocketPlugin/sqUnixSocket.c

Do you accept patches?

With gratitude :)

There you go, has also TCP_NOPUSH for Mac OS (no, I didn't actually test that).

Thanks! While I'm at it, anyone think any other socket options should be added?

Cheers
Philippe

--
best,

Eliot