Hi all,
i'm not sure this is a good idea to have to following method on ESDataObject printOn:aStream self model printOn:aStream I built an instance of ESAxis in order to understand how it works: |axis| axis := ESAxis new. axis values: #(1 2 3 4). And when i inspect : axis values i was really disturbed because it looks like an array of integer but in fact this is an array of ESDataObject ... I propose to remove printOn: method or to rewrite like: printOn:aStream aStream nextPutAll: 'an '; print: self class; nextPutAll: '('; print: self model; nextPutAll: ')' In the same class, the instance variable model is used by no one and model method is defined as: model ^entity I propose to remove model inst var. I put the previous modifications in EyeSee-Core-SergeStinckwich.77 Regards, -- Serge Stinckwich UMI UMMISCO 209 (IRD/UPMC), Hanoi, Vietnam Matsuno Laboratory, Kyoto University, Japan (until 12/2011) http://www.mechatronics.me.kyoto-u.ac.jp/ Every DSL ends up being Smalltalk http://doesnotunderstand.org/ _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
2011/12/9 Serge Stinckwich <[hidden email]>:
> Hi all, > > i'm not sure this is a good idea to have to following method on ESDataObject > > printOn:aStream > self model printOn:aStream > > I built an instance of ESAxis in order to understand how it works: > > |axis| > axis := ESAxis new. > axis values: #(1 2 3 4). > > And when i inspect : axis values i was really disturbed because it > looks like an array of integer but in fact this is an array of > ESDataObject ... > I propose to remove printOn: method or to rewrite like: > > printOn:aStream > aStream > nextPutAll: 'an '; > print: self class; > nextPutAll: '('; > print: self model; > nextPutAll: ')' Maybe not a great idea, because it breaks the axis drawing ... -- Serge Stinckwich UMI UMMISCO 209 (IRD/UPMC), Hanoi, Vietnam Matsuno Laboratory, Kyoto University, Japan (until 12/2011) http://www.mechatronics.me.kyoto-u.ac.jp/ Every DSL ends up being Smalltalk http://doesnotunderstand.org/ _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Yes, it breaks the axis drawing.
But I removed the inst variable entity (instead of model) and I kept model. Thanks Serge. On Fri, Dec 9, 2011 at 6:30 AM, Serge Stinckwich <[hidden email]> wrote: 2011/12/9 Serge Stinckwich <[hidden email]>: -- Andre Hora _______________________________________________ Moose-dev mailing list [hidden email] https://www.iam.unibe.ch/mailman/listinfo/moose-dev |
Free forum by Nabble | Edit this page |