Source/changes file suffixes constants

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Source/changes file suffixes constants

Sven Van Caekenberghe-2
Hi,

Current FileStream holds (in the protocol 'file reader services') some constants regarding source/changes file suffixes.

Where should we move these to (as FileStream is deprecated) ?

There is a class SourceFile, there is PharoFilesOpener, neither seems to fit that well.

Suggestions ?

Sven
Reply | Threaded
Open this post in threaded view
|

Re: Source/changes file suffixes constants

Alistair Grant
Hi Sven,

On Wed, 31 Oct 2018 at 16:44, Sven Van Caekenberghe <[hidden email]> wrote:

>
> Hi,
>
> Current FileStream holds (in the protocol 'file reader services') some constants regarding source/changes file suffixes.
>
> Where should we move these to (as FileStream is deprecated) ?
>
> There is a class SourceFile, there is PharoFilesOpener, neither seems to fit that well.
>
> Suggestions ?

Can you clarify why you think SourcFile is not a good candidate?

#changesFileSuffixes, #isChangesFileSuffix:, #isSourceFileSuffix:,
#sourceFileSuffixes all relate to specifying source files, so could
possibly go to SourceFile.

#fileIn: should be deprecated.  FileReference>>fileIn provides the same
functionality.

#removeLineFeeds: seems to be unused.  Deprecate as well?


Cheers,
Alistair

Reply | Threaded
Open this post in threaded view
|

Re: Source/changes file suffixes constants

Sven Van Caekenberghe-2
Hi,

> On 1 Nov 2018, at 17:59, Alistair Grant <[hidden email]> wrote:
>
> Hi Sven,
>
> On Wed, 31 Oct 2018 at 16:44, Sven Van Caekenberghe <[hidden email]> wrote:
>>
>> Hi,
>>
>> Current FileStream holds (in the protocol 'file reader services') some constants regarding source/changes file suffixes.
>>
>> Where should we move these to (as FileStream is deprecated) ?
>>
>> There is a class SourceFile, there is PharoFilesOpener, neither seems to fit that well.
>>
>> Suggestions ?
>
> Can you clarify why you think SourcFile is not a good candidate?

The name is of course good, but the functionality is not really related.
If others think this is a good place, then it is OK for me too.

> #changesFileSuffixes, #isChangesFileSuffix:, #isSourceFileSuffix:,
> #sourceFileSuffixes all relate to specifying source files, so could
> possibly go to SourceFile.

OK

> #fileIn: should be deprecated.  FileReference>>fileIn provides the same
> functionality.

Yes

> #removeLineFeeds: seems to be unused.  Deprecate as well?

Yes

> Cheers,
> Alistair