Spur VM Bug for Chinese Characters?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Spur VM Bug for Chinese Characters?

Sven Van Caekenberghe-2

> On 18 Oct 2016, at 03:36, Sean P. DeNigris <[hidden email]> wrote:
>
> Sven Van Caekenberghe-2 wrote
>> You could try doing... allowComplexMapKeys: true
>> ...
>
> Hmm, if the default writing may use complex keys, shouldn't the default
> reading do the same? I found it jarring to write using the defaults, and
> then have the default read fail!

Yes, you are right, the default should be true, I can't remember why I did not yet do it, it feels as if I am forgetting something, don't see all the consequences.

> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/Spur-VM-Bug-for-Chinese-Characters-tp4918883p4919141.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>


Reply | Threaded
Open this post in threaded view
|

Re: Spur VM Bug for Chinese Characters?

Sven Van Caekenberghe-2

> On 18 Oct 2016, at 07:40, Sven Van Caekenberghe <[hidden email]> wrote:
>
>
>> On 18 Oct 2016, at 03:36, Sean P. DeNigris <[hidden email]> wrote:
>>
>> Sven Van Caekenberghe-2 wrote
>>> You could try doing... allowComplexMapKeys: true
>>> ...
>>
>> Hmm, if the default writing may use complex keys, shouldn't the default
>> reading do the same? I found it jarring to write using the defaults, and
>> then have the default read fail!
>
> Yes, you are right, the default should be true, I can't remember why I did not yet do it, it feels as if I am forgetting something, don't see all the consequences.

I decided to remove this option all together:

===
Name: STON-Core-SvenVanCaekenberghe.77
Author: SvenVanCaekenberghe
Time: 24 October 2016, 10:36:19.993021 am
UUID: cb69cdaa-0065-4014-afa7-67a2a7e445db
Ancestors: STON-Core-SvenVanCaekenberghe.76

Remove the option #allowComplexMapKeys from STONReader (to functionally always allow it; leave the accessor #allowComplexMapsKeys: as a no-op for backwards compatibility) - remove all usage, simplify implementation.
===
Name: STON-Tests-SvenVanCaekenberghe.67
Author: SvenVanCaekenberghe
Time: 24 October 2016, 10:36:51.944835 am
UUID: 92a94566-972f-4084-aa37-a572de9cfe67
Ancestors: STON-Tests-SvenVanCaekenberghe.66

Remove the option #allowComplexMapKeys from STONReader (to functionally always allow it; leave the accessor #allowComplexMapsKeys: as a no-op for backwards compatibility) - remove all usage, simplify implementation.
===

Sven

>> -----
>> Cheers,
>> Sean
>> --
>> View this message in context: http://forum.world.st/Spur-VM-Bug-for-Chinese-Characters-tp4918883p4919141.html
>> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>>
>


Reply | Threaded
Open this post in threaded view
|

Re: Spur VM Bug for Chinese Characters?

Sean P. DeNigris
Administrator
Sven Van Caekenberghe-2 wrote
I decided to... simplify implementation
Thanks for following up!
Cheers,
Sean
12