SqueakSource/Seaside question - has anyone seen this problem before?

Has anyone with experience on Seaside and/or SqueakSource ever seen symptoms
like we are currently experiencing here:

   http://squeaksource.com

Our squeaksource.com server has for some reason gotten itself confused
and has a broken web interface. The repository itself is fine, so this
is not an emergency. However, the web interface is broken and seems to
be emitting chunks of incomplete html. I can restore things to working
order by reloading from a backup image, but I would prefer to understand
what has going wrong first.

The problem is definitely in the image itself, as opposed to Apache or
anything else about the server. When I run the image on my own PC at home,
I get identical symptoms.

I am no expert in Seaside, and working through it in a debugger is making
my head spin so I'm going to take the easy way out and just ask - has
anybody seen this kind of problem before?

TIA,
Dave

_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

On Sat, Dec 21, 2013 at 07:41:08PM -0500, Bob Arning wrote:

If you click one of the links on the first page, the next page looks 
good. If you then go back, the css from page 2 makes page1 look a little 
better. So, the breakage is limited. Any way to share the image?

Thanks Bob,

A copy of the image is at http://box2.squeak.org/ss_image_for_bob.zip

The zip is encripted, I will send the password to you in a separate email.

Dave

Bob,

This is absolutely great, thank you so much for the help. I just loaded
your patch into the running image, and the http://squeaksource.com web
interface is back to normal again.

Dave


On Sat, Dec 21, 2013 at 11:25:59PM -0500, Bob Arning wrote:

David,

The short answer is that two users (St?ane Munioz St?ane Munioz) have 
wide characters in their name and this does the damage. The method below 
is a quick hack to filter these 2 out of the list and all seems good.

Cheers,
Bob

'From Squeak3.11alpha of 6 January 2010 [latest update: #8824] on 21 
December 2013 at 11:21:03 pm'!

!SSHome methodsFor: 'statistics'!
membersNew
    | t1 |
    t1 := self statistics membersNew.
    ^ t1
        reject: [:t2 | t2 asString
                anySatisfy: [:t3 | t3 asciiValue > 255]]! !




On 12/21/13 9:25 PM, David T. Lewis wrote:

On Sat, Dec 21, 2013 at 07:41:08PM -0500, Bob Arning wrote:

If you click one of the links on the first page, the next page looks
good. If you then go back, the css from page 2 makes page1 look a little
better. So, the breakage is limited. Any way to share the image?

Thanks Bob,

A copy of the image is at http://box2.squeak.org/ss_image_for_bob.zip

The zip is encripted, I will send the password to you in a separate email.

Dave

 Which brings us to the question
how St鰨ane Munioz ended up in the image. Can you confirm that his name
is a WideString and 鰨 is a single instance of Character?

On Mon, Dec 23, 2013 at 1:43 PM, Bob Arning [hidden email] wrote:

 It is a WideString and

self asArray collect: [ :e | e asciiValue radix: 16] = #('53' '74'
'3FC09C28' '61' '6E' '65' '20' '4D' '75' '6E' '69' '6F' '7A')

Interesting, so somebody somewhere along the way converted the input
from something (likely utf-8 although the page is iso-8859-1) to
Squeak encoding.

Cheers
Philippe
_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

I see how it happens...

using Mac, Chrome with 8859-1 encoding as default, I typed
   
    S, t, option-e, e, p, h, a, n, e

in the login screen. What arrives back at the server is

    '11=St%E9phane&12=&13=Login'

wherupon HttpRequest tries to parse this
-----
decodeUrlEncodedForm: string multipleValues: boolean
    | dict key value start end eqSignPos more |
    dict _ boolean ifTrue: [HttpFormDictionary new] ifFalse: [Dictionary new].
    string isEmptyOrNil ifTrue: [^dict].
    more _ true.
    start _ 1.
    [end _ string indexOf: $& startingAt: start.
    end == 0
        ifTrue: [end _ string size. more _ false]
        ifFalse: [end _ end - 1].
    eqSignPos _ string indexOf: $= startingAt: start.
    (eqSignPos > end or: [eqSignPos == 0])
        ifTrue: [key _ (key _ string copyFrom: start to: end) unescapePercents.
            value _ '']
        ifFalse: [key _ (key _ string copyFrom: start to: eqSignPos-1) unescapePercents.
            value _ (value _ string copyFrom: eqSignPos+1 to: end) unescapePercents].
    self addKey: key value: value toForm: dict multipleValues: boolean.
    start _ end + 2.
    more] whileTrue.

    ^dict
-----
and #unescapePercents does

self unescapePercentsWithTextEncoding: 'utf-8'

    'St%E9phane' unescapePercents ==> 'St鰨ane'

whereas, if we knew it was not utf-8, then

    'St%E9phane' unescapePercentsWithTextEncoding: nil ==> 'Stéphane'

gives the expected answer. I tried to coax my browser to return utf-8, but that had no effect, so I'm wondering if this application would be better off using  
        unescapePercentsWithTextEncoding: nil
rather than
        unescapePercents

Cheers,
Bob

On 12/23/13 8:15 AM, Philippe Marschall wrote:

On Mon, Dec 23, 2013 at 1:43 PM, Bob Arning [hidden email] wrote:

 It is a WideString and

self asArray collect: [ :e | e asciiValue radix: 16] = #('53' '74'
'3FC09C28' '61' '6E' '65' '20' '4D' '75' '6E' '69' '6F' '7A')

Interesting, so somebody somewhere along the way converted the input
from something (likely utf-8 although the page is iso-8859-1) to
Squeak encoding.

Cheers
Philippe
_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

Bob,

Thanks again for debugging this problem on squeaksource.com (and apologies
for not following up on the matter sooner). The updated version of the
decodeUrlEncodedForm:multipleValues: does indeed resolve the problem that
we were seeing. Unfortunately, I found another problem related to WideString
member names, which is that I cannot (in squeaksource.com screens) edit a
project and add a new developer to that existing project.

It seems clear (as previously noted) that we really need to update our
source.squeak.org and squeaksource.com images to use an up to date Seaside.
I'm not going to attempt that effort (I'm mainly concerned with just keeping
squeaksource.com operating), so in the mean time I think I will just work
around the problem by converting the WideString member names to ByteString.

Fortunately there are only two member names that are WideString, and they
both belong to the same person (CC'ed on this message), so I think that the
impact is minor.

Thanks,

Dave

On Mon, Dec 23, 2013 at 12:16:46PM -0500, Bob Arning wrote:

And I see that's exactly what newer versions of this method do...

decodeUrlEncodedForm: string multipleValues: boolean
    | dict key value start end eqSignPos more |
    dict := boolean ifTrue: [HttpFormDictionary new] ifFalse: 
[Dictionary new].
    string isEmptyOrNil ifTrue: [^dict].
    more := true.
    start := 1.
    [end := string indexOf: $& startingAt: start.
    end == 0
        ifTrue: [end := string size. more := false]
        ifFalse: [end := end - 1].
    eqSignPos := string indexOf: $= startingAt: start.
    (eqSignPos > end or: [eqSignPos == 0])
        ifTrue: [key := (key := string copyFrom: start to: end) 
unescapePercentsWithTextEncoding: nil.
            value := '']
        ifFalse: [key := (key := string copyFrom: start to: 
eqSignPos-1) unescapePercentsWithTextEncoding: nil.
            value := (value := string copyFrom: eqSignPos+1 to: end) 
unescapePercentsWithTextEncoding: nil].
    self addKey: key value: value toForm: dict multipleValues: boolean.
    start := end + 2.
    more] whileTrue.

    ^dict

Cheers,
Bob


On 12/23/13 11:04 AM, Bob Arning wrote:

I see how it happens...

using Mac, Chrome with 8859-1 encoding as default, I typed

   S, t, option-e, e, p, h, a, n, e

in the login screen. What arrives back at the server is

   '11=St%E9phane&12=&13=Login'

wherupon HttpRequest tries to parse this
-----
decodeUrlEncodedForm: string multipleValues: boolean
   | dict key value start end eqSignPos more |
   dict _ boolean ifTrue: [HttpFormDictionary new] ifFalse: 
[Dictionary new].
   string isEmptyOrNil ifTrue: [^dict].
   more _ true.
   start _ 1.
   [end _ string indexOf: $& startingAt: start.
   end == 0
       ifTrue: [end _ string size. more _ false]
       ifFalse: [end _ end - 1].
   eqSignPos _ string indexOf: $= startingAt: start.
   (eqSignPos > end or: [eqSignPos == 0])
       ifTrue: [key _ (key _ string copyFrom: start to: end) 
unescapePercents.
           value _ '']
       ifFalse: [key _ (key _ string copyFrom: start to: eqSignPos-1) 
unescapePercents.
           value _ (value _ string copyFrom: eqSignPos+1 to: end) 
*unescapePercents*].
   self addKey: key value: value toForm: dict multipleValues: boolean.
   start _ end + 2.
   more] whileTrue.

   ^dict
-----
and #unescapePercents does

self unescapePercentsWithTextEncoding: 'utf-8'

   'St%E9phane' unescapePercents ==> 'St???ane'

whereas, if we knew it was not utf-8, then

   'St%E9phane' unescapePercentsWithTextEncoding: nil ==> 'St??phane'

gives the expected answer. I tried to coax my browser to return utf-8, 
but that had no effect, so I'm wondering if this application would be 
better off using
unescapePercentsWithTextEncoding: nil
rather than
   unescapePercents

Cheers,
Bob

On 12/23/13 8:15 AM, Philippe Marschall wrote:

On Mon, Dec 23, 2013 at 1:43 PM, Bob Arning[hidden email]  wrote:

 It is a WideString and

self asArray collect: [ :e | e asciiValue radix: 16] = #('53' '74'
'3FC09C28' '61' '6E' '65' '20' '4D' '75' '6E' '69' '6F' '7A')

Interesting, so somebody somewhere along the way converted the input

>from something (likely utf-8 although the page is iso-8859-1) to

Squeak encoding.

Cheers
Philippe
_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

_______________________________________________
seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside