StartupPreferences

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

StartupPreferences

Sean P. DeNigris
Administrator
Mariano,

Can any of the script lookup logic from 2.0 be ported to 1.4? StartupPreferences doesn't seem very useful if only the image folder is checked, given that the initial use case was for working in many fresh images.

- S
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: StartupPreferences

Mariano Martinez Peck


On Sun, Jul 8, 2012 at 6:17 AM, Sean P. DeNigris <[hidden email]> wrote:
Mariano,

Can any of the script lookup logic from 2.0 be ported to 1.4?

Migrate everything (the new logic and all the last improvements) is too much. Mostly because I don't have time and because it is not a dead or alive bug. In fact, it was never before and people never complained ;)
What you COULD do if you want is to just do this:

 
StartupPreferences doesn't seem very useful if only the image folder is
checked,

Why it only searches in the image folder?

buildActionList

    "First, we look at image folder,
    then we look at preferences folder,
    and finally at general preferences folder "

    ^  OrderedCollection new
        add: [ self lookInImageDirectory ];
        add: [self lookInPreferencesFolder ];
        add: [self lookInGeneralPreferencesFolder ];
        yourself.


it should check there (the version that is in 1.4). The only reason this version would stop searching in other places is if it did find something. When it finds something, it stops searching (in 2.0 it contiues and executes all the ones that are found).


given that the initial use case was for working in many fresh
images.


+99
 
- S

--
View this message in context: http://forum.world.st/StartupPreferences-tp4639058.html
Sent from the Pharo Smalltalk mailing list archive at Nabble.com.




--
Mariano
http://marianopeck.wordpress.com

Reply | Threaded
Open this post in threaded view
|

Re: StartupPreferences

Mariano Martinez Peck


On Sun, Jul 8, 2012 at 10:16 AM, Mariano Martinez Peck <[hidden email]> wrote:


On Sun, Jul 8, 2012 at 6:17 AM, Sean P. DeNigris <[hidden email]> wrote:
Mariano,

Can any of the script lookup logic from 2.0 be ported to 1.4?

Migrate everything (the new logic and all the last improvements) is too much. Mostly because I don't have time and because it is not a dead or alive bug. In fact, it was never before and people never complained ;)
What you COULD do if you want is to just do this:

 
StartupPreferences doesn't seem very useful if only the image folder is
checked,

Why it only searches in the image folder?

buildActionList

    "First, we look at image folder,
    then we look at preferences folder,
    and finally at general preferences folder "

    ^  OrderedCollection new
        add: [ self lookInImageDirectory ];
        add: [self lookInPreferencesFolder ];
        add: [self lookInGeneralPreferencesFolder ];
        yourself.

Ok, I was checking an old version of 1.4. Now I see:

buildActionList

    "First, we look at image folder,
    then we look at preferences folder,
    and finally at general preferences folder "

    self flag: #todo. "I'm disabling this sequence because lookup of preferences folder is broken in windows."
    ^  OrderedCollection new
        add: [ self lookInImageDirectory ];
        "add: [self lookInPreferencesFolder ];
        add: [self lookInGeneralPreferencesFolder ];"
        yourself.


so....migrate all the new version is costly. I don't have time to do it.
If you want, you can just enable back for all but for windows:


buildActionList

    "First, we look at image folder,
    then we look at preferences folder,
    and finally at general preferences folder "

    | directories |
    self flag: #todo. "I'm disabling this sequence because lookup of preferences folder is broken in windows.
NOTE: this has been fixed in Pharo 2.0"
    directories := OrderedCollection new.
    directories add: [ self lookInImageDirectory ].
    (OSPlatform current platformFamily = #Windows)
        ifFalse: [
            directories add: [self lookInPreferencesFolder ].
            directories add: [self lookInGeneralPreferencesFolder ].
        ].
    ^ directories

 


it should check there (the version that is in 1.4). The only reason this version would stop searching in other places is if it did find something. When it finds something, it stops searching (in 2.0 it contiues and executes all the ones that are found).


given that the initial use case was for working in many fresh
images.


+99
 
- S

--
View this message in context: http://forum.world.st/StartupPreferences-tp4639058.html
Sent from the Pharo Smalltalk mailing list archive at Nabble.com.




--
Mariano
http://marianopeck.wordpress.com




--
Mariano
http://marianopeck.wordpress.com