State of Sound in Morph

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

State of Sound in Morph

hilaire
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse
probably because we were stupid to remove it from the image.
If you can check there are two fixes on the bug archives and it would be great that somebody compares with squeak
version. I did not see that much changes from this part of the system on their side.

Stef
On Jul 22, 2010, at 2:36 PM, Hilaire Fernandes wrote:

> I tried the Pharo sound package, so far it looks sound is not working.
> Is it true or is it a mistake of myself.
>
> For example:
>
> No sound output when executing:
> FMSound bass1 play
>
> DNU FMSound copy when executing:
> (FMSound lowMajorScaleOn: FMSound bass1) play
>
> Hilaire
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Adrian Lienhard

On Jul 22, 2010, at 14:42 , Stéphane Ducasse wrote:

> probably because we were stupid to remove it from the image.

I don't think so.

Rather because we have:
- nobody who takes responsibility to maintain this package
- no tests for this package
- no build and test server to detect problems automatically

Cheers,
Adrian

BTW, the two expressions posted below work for me on a recent Mac VM in a Pharo 1.0 image.


> If you can check there are two fixes on the bug archives and it would be great that somebody compares with squeak
> version. I did not see that much changes from this part of the system on their side.
>
> Stef
> On Jul 22, 2010, at 2:36 PM, Hilaire Fernandes wrote:
>
>> I tried the Pharo sound package, so far it looks sound is not working.
>> Is it true or is it a mistake of myself.
>>
>> For example:
>>
>> No sound output when executing:
>> FMSound bass1 play
>>
>> DNU FMSound copy when executing:
>> (FMSound lowMajorScaleOn: FMSound bass1) play
>>
>> Hilaire
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Mariano Martinez Peck
In reply to this post by hilaire


On Thu, Jul 22, 2010 at 2:36 PM, Hilaire Fernandes <[hidden email]> wrote:
I tried the Pharo sound package, so far it looks sound is not working.
Is it true or is it a mistake of myself.

For example:

No sound output when executing:
FMSound bass1 play

DNU FMSound copy when executing:
(FMSound lowMajorScaleOn: FMSound bass1) play
ç

Hi Hilaire. If you check in the latests commits, you will see I have been commiting all possible fixes. When they are removed from the core, nobody maintains them. For the Pharo releas, I fixed all sents to messages not implement, and all references to classes that don't exist.

There are not tests, so I cannot do more than that.  I have no idea if it is working or not.

Cheers

Mariano
 
Hilaire


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Mariano Martinez Peck
In reply to this post by Adrian Lienhard


On Thu, Jul 22, 2010 at 3:45 PM, Adrian Lienhard <[hidden email]> wrote:

On Jul 22, 2010, at 14:42 , Stéphane Ducasse wrote:

> probably because we were stupid to remove it from the image.

I don't think so.

Rather because we have:
- nobody who takes responsibility to maintain this package
- no tests for this package
- no build and test server to detect problems automatically


I think it is a combination of the 2. First, we are not stupid to remove it from core. They HAVE to be removed and put it as separate package.

Then, I agree with ALL adrian comments. But I also agree that this problem can be minimized. When you remove methods/classes in PharoCore, it would be good to search them in "Pharo". That's why I did ConfigurationOfPharoNonCore.

Cheers

Mariano
 
Cheers,
Adrian

BTW, the two expressions posted below work for me on a recent Mac VM in a Pharo 1.0 image.


> If you can check there are two fixes on the bug archives and it would be great that somebody compares with squeak
> version. I did not see that much changes from this part of the system on their side.
>
> Stef
> On Jul 22, 2010, at 2:36 PM, Hilaire Fernandes wrote:
>
>> I tried the Pharo sound package, so far it looks sound is not working.
>> Is it true or is it a mistake of myself.
>>
>> For example:
>>
>> No sound output when executing:
>> FMSound bass1 play
>>
>> DNU FMSound copy when executing:
>> (FMSound lowMajorScaleOn: FMSound bass1) play
>>
>> Hilaire
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Gary Chambers-4
Do we have anyone responsibly for these kind of "near core" packages?

Regards, Gary
----- Original Message -----
Sent: Thursday, July 22, 2010 3:40 PM
Subject: Re: [Pharo-project] State of Sound in Morph



On Thu, Jul 22, 2010 at 3:45 PM, Adrian Lienhard <[hidden email]> wrote:

On Jul 22, 2010, at 14:42 , Stéphane Ducasse wrote:

> probably because we were stupid to remove it from the image.

I don't think so.

Rather because we have:
- nobody who takes responsibility to maintain this package
- no tests for this package
- no build and test server to detect problems automatically


I think it is a combination of the 2. First, we are not stupid to remove it from core. They HAVE to be removed and put it as separate package.

Then, I agree with ALL adrian comments. But I also agree that this problem can be minimized. When you remove methods/classes in PharoCore, it would be good to search them in "Pharo". That's why I did ConfigurationOfPharoNonCore.

Cheers

Mariano
 
Cheers,
Adrian

BTW, the two expressions posted below work for me on a recent Mac VM in a Pharo 1.0 image.


> If you can check there are two fixes on the bug archives and it would be great that somebody compares with squeak
> version. I did not see that much changes from this part of the system on their side.
>
> Stef
> On Jul 22, 2010, at 2:36 PM, Hilaire Fernandes wrote:
>
>> I tried the Pharo sound package, so far it looks sound is not working.
>> Is it true or is it a mistake of myself.
>>
>> For example:
>>
>> No sound output when executing:
>> FMSound bass1 play
>>
>> DNU FMSound copy when executing:
>> (FMSound lowMajorScaleOn: FMSound bass1) play
>>
>> Hilaire
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Mariano Martinez Peck


2010/7/22 Gary Chambers <[hidden email]>
Do we have anyone responsibly for these kind of "near core" packages?


The idea behind ConfigurationOfPharoNonCore is that WE (pharo developers) are the maintainers, and not "external maintainers". So, this is the difference between this PharoNonCore and PharoDev. In PharoDev we have a lot of development tools, and mostly, maintained by external people. PharoNonCore should be part as Pharo, but that shouldn't be part of the core. However, it is maitained by the Pharo developers.

Cheers

Mariano

 
Regards, Gary
----- Original Message -----
Sent: Thursday, July 22, 2010 3:40 PM
Subject: Re: [Pharo-project] State of Sound in Morph



On Thu, Jul 22, 2010 at 3:45 PM, Adrian Lienhard <[hidden email]> wrote:

On Jul 22, 2010, at 14:42 , Stéphane Ducasse wrote:

> probably because we were stupid to remove it from the image.

I don't think so.

Rather because we have:
- nobody who takes responsibility to maintain this package
- no tests for this package
- no build and test server to detect problems automatically


I think it is a combination of the 2. First, we are not stupid to remove it from core. They HAVE to be removed and put it as separate package.

Then, I agree with ALL adrian comments. But I also agree that this problem can be minimized. When you remove methods/classes in PharoCore, it would be good to search them in "Pharo". That's why I did ConfigurationOfPharoNonCore.

Cheers

Mariano
 
Cheers,
Adrian

BTW, the two expressions posted below work for me on a recent Mac VM in a Pharo 1.0 image.


> If you can check there are two fixes on the bug archives and it would be great that somebody compares with squeak
> version. I did not see that much changes from this part of the system on their side.
>
> Stef
> On Jul 22, 2010, at 2:36 PM, Hilaire Fernandes wrote:
>
>> I tried the Pharo sound package, so far it looks sound is not working.
>> Is it true or is it a mistake of myself.
>>
>> For example:
>>
>> No sound output when executing:
>> FMSound bass1 play
>>
>> DNU FMSound copy when executing:
>> (FMSound lowMajorScaleOn: FMSound bass1) play
>>
>> Hilaire
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse
In reply to this post by Gary Chambers-4
not really
this is why we should get a process where we load all these orphan packages. Because this way we can maintain easily.

Stef

On Jul 22, 2010, at 6:09 PM, Gary Chambers wrote:

> Do we have anyone responsibly for these kind of "near core" packages?
>
> Regards, Gary
> ----- Original Message -----
> From: Mariano Martinez Peck
> To: [hidden email]
> Sent: Thursday, July 22, 2010 3:40 PM
> Subject: Re: [Pharo-project] State of Sound in Morph
>
>
>
> On Thu, Jul 22, 2010 at 3:45 PM, Adrian Lienhard <[hidden email]> wrote:
>
> On Jul 22, 2010, at 14:42 , Stéphane Ducasse wrote:
>
> > probably because we were stupid to remove it from the image.
>
> I don't think so.
>
> Rather because we have:
> - nobody who takes responsibility to maintain this package
> - no tests for this package
> - no build and test server to detect problems automatically
>
>
> I think it is a combination of the 2. First, we are not stupid to remove it from core. They HAVE to be removed and put it as separate package.
>
> Then, I agree with ALL adrian comments. But I also agree that this problem can be minimized. When you remove methods/classes in PharoCore, it would be good to search them in "Pharo". That's why I did ConfigurationOfPharoNonCore.
>
> Cheers
>
> Mariano
>  
> Cheers,
> Adrian
>
> BTW, the two expressions posted below work for me on a recent Mac VM in a Pharo 1.0 image.
>
>
> > If you can check there are two fixes on the bug archives and it would be great that somebody compares with squeak
> > version. I did not see that much changes from this part of the system on their side.
> >
> > Stef
> > On Jul 22, 2010, at 2:36 PM, Hilaire Fernandes wrote:
> >
> >> I tried the Pharo sound package, so far it looks sound is not working.
> >> Is it true or is it a mistake of myself.
> >>
> >> For example:
> >>
> >> No sound output when executing:
> >> FMSound bass1 play
> >>
> >> DNU FMSound copy when executing:
> >> (FMSound lowMajorScaleOn: FMSound bass1) play
> >>
> >> Hilaire
> >>
> >>
> >> _______________________________________________
> >> Pharo-project mailing list
> >> [hidden email]
> >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
> >
> >
> > _______________________________________________
> > Pharo-project mailing list
> > [hidden email]
> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

hilaire
In reply to this post by Mariano Martinez Peck
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse

On Jul 22, 2010, at 8:22 PM, Hilaire Fernandes wrote:

>>    I tried the Pharo sound package, so far it looks sound is not working.
>>    Is it true or is it a mistake of myself.
>>
>>    For example:
>>
>>    No sound output when executing:
>>    FMSound bass1 play
>>
>>    DNU FMSound copy when executing:
>>    (FMSound lowMajorScaleOn: FMSound bass1) play
>
> oops, the DNU message was FMSound>>clone (and not #copy as I wrote)
> So this #clone message is gone.
> I have tested with a PharoCore1.11291
>
> Of course I took your latest commit. Do this latest commit include the
> patches Stephane mentioned?

no I guess not.
Hilaire if you can have a look at the bugtracker and harvest the fixes into sound
it would be great.

> To say the true, I came to test the sound feature after I compiled a VM
> for the XO-1 environment with the sound plugin, then I wanted to check
> some sound, I realized the classes were not in the image I was using (a
> core one), so I took a look in PharoNonCore, load and test the package.
> Then I wondered if I did something wrong.

normally not :)

>
>
> Hilaire
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

hilaire
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

hilaire
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Levente Uzonyi-2
On Thu, 22 Jul 2010, Hilaire Fernandes wrote:

> Le 22/07/2010 21:11, Hilaire Fernandes a écrit :
>> Le 22/07/2010 20:53, Stéphane Ducasse a écrit :
>>
>>>>
>>>> Of course I took your latest commit. Do this latest commit include the
>>>> patches Stephane mentioned?
>>>
>>> no I guess not.
>>> Hilaire if you can have a look at the bugtracker and harvest the fixes into sound
>>> it would be great.
>>
>> Sure
>
> The proposed pathes are not related to the problem.
> I replace the clone by a copy, it helps but I don't know the eventual
> side effects.
Why don't you use #shallowCopy? #clone and #shallowCopy do the same, but
#clone is primitive only, while #shallowCopy has fallback code written in
Smalltalk.


Levente

>
> Hilaire
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse
In reply to this post by hilaire

On Jul 22, 2010, at 10:14 PM, Hilaire Fernandes wrote:

> Le 22/07/2010 21:11, Hilaire Fernandes a écrit :
>> Le 22/07/2010 20:53, Stéphane Ducasse a écrit :
>>
>>>>
>>>> Of course I took your latest commit. Do this latest commit include the
>>>> patches Stephane mentioned?
>>>
>>> no I guess not.
>>> Hilaire if you can have a look at the bugtracker and harvest the fixes into sound
>>> it would be great.
>>
>> Sure
>
> The proposed pathes are not related to the problem.
> I replace the clone by a copy, it helps but I don't know the eventual
> side effects.

clone was a shallow copy and we replaced it by shallowCopy, copy
copy

        ^ self shallowCopy postCopy


We removed clone from pharo because tired to have three times the same half way done.
because only some parts of the system used clone and other shallow
>
> Hilaire
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Henrik Sperre Johansen

On Jul 22, 2010, at 11:51 30PM, Stéphane Ducasse wrote:

>
> On Jul 22, 2010, at 10:14 PM, Hilaire Fernandes wrote:
>
>> Le 22/07/2010 21:11, Hilaire Fernandes a écrit :
>>> Le 22/07/2010 20:53, Stéphane Ducasse a écrit :
>>>
>>>>>
>>>>> Of course I took your latest commit. Do this latest commit include the
>>>>> patches Stephane mentioned?
>>>>
>>>> no I guess not.
>>>> Hilaire if you can have a look at the bugtracker and harvest the fixes into sound
>>>> it would be great.
>>>
>>> Sure
>>
>> The proposed pathes are not related to the problem.
>> I replace the clone by a copy, it helps but I don't know the eventual
>> side effects.
>
> clone was a shallow copy and we replaced it by shallowCopy, copy
> copy
>
> ^ self shallowCopy postCopy
>
>
> We removed clone from pharo because tired to have three times the same half way done.
> because only some parts of the system used clone and other shallow

IE, the correct action would be to replace #clone calls with #shallowCopy (alternatively copy, if that makes more sense) calls in the PharoSound package?

Cheers,
Henry
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

hilaire
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

hilaire
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse
In reply to this post by Henrik Sperre Johansen

>> clone was a shallow copy and we replaced it by shallowCopy, copy
>> copy
>>
>> ^ self shallowCopy postCopy
>>
>>
>> We removed clone from pharo because tired to have three times the same half way done.
>> because only some parts of the system used clone and other shallow
>
> IE, the correct action would be to replace #clone calls with #shallowCopy (alternatively copy, if that makes more sense) calls in the PharoSound package?

yes


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse
In reply to this post by hilaire

On Jul 23, 2010, at 9:14 AM, Hilaire Fernandes wrote:

> Thanks guys for your feedback, I will make the necessary changes in the
> package. I have also applied the changes to sound from the Squeak friends.
>
> By the way, I wonder if the sound package should not be cut in two
> package, one related to sound synthesis and the other to morph stuff.


but I thought I already  did that so may be you are editing the old versions.
Can you check?
        the packages came from
                http://www.squeaksource.com/PharoSound/
                and you see that we split it already

We should really improve our traceability.
We should really get more metacello desription and have a way to mark things as obsolete
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: State of Sound in Morph

Stéphane Ducasse
In reply to this post by hilaire

On Jul 23, 2010, at 9:51 AM, Hilaire Fernandes wrote:

> Now I don't know what is the state of affaire regarding
> enabling/unenabling sounds from the Setting browser. It looks like the
> sound option in the Setting browser has not action.
> It looks like a specific Process is used to play sound, right?
> SoundPLayer initialize. Should we add a setting in the preference for
> that purpose?

probably
we should also check that there is no preferences left and only setting

>
> Hilaire
>
>
> Le 23/07/2010 09:14, Hilaire Fernandes a écrit :
>> Thanks guys for your feedback, I will make the necessary changes in the
>> package. I have also applied the changes to sound from the Squeak friends.
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
12