Strange code replacement when prompting unknown selector

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Strange code replacement when prompting unknown selector

Guillermo Polito
http://code.google.com/p/pharo/issues/detail?id=3070

Cheers!
Guille

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Strange code replacement when prompting unknown selector

Guillermo Polito
The problem seems to be between TextEditor>>correctFrom:to:with: and Parser>>substituteWord:wordInterval:offset:

The TextEditor isn't using well the selection offset to calculate the replacement, and the parser is sending an interval that's not the one that the Editor must replace.

I think the right place to put this is the Editor, but behind another message like replaceInSelectionFrom:to:with:

What do you think?

Guille


On Wed, Oct 6, 2010 at 6:33 PM, Guillermo Polito <[hidden email]> wrote:
http://code.google.com/p/pharo/issues/detail?id=3070

Cheers!
Guille


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Strange code replacement when prompting unknown selector

Stéphane Ducasse
In reply to this post by Guillermo Polito
This sounds correct.
Did you check how this is done in Cuis?

Stef

On Oct 9, 2010, at 5:31 AM, Guillermo Polito wrote:

> The problem seems to be between TextEditor>>correctFrom:to:with: and Parser>>substituteWord:wordInterval:offset:
>
> The TextEditor isn't using well the selection offset to calculate the replacement, and the parser is sending an interval that's not the one that the Editor must replace.
>
> I think the right place to put this is the Editor, but behind another message like replaceInSelectionFrom:to:with:
>
> What do you think?
>
> Guille
>
>
> On Wed, Oct 6, 2010 at 6:33 PM, Guillermo Polito <[hidden email]> wrote:
> http://code.google.com/p/pharo/issues/detail?id=3070
>
> Cheers!
> Guille
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Strange code replacement when prompting unknown selector

Mariano Martinez Peck
In reply to this post by Guillermo Polito


2010/10/9 Guillermo Polito <[hidden email]>
The problem seems to be between TextEditor>>correctFrom:to:with: and Parser>>substituteWord:wordInterval:offset:

The TextEditor isn't using well the selection offset to calculate the replacement, and the parser is sending an interval that's not the one that the Editor must replace.

I think the right place to put this is the Editor, but behind another message like replaceInSelectionFrom:to:with:

What do you think?

Guille



On Wed, Oct 6, 2010 at 6:33 PM, Guillermo Polito <[hidden email]> wrote:
http://code.google.com/p/pharo/issues/detail?id=3070

Cheers!
Guille


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Strange code replacement when prompting unknown selector

Juan Vuletich-4
Sounds reasonable.

Cheers,
Juan Vuletich

Mariano Martinez Peck wrote:

>
>
> 2010/10/9 Guillermo Polito <[hidden email]
> <mailto:[hidden email]>>
>
>     The problem seems to be between /TextEditor>>correctFrom:to:with:/
>     and /Parser>>substituteWord:wordInterval:offset:/
>
>     The TextEditor isn't using well the selection offset to calculate
>     the replacement, and the parser is sending an interval that's not
>     the one that the Editor must replace.
>
>     I think the right place to put this is the Editor, but behind
>     another message like replaceInSelectionFrom:to:with:
>
>     What do you think?
>
>     Guille
>
>
>
>     On Wed, Oct 6, 2010 at 6:33 PM, Guillermo Polito
>     <[hidden email] <mailto:[hidden email]>> wrote:
>
>         http://code.google.com/p/pharo/issues/detail?id=3070
>
>         Cheers!
>         Guille
>
>
>
>     _______________________________________________
>     Pharo-project mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> ------------------------------------------------------------------------
>
>
> No virus found in this incoming message.
> Checked by AVG - www.avg.com
> Version: 9.0.862 / Virus Database: 271.1.1/3184 - Release Date: 10/08/10 03:34:00
>
>  


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project