Smalltalk › Instantiations

StsTextComparisonBrowser defect - DNU #removedSomeSelectedMethods

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Richard Sargent

StsTextComparisonBrowser defect - DNU #removedSomeSelectedMethods

Administrator

I had opened a comparison browser to study the similarities between two methods.
Later, when I finished making my changes in another browser, I deleted one of the two methods (the one in the comparison browser's left pane, in case that matters).

#updateCodeBrowsersOnDelete: decided the comparison browser should be informed, since it was showing the selected method.
(And I suspect there is a separate defect that the comparison browser does not get notified when the method in the right pane is deleted from the system.)

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/groups/opt_out.

Seth Berman

Re: StsTextComparisonBrowser defect - DNU #removedSomeSelectedMethods

Hi Richard,

Opened case 53500 for this item.

Strangely, this only happens for the left pane. This particular browser is also used to show the differences between the contents of a workspace and a file on the filesystem (Workspace Menu->Options->Compare With...). I'm not sure which use case came first. There is some general purpose table that holds only the method from the left pane. I'm guessing this was so it could play nice with everything else in the hierarchy which has protocols relating to the selected method.

In any case, this will be updated for 8.6.1. Thanks

-- Seth

On Wednesday, January 29, 2014 3:12:26 PM UTC-5, Richard Sargent wrote:

I had opened a comparison browser to study the similarities between two methods.
Later, when I finished making my changes in another browser, I deleted one of the two methods (the one in the comparison browser's left pane, in case that matters).

#updateCodeBrowsersOnDelete: decided the comparison browser should be informed, since it was showing the selected method.
(And I suspect there is a separate defect that the comparison browser does not get notified when the method in the right pane is deleted from the system.)