Subscript Out Of Bounds: 1 when commiting from Versionner

Yes it was fix in pharo 60 and we should port it back but I forgot the issue number



Le 27/9/16 à 21:00, Hernán Morales Durand a écrit :

When commiting with Versionner in Pharo 5.0 I always have to manually override this method

KomitStagingArea>>remotes
    | result |

    result := self packages first remotes.
    self packages allButFirst do: [ :each |
        result := result intersection: each remotes ].

    ^ result collect: [ :each | each koRemote ]

to

KomitStagingArea>>remotes

    self packages isEmpty
        ifFalse: [
            | result |
            result := self packages first remotes.
            self packages allButFirst do: [ :each |
                result := result intersection: each remotes ].
            ^ result collect: [ :each | each koRemote ] ].
    ^ Array empty.

Screenshot attached.
Is this known issue or was this reported before?

Hernan

so do you think that we should back port these two big fixes? at least 18927 I think

Le 28/9/16 à 13:48, Hernán Morales Durand a écrit :

May be this issue : https://pharo.fogbugz.com/f/cases/18684/Versionner-Error-while-commiting-a-configuration-for-the-first-time

And here for the fix : https://pharo.fogbugz.com/f/cases/18927/Komitter-throws-up-if-it-has-committed-everything

Hernán

2016-09-28 1:29 GMT-03:00 stepharo <[hidden email]>:

Yes it was fix in pharo 60 and we should port it back but I forgot the issue number



Le 27/9/16 à 21:00, Hernán Morales Durand a écrit :

When commiting with Versionner in Pharo 5.0 I always have to manually override this method

KomitStagingArea>>remotes
    | result |

    result := self packages first remotes.
    self packages allButFirst do: [ :each |
        result := result intersection: each remotes ].

    ^ result collect: [ :each | each koRemote ]

to

KomitStagingArea>>remotes

    self packages isEmpty
        ifFalse: [
            | result |
            result := self packages first remotes.
            self packages allButFirst do: [ :each |
                result := result intersection: each remotes ].
            ^ result collect: [ :each | each koRemote ] ].
    ^ Array empty.

Screenshot attached.
Is this known issue or was this reported before?

Hernan