Smalltalk › Squeak › Squeak VM

Suspicious C Compiler warning in Spur garbage collector

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Nicolas Cellier

Suspicious C Compiler warning in Spur garbage collector

Here is the raw complaint:

../../spur64src/vm/gcc3x-cointerp.c:18467:28: warning: implicit conversion from 'double' to 'sqInt' (aka 'long long') changes value from 0.9 to 0 [-Wliteral-conversion]
GIV(tenuringProportion) = 0.9;

Eliot Miranda-2

Re: Suspicious C Compiler warning in Spur garbage collector

Hi Nicolas,

_,,,^..^,,,_ (phone)

> On Jul 20, 2016, at 9:44 AM, Nicolas Cellier <[hidden email]> wrote:
>
> Here is the raw complaint:
>
> ../../spur64src/vm/gcc3x-cointerp.c:18467:28: warning: implicit conversion from 'double' to 'sqInt' (aka 'long long') changes value from 0.9 to 0 [-Wliteral-conversion]
> GIV(tenuringProportion) = 0.9;

tenuringProportion should be defined as having type double in the class-side #declareCVarsIn: in the class that defines the inst var (SpurGenerationScavenger or SpurMemoryManager).

Nicolas Cellier

Re: Suspicious C Compiler warning in Spur garbage collector

Hi Eliot,

effectively, I see no code for declaring this inst. var. type, so it must default to sqInt...

I'm about to commit.

2016-07-20 17:19 GMT+02:00 Eliot Miranda <[hidden email]>:

Hi Nicolas,

_,,,^..^,,,_ (phone)

> On Jul 20, 2016, at 9:44 AM, Nicolas Cellier <[hidden email]> wrote:
>
> Here is the raw complaint:
>
> ../../spur64src/vm/gcc3x-cointerp.c:18467:28: warning: implicit conversion from 'double' to 'sqInt' (aka 'long long') changes value from 0.9 to 0 [-Wliteral-conversion]
> GIV(tenuringProportion) = 0.9;

tenuringProportion should be defined as having type double in the class-side #declareCVarsIn: in the class that defines the inst var (SpurGenerationScavenger or SpurMemoryManager).