Swazoo 2.2 beta with fast file upload

Dear Smalltalkers,

New Swazoo 2.2 is ready for beta testing, with much improved upload
(input streaming) performance as a main new feature.

On Squeak it uploads 15 times faster than before, achieving 1.5MB/s
throughput locally on my Linux 3.2GHz PC.

On VisualWorks it is even more impressive: 30 times better, achieving
15MB/s throughput. This means only 20s for 300MB file upload!

In both cases upload performance is about half of the download one due
to additional MIME parsing needed.

I can say that now we have an Smalltalk web server with comparable
performance to others in terms on upload performance too. This also
means that Swazoo is ready for demanding upload tasks like video
uploading as well, while video (like screencast) serving is a common
practice for a while.


Please help testing it. It is available here:

- Squeak: http://www.squeaksource.com/Swazoo/Swazoo-2.2.beta1.mcz

- VisualWorks: in public Store: Swazoo 2.2beta1

Best regards
Janko


--
Janko Mivšek
AIDA/Web
Smalltalk Web Application Server
http://www.aidaweb.si


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

> Please help testing it. It is available here:
>
> - Squeak: http://www.squeaksource.com/Swazoo/Swazoo-2.2.beta1.mcz

For portability, you should look for subtractions without a space on
either side.  I found a few in the new code for POST handling (all of
them something-1 or something-2).

The class definition for CompositeResourceTest is missing.

I haven't load it yet in GST though.

Paolo



_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Paolo Bonzini wrote:
>> Please help testing it. It is available here:
>>
>> - Squeak: http://www.squeaksource.com/Swazoo/Swazoo-2.2.beta1.mcz
>
> For portability, you should look for subtractions without a space on
> either side.  I found a few in the new code for POST handling (all of
> them something-1 or something-2).
>
> The class definition for CompositeResourceTest is missing.

Other nits:

- this, I really don't like:

watchdogSites
     self sites do:
         [:each |
         each isServing
            ifTrue: [(each isKindOf: AIDASite) ifTrue: [each
setLastTimeAliveTimestamp]]]

why not just add Site>>#watchdogEvent (as empty method) and override it
in AIDASite?  I'll do this for GNU Smalltalk.

- #watchdogOther is not defined.

- I had sent to Janko a changeset fixing a race condition.  I have a
small difference in two methods that probably were not merged correctly.
  Here they are:

     HTTPConnection >> nextPutError: aResponse
         aResponse informConnectionClose.
         aResponse writeTo: self stream.

     HTTPConnection >> nextPutResponse: aMessage toRequest: aRequest
         aMessage writeTo: self stream inResponseTo: aRequest

because #writeTo: and #writeTo:inResponseTo: already do a #closeResponse.


I didn't find any other problem in my review of the code in 2.1 vs.
2.2beta.  I am struggling with the usual non-portability of SwazooBuffer
but everything else seems to work.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Paolo Bonzini wrote:

>> Please help testing it. It is available here:
>>
>> - Squeak: http://www.squeaksource.com/Swazoo/Swazoo-2.2.beta1.mcz
>
> For portability, you should look for subtractions without a space on
> either side.  I found a few in the new code for POST handling (all of
> them something-1 or something-2).

I just corrected that. But you should think about improving GST parser a
bit ;)

The same goes with comparison too (a>b)? What about additions (a+b, a+2)?

> The class definition for CompositeResourceTest is missing.

Where it is missing? I don't see anything missing.

--
Janko Mivšek
AIDA/Web
Smalltalk Web Application Server
http://www.aidaweb.si


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

>> For portability, you should look for subtractions without a space on
>> either side.  I found a few in the new code for POST handling (all of
>> them something-1 or something-2).
>
> I just corrected that. But you should think about improving GST parser a
> bit ;)
>
> The same goes with comparison too (a>b)? What about additions (a+b, a+2)?

No, only - is a problem, and only if the second argument is a number.

>> The class definition for CompositeResourceTest is missing.
>
> Where it is missing? I don't see anything missing.

Oops, I deleted it by mistake and blamed you then.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

> I just corrected that. But you should think about improving GST parser a
> bit ;)

Ok, done. :-)

I applied it to 3.0 too because it is pretty safe.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

CONTENTS DELETED

> I tried loading it in the head revision (version reports 3.0c) and I
> get the following error when I fileIn the gst-converted source file:

3.0c and HEAD already have it.  Indeed SwazooStream is the only class
that needed almost a rewrite in GNU Smalltalk (because its library is
not based on Smalltalk-80's, unlike Squeak and VisualWorks', it has
different instance variable names).  I will sooner or later rewrite
SwazooStream to derive directly from Stream.

Thanks for your effort anyway!

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk