SystemReport's font

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

SystemReport's font

Eliot Miranda-2
Hi All,

     see SystemReporter>>#updateReport
report := Text streamContents: [:stream | 
stream 
withAttribute: (TextFontReference toFont: Preferences standardFixedFont)
do: [
self categoryList do: [:each |
(categoriesSelected includes: each) ifTrue: [
self perform: ((categories at: each), ':') asSymbol with: stream.
stream cr]]]].
self changed: #reportText

this means that on first opening the System Report there is a proportional font and on selecting any tab the report becomes fixed pitch.  It should be one or the other and not switch between the two.  Personally I prefer it remaining proportional.  Would people object if I disabled the switch to a fixed pitch font?  Or Does anyone feel strongly that the report should be in a fixed pitch font or that it should be a preference?

_,,,^..^,,,_
best, Eliot


Reply | Threaded
Open this post in threaded view
|

Re: SystemReport's font

Chris Muller-3
Some of the reports in there are tabular, requiring a fixed pitch.

Almost would be nice if it could be Help-Entry specific...

On Fri, Jun 2, 2017 at 7:01 PM, Eliot Miranda <[hidden email]> wrote:

> Hi All,
>
>      see SystemReporter>>#updateReport
> report := Text streamContents: [:stream |
> stream
> withAttribute: (TextFontReference toFont: Preferences standardFixedFont)
> do: [
> self categoryList do: [:each |
> (categoriesSelected includes: each) ifTrue: [
> self perform: ((categories at: each), ':') asSymbol with: stream.
> stream cr]]]].
> self changed: #reportText
>
> this means that on first opening the System Report there is a proportional
> font and on selecting any tab the report becomes fixed pitch.  It should be
> one or the other and not switch between the two.  Personally I prefer it
> remaining proportional.  Would people object if I disabled the switch to a
> fixed pitch font?  Or Does anyone feel strongly that the report should be in
> a fixed pitch font or that it should be a preference?
>
> _,,,^..^,,,_
> best, Eliot
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: SystemReport's font

Robert Hirschfeld
In reply to this post by Eliot Miranda-2
Hi Eliot --

I'm in favor of introducing a preference, mainly for consistency reasons (same font setting for all development/base tools)...

Best,

On 3. Jun 2017, at 09:01, Eliot Miranda <[hidden email]> wrote:

Hi All,

     see SystemReporter>>#updateReport
report := Text streamContents: [:stream | 
stream 
withAttribute: (TextFontReference toFont: Preferences standardFixedFont)
do: [
self categoryList do: [:each |
(categoriesSelected includes: each) ifTrue: [
self perform: ((categories at: each), ':') asSymbol with: stream.
stream cr]]]].
self changed: #reportText

this means that on first opening the System Report there is a proportional font and on selecting any tab the report becomes fixed pitch.  It should be one or the other and not switch between the two.  Personally I prefer it remaining proportional.  Would people object if I disabled the switch to a fixed pitch font?  Or Does anyone feel strongly that the report should be in a fixed pitch font or that it should be a preference?

_,,,^..^,,,_
best, Eliot



Reply | Threaded
Open this post in threaded view
|

Re: SystemReport's font

marcel.taeumel
In reply to this post by Eliot Miranda-2
Hi Eliot,

it worked fine in Squeak 5.1 and was a fixed-width font all the time. :) Maybe something got broken with the latest Etoys merging efforts? I would diff against Squeak 5.1 sources because time stamps can be misleading due to Etoys code being older than many fixes in 5.1.

Best,
Marcel