Test skip isn't working?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Test skip isn't working?

Vitor Medina Cruz
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.
Reply | Threaded
Open this post in threaded view
|

Re: Test skip isn't working?

Vitor Medina Cruz
Skip only works when I run tests from class. If I click the test button from the method skipped it don't work, maybe an error in calypso?

On Sun, Mar 17, 2019 at 3:13 PM Vitor Medina Cruz <[hidden email]> wrote:
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.
Reply | Threaded
Open this post in threaded view
|

Re: Test skip isn't working?

Denis Kudriashov
I think it is a feature. When you click icon on a single test you explicitly raise a wish to run it. 

пн, 18 мар. 2019 г., 1:26 Vitor Medina Cruz <[hidden email]>:
Skip only works when I run tests from class. If I click the test button from the method skipped it don't work, maybe an error in calypso?

On Sun, Mar 17, 2019 at 3:13 PM Vitor Medina Cruz <[hidden email]> wrote:
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.
Reply | Threaded
Open this post in threaded view
|

Re: Test skip isn't working?

Vitor Medina Cruz
It is confusing because something unexpected and different from what is explicitly said on code happens... I consider it an error.

I think It should execute informing the test is skipped or don't provide the click button at all. It took me a long time looking at skip implementation and trying different stuff until I figure I hadn't done anything wrong.

On Mon, Mar 18, 2019 at 4:22 AM Denis Kudriashov <[hidden email]> wrote:
I think it is a feature. When you click icon on a single test you explicitly raise a wish to run it. 

пн, 18 мар. 2019 г., 1:26 Vitor Medina Cruz <[hidden email]>:
Skip only works when I run tests from class. If I click the test button from the method skipped it don't work, maybe an error in calypso?

On Sun, Mar 17, 2019 at 3:13 PM Vitor Medina Cruz <[hidden email]> wrote:
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.
Reply | Threaded
Open this post in threaded view
|

Re: Test skip isn't working?

Ben Coman
This is a tough one to consider.  Dennis's position seems very reasonable, but that Vitor got stuck is an indication of something missing.
Just one other option occurs to me, that a notification pops up saying "force run skipped method",
but I'm not even sure that would be beneficial.

cheers -ben

On Mon, 18 Mar 2019 at 22:21, Vitor Medina Cruz <[hidden email]> wrote:
It is confusing because something unexpected and different from what is explicitly said on code happens... I consider it an error.

I think It should execute informing the test is skipped or don't provide the click button at all. It took me a long time looking at skip implementation and trying different stuff until I figure I hadn't done anything wrong.

On Mon, Mar 18, 2019 at 4:22 AM Denis Kudriashov <[hidden email]> wrote:
I think it is a feature. When you click icon on a single test you explicitly raise a wish to run it. 

пн, 18 мар. 2019 г., 1:26 Vitor Medina Cruz <[hidden email]>:
Skip only works when I run tests from class. If I click the test button from the method skipped it don't work, maybe an error in calypso?

On Sun, Mar 17, 2019 at 3:13 PM Vitor Medina Cruz <[hidden email]> wrote:
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.
Reply | Threaded
Open this post in threaded view
|

Re: Test skip isn't working?

Christopher Fuhrman
What about:

self skipOnClassRun: 'message'.

?

On Mon, Mar 18, 2019, 15:53 Ben Coman <[hidden email]> wrote:
This is a tough one to consider.  Dennis's position seems very reasonable, but that Vitor got stuck is an indication of something missing.
Just one other option occurs to me, that a notification pops up saying "force run skipped method",
but I'm not even sure that would be beneficial.

cheers -ben

On Mon, 18 Mar 2019 at 22:21, Vitor Medina Cruz <[hidden email]> wrote:
It is confusing because something unexpected and different from what is explicitly said on code happens... I consider it an error.

I think It should execute informing the test is skipped or don't provide the click button at all. It took me a long time looking at skip implementation and trying different stuff until I figure I hadn't done anything wrong.

On Mon, Mar 18, 2019 at 4:22 AM Denis Kudriashov <[hidden email]> wrote:
I think it is a feature. When you click icon on a single test you explicitly raise a wish to run it. 

пн, 18 мар. 2019 г., 1:26 Vitor Medina Cruz <[hidden email]>:
Skip only works when I run tests from class. If I click the test button from the method skipped it don't work, maybe an error in calypso?

On Sun, Mar 17, 2019 at 3:13 PM Vitor Medina Cruz <[hidden email]> wrote:
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.
Reply | Threaded
Open this post in threaded view
|

Re: Test skip isn't working?

Vitor Medina Cruz
I think that maybe a different visual indicator with a text hint saying that if you click you are force executing it.

The way it is is inconsistent, IMHO.

On Mon, Mar 18, 2019 at 6:09 PM Christopher Fuhrman <[hidden email]> wrote:
What about:

self skipOnClassRun: 'message'.

?

On Mon, Mar 18, 2019, 15:53 Ben Coman <[hidden email]> wrote:
This is a tough one to consider.  Dennis's position seems very reasonable, but that Vitor got stuck is an indication of something missing.
Just one other option occurs to me, that a notification pops up saying "force run skipped method",
but I'm not even sure that would be beneficial.

cheers -ben

On Mon, 18 Mar 2019 at 22:21, Vitor Medina Cruz <[hidden email]> wrote:
It is confusing because something unexpected and different from what is explicitly said on code happens... I consider it an error.

I think It should execute informing the test is skipped or don't provide the click button at all. It took me a long time looking at skip implementation and trying different stuff until I figure I hadn't done anything wrong.

On Mon, Mar 18, 2019 at 4:22 AM Denis Kudriashov <[hidden email]> wrote:
I think it is a feature. When you click icon on a single test you explicitly raise a wish to run it. 

пн, 18 мар. 2019 г., 1:26 Vitor Medina Cruz <[hidden email]>:
Skip only works when I run tests from class. If I click the test button from the method skipped it don't work, maybe an error in calypso?

On Sun, Mar 17, 2019 at 3:13 PM Vitor Medina Cruz <[hidden email]> wrote:
Hello,

someTest
    self skip: 'some message'.

    rest of the test

Rest of the test is being executed. There is a different woy of skipping tests?

Thanks,
Vitor.