The Inbox: 39Deprecated-fbs.20.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: 39Deprecated-fbs.20.mcz

commits-2
Frank Shearar uploaded a new version of 39Deprecated to project The Inbox:
http://source.squeak.org/inbox/39Deprecated-fbs.20.mcz

==================== Summary ====================

Name: 39Deprecated-fbs.20
Author: fbs
Time: 25 July 2012, 9:42:16.56 pm
UUID: b22c5338-3200-4545-89bc-3f75c07e39af
Ancestors: 39Deprecated-ar.19

These methods are deprecated, and I can find no uses in the base image.

=============== Diff against 39Deprecated-ar.19 ===============

Item was removed:
- ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
- flush
- self deprecated: 'use removeAll'.
- ^self removeAll!

Item was removed:
- ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
- flushAllSuchThat: aBlock
- self deprecated: 'use removeAllSuchThat:'.
-
- ^self removeAllSuchThat: aBlock!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: 39Deprecated-fbs.20.mcz

Levente Uzonyi-2
The original idea was that SharedQueue2 will replace SharedQueue. The
problem is that this didn't happen and SharedQueue only understands #flush
and #flushAllSuchThat:, so removing these methods will not enable us to
do the switch. The reason why it didn't happen yet is probably
performance. In the meantime Igor made some other queues which don't use
any synchronization primitives, so they are a lot faster than both
SharedQueue and SharedQueue2 for the basic operations. In theory Pharo
uses one of those queues instead of SharedQueue in EventSensor (or it's
replacement), though I'm not sure, since I didn't check it.
Anyway, SharedQueue is a hack, SharedQueue2 is clean(er), but slow(er).


Levente

On Wed, 25 Jul 2012, [hidden email] wrote:

> Frank Shearar uploaded a new version of 39Deprecated to project The Inbox:
> http://source.squeak.org/inbox/39Deprecated-fbs.20.mcz
>
> ==================== Summary ====================
>
> Name: 39Deprecated-fbs.20
> Author: fbs
> Time: 25 July 2012, 9:42:16.56 pm
> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
> Ancestors: 39Deprecated-ar.19
>
> These methods are deprecated, and I can find no uses in the base image.
>
> =============== Diff against 39Deprecated-ar.19 ===============
>
> Item was removed:
> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
> - flush
> - self deprecated: 'use removeAll'.
> - ^self removeAll!
>
> Item was removed:
> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
> - flushAllSuchThat: aBlock
> - self deprecated: 'use removeAllSuchThat:'.
> -
> - ^self removeAllSuchThat: aBlock!
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: 39Deprecated-fbs.20.mcz

Frank Shearar-3
On 25 July 2012 23:56, Levente Uzonyi <[hidden email]> wrote:

> The original idea was that SharedQueue2 will replace SharedQueue. The
> problem is that this didn't happen and SharedQueue only understands #flush
> and #flushAllSuchThat:, so removing these methods will not enable us to do
> the switch. The reason why it didn't happen yet is probably performance. In
> the meantime Igor made some other queues which don't use any synchronization
> primitives, so they are a lot faster than both SharedQueue and SharedQueue2
> for the basic operations. In theory Pharo uses one of those queues instead
> of SharedQueue in EventSensor (or it's replacement), though I'm not sure,
> since I didn't check it.
> Anyway, SharedQueue is a hack, SharedQueue2 is clean(er), but slow(er).

OK, so these two methods are there to support something we're trying
to lose anyway. So how about we ditch this changeset and, after 4.4's
out, we use Igor's implementation, and replace SharedQueue with that?
(After 4.4's release, because this sounds like an invasive change, and
I don't want that kind of thing landing just before a release!)

frank

> Levente
>
>
> On Wed, 25 Jul 2012, [hidden email] wrote:
>
>> Frank Shearar uploaded a new version of 39Deprecated to project The Inbox:
>> http://source.squeak.org/inbox/39Deprecated-fbs.20.mcz
>>
>> ==================== Summary ====================
>>
>> Name: 39Deprecated-fbs.20
>> Author: fbs
>> Time: 25 July 2012, 9:42:16.56 pm
>> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
>> Ancestors: 39Deprecated-ar.19
>>
>> These methods are deprecated, and I can find no uses in the base image.
>>
>> =============== Diff against 39Deprecated-ar.19 ===============
>>
>> Item was removed:
>> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
>> - flush
>> -       self deprecated: 'use removeAll'.
>> -       ^self removeAll!
>>
>> Item was removed:
>> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category
>> '*39Deprecated') -----
>> - flushAllSuchThat: aBlock
>> -       self deprecated: 'use removeAllSuchThat:'.
>> -
>> -       ^self removeAllSuchThat: aBlock!
>>
>>
>>
>