Quantcast

The Inbox: Collections-nice.753.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

The Inbox: Collections-nice.753.mcz

commits-2
Nicolas Cellier uploaded a new version of Collections to project The Inbox:
http://source.squeak.org/inbox/Collections-nice.753.mcz

==================== Summary ====================

Name: Collections-nice.753
Author: nice
Time: 26 April 2017, 11:56:06.826092 pm
UUID: 5f5b9a99-afa3-40f2-8fb5-a9a6183d10b5
Ancestors: Collections-nice.752

Nuke obsolete brace constructs used by compiler long long ago.

Since encoder v3 (plus closures) there is a dedicated byte code for constructing those arrays dynamically, so the #braceWith: like messages are not sent for a while and won't be used anymore in foreseeable future.

=============== Diff against Collections-nice.752 ===============

Item was removed:
- ----- Method: Array class>>braceWith: (in category 'brace support') -----
- braceWith: a
- "This method is used in compilation of brace constructs.
- It MUST NOT be deleted or altered."
-
- | array |
- array := self new: 1.
- array at: 1 put: a.
- ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with: (in category 'brace support') -----
- braceWith: a with: b
- "This method is used in compilation of brace constructs.
- It MUST NOT be deleted or altered."
-
- | array |
- array := self new: 2.
- array at: 1 put: a.
- array at: 2 put: b.
- ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with:with: (in category 'brace support') -----
- braceWith: a with: b with: c
- "This method is used in compilation of brace constructs.
- It MUST NOT be deleted or altered."
-
- | array |
- array := self new: 3.
- array at: 1 put: a.
- array at: 2 put: b.
- array at: 3 put: c.
- ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with:with:with: (in category 'brace support') -----
- braceWith: a with: b with: c with: d
- "This method is used in compilation of brace constructs.
- It MUST NOT be deleted or altered."
-
- | array |
- array := self new: 4.
- array at: 1 put: a.
- array at: 2 put: b.
- array at: 3 put: c.
- array at: 4 put: d.
- ^ array!

Item was removed:
- ----- Method: Array class>>braceWithNone (in category 'brace support') -----
- braceWithNone
- "This method is used in compilation of brace constructs.
- It MUST NOT be deleted or altered."
-
- ^ self new: 0!


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: The Inbox: Collections-nice.753.mcz

Nicolas Cellier
Hi Eliot,
last two commits in inbox are waiting for your blessing
cheers

2017-04-26 23:56 GMT+02:00 <[hidden email]>:
Nicolas Cellier uploaded a new version of Collections to project The Inbox:
http://source.squeak.org/inbox/Collections-nice.753.mcz

==================== Summary ====================

Name: Collections-nice.753
Author: nice
Time: 26 April 2017, 11:56:06.826092 pm
UUID: 5f5b9a99-afa3-40f2-8fb5-a9a6183d10b5
Ancestors: Collections-nice.752

Nuke obsolete brace constructs used by compiler long long ago.

Since encoder v3 (plus closures) there is a dedicated byte code for constructing those arrays dynamically, so the #braceWith: like messages are not sent for a while and won't be used anymore in foreseeable future.

=============== Diff against Collections-nice.752 ===============

Item was removed:
- ----- Method: Array class>>braceWith: (in category 'brace support') -----
- braceWith: a
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 1.
-       array at: 1 put: a.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with: (in category 'brace support') -----
- braceWith: a with: b
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 2.
-       array at: 1 put: a.
-       array at: 2 put: b.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with:with: (in category 'brace support') -----
- braceWith: a with: b with: c
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 3.
-       array at: 1 put: a.
-       array at: 2 put: b.
-       array at: 3 put: c.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with:with:with: (in category 'brace support') -----
- braceWith: a with: b with: c with: d
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 4.
-       array at: 1 put: a.
-       array at: 2 put: b.
-       array at: 3 put: c.
-       array at: 4 put: d.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWithNone (in category 'brace support') -----
- braceWithNone
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       ^ self new: 0!





Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: The Inbox: Collections-nice.753.mcz

Eliot Miranda-2
Hi Nicolas,

forgive me, I've been too busy :-(.  I think both of these are good and you should commit.  The next task is to implement FullBlocks along side the V3 embedded blocks.  So as much clean up as possible is appreciated :-)

On Wed, Apr 26, 2017 at 2:58 PM, Nicolas Cellier <[hidden email]> wrote:
Hi Eliot,
last two commits in inbox are waiting for your blessing
cheers

2017-04-26 23:56 GMT+02:00 <[hidden email]>:
Nicolas Cellier uploaded a new version of Collections to project The Inbox:
http://source.squeak.org/inbox/Collections-nice.753.mcz

==================== Summary ====================

Name: Collections-nice.753
Author: nice
Time: 26 April 2017, 11:56:06.826092 pm
UUID: 5f5b9a99-afa3-40f2-8fb5-a9a6183d10b5
Ancestors: Collections-nice.752

Nuke obsolete brace constructs used by compiler long long ago.

Since encoder v3 (plus closures) there is a dedicated byte code for constructing those arrays dynamically, so the #braceWith: like messages are not sent for a while and won't be used anymore in foreseeable future.

=============== Diff against Collections-nice.752 ===============

Item was removed:
- ----- Method: Array class>>braceWith: (in category 'brace support') -----
- braceWith: a
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 1.
-       array at: 1 put: a.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with: (in category 'brace support') -----
- braceWith: a with: b
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 2.
-       array at: 1 put: a.
-       array at: 2 put: b.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with:with: (in category 'brace support') -----
- braceWith: a with: b with: c
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 3.
-       array at: 1 put: a.
-       array at: 2 put: b.
-       array at: 3 put: c.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWith:with:with:with: (in category 'brace support') -----
- braceWith: a with: b with: c with: d
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       | array |
-       array := self new: 4.
-       array at: 1 put: a.
-       array at: 2 put: b.
-       array at: 3 put: c.
-       array at: 4 put: d.
-       ^ array!

Item was removed:
- ----- Method: Array class>>braceWithNone (in category 'brace support') -----
- braceWithNone
-       "This method is used in compilation of brace constructs.
-       It MUST NOT be deleted or altered."
-
-       ^ self new: 0!









--
_,,,^..^,,,_
best, Eliot


Loading...