The Inbox: EToys-kfr.412.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: EToys-kfr.412.mcz

commits-2
A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-kfr.412.mcz

==================== Summary ====================

Name: EToys-kfr.412
Author: kfr
Time: 17 October 2020, 6:03:37.158564 pm
UUID: 391b4e19-c1be-b94a-9ce4-1da156f696c0
Ancestors: EToys-kfr.392, EToys-eem.411

self world can return nil

=============== Diff against EToys-kfr.392 ===============

Item was changed:
  ----- Method: CategoryViewer>>assureCategoryFullyVisible (in category '*Etoys-Squeakland-categories') -----
  assureCategoryFullyVisible
  "Keep deleting categoryviewers other than the receiver  until the receiver is fully visible."
 
  | ready toDelete |
  ready := false.
+ [(self bounds bottom > Project current world bottom) and: [ready not]] whileTrue: [
+ owner submorphs size > 2
+ ifTrue: [
+ toDelete := owner submorphs allButFirst reversed
+ detect: [:cv | cv ~~ self]
+ ifNone: [^ self].
- [(self  bounds bottom > ActiveWorld bottom) and: [ready not]] whileTrue:
- [owner submorphs size > 2 ifTrue:
- [toDelete :=owner submorphs allButFirst reversed detect: [:cv | cv ~~ self] ifNone: [^ self].
  toDelete delete.
+ self world doOneCycleNow]
+ ifFalse: [
+ ready := true]].!
- ActiveWorld doOneCycleNow]
- ifFalse:
- [ready := true]]!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

timrowledge


> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.



Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

marcel.taeumel
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.





Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

Karl Ramberg
Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.