The Inbox: EToys-kfr.412.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: EToys-kfr.412.mcz

commits-2
A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-kfr.412.mcz

==================== Summary ====================

Name: EToys-kfr.412
Author: kfr
Time: 17 October 2020, 6:03:37.158564 pm
UUID: 391b4e19-c1be-b94a-9ce4-1da156f696c0
Ancestors: EToys-kfr.392, EToys-eem.411

self world can return nil

=============== Diff against EToys-kfr.392 ===============

Item was changed:
  ----- Method: CategoryViewer>>assureCategoryFullyVisible (in category '*Etoys-Squeakland-categories') -----
  assureCategoryFullyVisible
  "Keep deleting categoryviewers other than the receiver  until the receiver is fully visible."
 
  | ready toDelete |
  ready := false.
+ [(self bounds bottom > Project current world bottom) and: [ready not]] whileTrue: [
+ owner submorphs size > 2
+ ifTrue: [
+ toDelete := owner submorphs allButFirst reversed
+ detect: [:cv | cv ~~ self]
+ ifNone: [^ self].
- [(self  bounds bottom > ActiveWorld bottom) and: [ready not]] whileTrue:
- [owner submorphs size > 2 ifTrue:
- [toDelete :=owner submorphs allButFirst reversed detect: [:cv | cv ~~ self] ifNone: [^ self].
  toDelete delete.
+ self world doOneCycleNow]
+ ifFalse: [
+ ready := true]].!
- ActiveWorld doOneCycleNow]
- ifFalse:
- [ready := true]]!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

timrowledge


> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.



Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

marcel.taeumel
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.





Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

Karl Ramberg
Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.






Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

marcel.taeumel
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.






Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

Karl Ramberg
Cool.
I'll revise the other changes once I have time.

I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

Best,
Karl

On Thu, Oct 29, 2020 at 5:06 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.







Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

marcel.taeumel
I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

You mean after or even before calling "ReleaseBuilderSqueakland setEtoysMode"?

Best,
Marcel

Am 30.10.2020 19:04:25 schrieb karl ramberg <[hidden email]>:

Cool.
I'll revise the other changes once I have time.

I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

Best,
Karl

On Thu, Oct 29, 2020 at 5:06 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.







Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

Karl Ramberg
I made a method that load the most essential Etoy Icons so Etoys look ok even in standard Squeak.


On Fri, Oct 30, 2020 at 7:07 PM Marcel Taeumel <[hidden email]> wrote:
I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

You mean after or even before calling "ReleaseBuilderSqueakland setEtoysMode"?

Best,
Marcel

Am 30.10.2020 19:04:25 schrieb karl ramberg <[hidden email]>:

Cool.
I'll revise the other changes once I have time.

I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

Best,
Karl

On Thu, Oct 29, 2020 at 5:06 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.








Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

Karl Ramberg
 It loads these just the most used forms and so it should be fine for standard image.
It makes etoys and BookMorph look ok.
It should be called from ReleaseBuilder. But I'm not sure where to trigger the loading.
Here are a list of the forms:
"RoundGoldBox, TryItPressed, TryIt, MenuIcon, AddCategoryViewer, AddInstanceVariable, TanOPressed, TanO, Gets, RightCaret, DownCaret, NextPage, NextPagePressed, PrevPage, PrevPagePressed"

On Fri, Oct 30, 2020 at 7:13 PM karl ramberg <[hidden email]> wrote:
I made a method that load the most essential Etoy Icons so Etoys look ok even in standard Squeak.


On Fri, Oct 30, 2020 at 7:07 PM Marcel Taeumel <[hidden email]> wrote:
I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

You mean after or even before calling "ReleaseBuilderSqueakland setEtoysMode"?

Best,
Marcel

Am 30.10.2020 19:04:25 schrieb karl ramberg <[hidden email]>:

Cool.
I'll revise the other changes once I have time.

I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

Best,
Karl

On Thu, Oct 29, 2020 at 5:06 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.








Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

marcel.taeumel
Hi Karl,

done and already merged into Trunk. Next build artifacts on files.squeak.org will have those icons loaded.

Thanks!
Marcel

Am 30.10.2020 19:18:01 schrieb karl ramberg <[hidden email]>:

 It loads these just the most used forms and so it should be fine for standard image.
It makes etoys and BookMorph look ok.
It should be called from ReleaseBuilder. But I'm not sure where to trigger the loading.
Here are a list of the forms:
"RoundGoldBox, TryItPressed, TryIt, MenuIcon, AddCategoryViewer, AddInstanceVariable, TanOPressed, TanO, Gets, RightCaret, DownCaret, NextPage, NextPagePressed, PrevPage, PrevPagePressed"

On Fri, Oct 30, 2020 at 7:13 PM karl ramberg <[hidden email]> wrote:
I made a method that load the most essential Etoy Icons so Etoys look ok even in standard Squeak.


On Fri, Oct 30, 2020 at 7:07 PM Marcel Taeumel <[hidden email]> wrote:
I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

You mean after or even before calling "ReleaseBuilderSqueakland setEtoysMode"?

Best,
Marcel

Am 30.10.2020 19:04:25 schrieb karl ramberg <[hidden email]>:

Cool.
I'll revise the other changes once I have time.

I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

Best,
Karl

On Thu, Oct 29, 2020 at 5:06 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.








Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.412.mcz

Christoph Thiede

Hi Karl, hi Marcel,


thanks for caring. Can we backport this change to at least Squeak 5.3? I'm sure the users will love to know what their buttons do in older versions, too. In other words, I'd consider the current appearance in Squeak 5.3 a bug ...


This should be quite easy by writing an adequate postscript, shouldn't it?


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 2. November 2020 17:05:21
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: EToys-kfr.412.mcz
 
Hi Karl,

done and already merged into Trunk. Next build artifacts on files.squeak.org will have those icons loaded.

Thanks!
Marcel

Am 30.10.2020 19:18:01 schrieb karl ramberg <[hidden email]>:

 It loads these just the most used forms and so it should be fine for standard image.
It makes etoys and BookMorph look ok.
It should be called from ReleaseBuilder. But I'm not sure where to trigger the loading.
Here are a list of the forms:
"RoundGoldBox, TryItPressed, TryIt, MenuIcon, AddCategoryViewer, AddInstanceVariable, TanOPressed, TanO, Gets, RightCaret, DownCaret, NextPage, NextPagePressed, PrevPage, PrevPagePressed"

On Fri, Oct 30, 2020 at 7:13 PM karl ramberg <[hidden email]> wrote:
I made a method that load the most essential Etoy Icons so Etoys look ok even in standard Squeak.


On Fri, Oct 30, 2020 at 7:07 PM Marcel Taeumel <[hidden email]> wrote:
I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

You mean after or even before calling "ReleaseBuilderSqueakland setEtoysMode"?

Best,
Marcel

Am 30.10.2020 19:04:25 schrieb karl ramberg <[hidden email]>:

Cool.
I'll revise the other changes once I have time.

I'm not sure where in ReleaseBuilder to hook up the initialization of the Etoy icons. Any suggestions?

Best,
Karl

On Thu, Oct 29, 2020 at 5:06 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl.

Removed from inbox now

Just meant that for contributions to come. ^.^' Sorry for the mix up. 

Would you re-upload the contents from:

EToys-kfr.413
EToys-kfr.412
EToys-kfr.392

(I managed to merge Etoys-kfr.377 up to 380 from my local package-cache.)

Best,
Marcel

Am 21.10.2020 20:30:28 schrieb karl ramberg <[hidden email]>:

Removed from inbox now

Best,
Karl

On Wed, Oct 21, 2020 at 6:12 PM Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

please do not chain unprocessed inbox items in the ancestry. This way, we can never copy over your versions but always have to re-commit your changes method-by-method. Instead, base your changes on the most recent Trunk version.

EToys-kfr.413 (inbox) needs kfr.412 (inbox) but is unrelated
EToys-kfr.412 (inbox) needs kfr.392 (inbox) and eem.411 (trunk)
EToys-kfr.392 (inbox) needs kfr.378 (inbox) and mt.391 (trunk)
...

Yes, we will see to merge your EToys contributions ASAP. Thanks! ^__^

Best,
Marcel

Am 17.10.2020 20:03:09 schrieb tim Rowledge <[hidden email]>:



> On 2020-10-17, at 9:03 AM, [hidden email] wrote:
>
> self world can return nil

That is somehow both deeply philosophical and sad

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Settled some during shipping and handling.








Carpe Squeak!