Quantcast

The Inbox: Monticello-mva.662.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

The Inbox: Monticello-mva.662.mcz

commits-2
A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-mva.662.mcz

==================== Summary ====================

Name: Monticello-mva.662
Author: mva
Time: 9 February 2017, 4:08:00.271692 pm
UUID: 89b83b4f-f6f4-3445-94e8-a9e0b14f07cb
Ancestors: Monticello-mva.661

allow files with the same version-number to be selected in versionList in Repository browser when 'order by version-number' active

=============== Diff against Monticello-mva.661 ===============

Item was changed:
  MCVersionInspector subclass: #MCRepositoryInspector
+ instanceVariableNames: 'repository packageNames versionNames selectedPackage selectedVersion order versionInfo loaded newer inherited versionSelection'
- instanceVariableNames: 'repository packageNames versionNames selectedPackage selectedVersion order versionInfo loaded newer inherited'
  classVariableNames: 'BrowseBranchedVersionsSeparately Order'
  poolDictionaries: ''
  category: 'Monticello-UI'!

Item was changed:
  ----- Method: MCRepositoryInspector>>versionSelection (in category 'morphic ui') -----
  versionSelection
+ ^ versionSelection ifNil: [ 0 ]!
- ^self versionList indexOf: selectedVersion!

Item was changed:
  ----- Method: MCRepositoryInspector>>versionSelection: (in category 'morphic ui') -----
  versionSelection: aNumber
+ versionSelection := aNumber.
  selectedVersion := version := nil.
  aNumber isZero ifFalse: [ selectedVersion := (self versionList at: aNumber) asString ].
  self
  changed: #versionSelection ;
  changed: #summary ;
  changed: #hasVersion!


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: The Inbox: Monticello-mva.662.mcz

Bert Freudenberg
On Thu, Feb 9, 2017 at 4:10 PM, <[hidden email]> wrote:
Name: Monticello-mva.662
Author: mva
Time: 9 February 2017, 4:08:00.271692 pm
UUID: 89b83b4f-f6f4-3445-94e8-a9e0b14f07cb
Ancestors: Monticello-mva.661

allow files with the same version-number to be selected in versionList in Repository browser when 'order by version-number' active

Could you explain how to reproduce the problem this is trying to fix? Appears to be working fine for me.

- Bert - 


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: The Inbox: Monticello-mva.662.mcz

Milan Vavra
You are right. I am sorry. I can not reproduce this issue anymore.

So now the commit message is wrong on Monticello-mva.662.mcz.

This was intended as two part commit to make things easier to see
in History that seemed to have value on its own.
It no longer has value on its own and the commit message on it is wrong.

The bigger issue is that of

'unable to use filter on large remote repositories like the trunk'.

Try this:

Open the trunk Repository browser.
Make sure there is no selection on the left
(deselect 39Deprecated).
Select a package (Squeak-Version-tfel.4726.mcz) on the right.
Try typing 6 to filter for all those that have 6 in them.
This filters the list but is very slow.
As it stops, it downloads the package it found.
Now try to type 66 to filter for all those that have 66 in them.
Not try to type 660 to filter for all those that have 660 in them.
Type backspace to remove the filter.

Commit message for Monticello-mva.662.mcz should have been:

This is part 1 of 2 to resolve
'unable to use filter on large remote repositories like the trunk'
This part stores the index of the selected item versionSelection when changed
with #versionSelection: instead of looking it up linearly with #indexOf:
each time #versionSelection is called.

Commit message for Monticello-mva.663.mcz would have been:

This is part 2 of 2 to resolve
'unable to use filter on large remote repositories like the trunk'
This part calculates and stores the versionList lazily when set to nil
with #versionList: instead of calculating it each time #versionList is called.

So where do we go from here?

I am not sure how to proceed.

The commit message of the Monticello-mva.662.mcz
I have uploaded to the inbox is clearly wrong. Despite of the value of the
code for the combined fix.

Can I just create a new Monticello-mva.662.mcz and upload it to the inbox
with the proposed commit message?
Will that overwrite the old one?

Or should I upload the Monticello-mva.663.mcz to the inbox so that you can
see that when combined with Monticello-mva.663.mcz it solves the
'unable to use filter on large remote repositories like the trunk'
issue?

Best Regards,

Milan Vavra
Loading...