The Inbox: Morphic-kfr.1509.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Morphic-kfr.1509.mcz

commits-2
A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-kfr.1509.mcz

==================== Summary ====================

Name: Morphic-kfr.1509
Author: kfr
Time: 22 August 2019, 6:46:21.434151 pm
UUID: 8468fa35-928c-3849-8ee1-f86a3c72527a
Ancestors: Morphic-mt.1508

#removeModalWindow is deprecated, but many old projects still references to it. Remove reference upon loading project.

=============== Diff against Morphic-mt.1508 ===============

Item was changed:
  ----- Method: PasteUpMorph>>fixUponLoad:seg: (in category 'objects from disk') -----
+ fixUponLoad: aProject seg: anImageSegment
- fixUponLoad: aProject seg: anImageSegment
  "We are in an old project that is being loaded from disk.
+ Fix up conventions that have changed."
+ | weakMessage |
+ self isWorldMorph
+ ifTrue: [(self valueOfProperty: #soundAdditions)
+ ifNotNil: [:additions | SampledSound assimilateSoundsFrom: additions]].
+ self actionMap
+ ifNotNil: [:aDictionary |
+ weakMessage := aDictionary
+ at: #aboutToLeaveWorld
+ ifAbsent: [].
+ weakMessage
+ ifNotNil: [weakMessage selector = #removeModalWindow
+ ifTrue: [weakMessage receiver: nil]]].
- Fix up conventions that have changed."
-
- self isWorldMorph ifTrue: [
- (self valueOfProperty: #soundAdditions) ifNotNil:
- [:additions | SampledSound
- assimilateSoundsFrom: additions]].
-
  ^ super fixUponLoad: aProject seg: anImageSegment!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Morphic-kfr.1509.mcz

Hannes Hirzel
+1 for inclusion into the trunk as it fixes an old bug when loading
Etoys projects, see for example

       http://wiki.squeak.org/squeak/3815

It does not show the deprecation warning anymore when leaving the maze project.

--Hannes

On Thu, 22 Aug 2019 16:46:32 0000, [hidden email]
<[hidden email]> wrote:

> A new version of Morphic was added to project The Inbox:
> http://source.squeak.org/inbox/Morphic-kfr.1509.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-kfr.1509
> Author: kfr
> Time: 22 August 2019, 6:46:21.434151 pm
> UUID: 8468fa35-928c-3849-8ee1-f86a3c72527a
> Ancestors: Morphic-mt.1508
>
> #removeModalWindow is deprecated, but many old projects still references to
> it. Remove reference upon loading project.
>
> =============== Diff against Morphic-mt.1508 ===============
>
> Item was changed:
>   ----- Method: PasteUpMorph>>fixUponLoad:seg: (in category 'objects from
> disk') -----
> + fixUponLoad: aProject seg: anImageSegment
> - fixUponLoad: aProject seg: anImageSegment
>   "We are in an old project that is being loaded from disk.
> + Fix up conventions that have changed."
> + | weakMessage |
> + self isWorldMorph
> + ifTrue: [(self valueOfProperty: #soundAdditions)
> + ifNotNil: [:additions | SampledSound assimilateSoundsFrom:
> additions]].
> + self actionMap
> + ifNotNil: [:aDictionary |
> + weakMessage := aDictionary
> + at: #aboutToLeaveWorld
> + ifAbsent: [].
> + weakMessage
> + ifNotNil: [weakMessage selector = #removeModalWindow
> + ifTrue: [weakMessage receiver: nil]]].
> - Fix up conventions that have changed."
> -
> - self isWorldMorph ifTrue: [
> - (self valueOfProperty: #soundAdditions) ifNotNil:
> - [:additions | SampledSound
> - assimilateSoundsFrom: additions]].
> -
>   ^ super fixUponLoad: aProject seg: anImageSegment!
>
>
>