The Inbox: Morphic-spd.507.mcz

> A new version of Morphic was added to project The Inbox:
> http://source.squeak.org/inbox/Morphic-spd.507.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-spd.507
> Author: spd
> Time: 4 January 2011, 5:54:07.209 pm
> UUID: c5d862d6-b70d-4ef2-b9e5-8018b9949701
> Ancestors: Morphic-cmm.506
>
> Added comments for TextMorph's #autoFit: and #wrapFlag:, which I find horrendously confusing.  They are
> probably badly named, but at minimum deserve better comments.
>
> =============== Diff against Morphic-cmm.506 ===============
>
> Item was changed:
>  ----- Method: TextMorph>>autoFit: (in category 'accessing') -----
>  autoFit: trueOrFalse
> +       "Whether I automatically adjust my size to fit text as it changes"
> +
>        self isAutoFit = trueOrFalse ifTrue: [^ self].
> +       self autoFitOnOff.!
> -       self autoFitOnOff!
>
> Item was changed:
>  ----- Method: TextMorph>>wrapFlag: (in category 'accessing') -----
>  wrapFlag: aBoolean
> +       "Whether contained text will adjust its bounds as I change shape:
> +               |       wrapFlag        |               TextMorph grows                 |               TextMorph shrinks       |
> +               |               true            | wrapped lines fill new space  |       long lines wrap to fit          |
> +               |               false           |   wrapped lines stay same             |       long lines are cut off          |"
> -       "Change whether contents are wrapped to the container."
>
>        aBoolean == wrapFlag ifTrue: [^ self].
>        wrapFlag := aBoolean.
>        self composeToBounds!
>
>
>

> […]
>
> Chris Muller-3 wrote:
>>
>> Also, convention is to not end the last line with a period.
>>
> Ha, I thumb my nose at convention!  Just kidding, but it is a matter of
> style.  Or when you say convention, do you mean in Squeak?  Although I've
> seen plenty of both ways.
>
> Sean

>
>
> Tobias Pape wrote:
>>
>> I think it's more important to be consistent.
>>
>
> I used to feel the same way, until I read Andres Valloud's excellent
> "Fundamentals of Smalltalk Programming Technique, Volume 1"
> (http://www.lulu.com/product/paperback/fundamentals-of-smalltalk-programming-technique-volume-1/5299835).
> He has convinced me that the most powerful choice in projects such as Squeak
> is for each of us to train ourselves to be perfectly okay with *any* code
> style - it makes us and the system better.  Having said that, I will eat my
> own dog food and stop sneakily adding spaces before the first line and
> periods at the end of methods (my own preference) when I make fixes in the
> system :)
>
> Sean