The Inbox: SMLoader-cmm.92.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: SMLoader-cmm.92.mcz

commits-2
Chris Muller uploaded a new version of SMLoader to project The Inbox:
http://source.squeak.org/inbox/SMLoader-cmm.92.mcz

==================== Summary ====================

Name: SMLoader-cmm.92
Author: cmm
Time: 6 October 2018, 2:59:45.066275 pm
UUID: 7c4c92f1-6332-44d8-bd7c-e3702459df97
Ancestors: SMLoader-cmm.91

Begin to phase out 'published' flag unless we can remember what the original purpose of this level of detail in the model was for.

=============== Diff against SMLoader-cmm.91 ===============

Item was changed:
  ----- Method: SMLoader>>installPackageRelease (in category 'actions') -----
  installPackageRelease
  "Install selected package or release.
  The cache is used."
  | item release |
  item := self selectedPackageOrRelease
  ifNil: [^ nil].
  item isPackageRelease
  ifTrue: [^ self installPackageRelease: item]
+ ifFalse: [release := item lastReleaseForCurrentSystemVersion.
- ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
  release
  ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
  ifTrue: [release := item lastPublishedRelease.
  release
  ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
  ifTrue: [release := item lastRelease]]]].
  release
  ifNotNil: [^ self installPackageRelease: release]]!

Item was changed:
  ----- Method: SMLoaderPlus>>installPackageRelease (in category 'actions') -----
  installPackageRelease
  "Install selected package or release.
  The cache is used."
  | item release |
  item := self selectedPackageOrRelease
  ifNil: [^ nil].
  item isPackageRelease
  ifTrue: [^ self installPackageRelease: item]
+ ifFalse: [release := item lastReleaseForCurrentSystemVersion.
- ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
  release
  ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
  ifTrue: [release := item lastPublishedRelease.
  release
  ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
  ifTrue: [release := item lastRelease]]]].
  release
  ifNotNil: [^ self installPackageRelease: release]]!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: SMLoader-cmm.92.mcz

David T. Lewis
This seems like a very good idea to me. I (and apparently one or two other
hapless contributors) recently found myself confused about this, so if we
can't remember why the 'published' flag is there, I would be happy to see
it be ignored.

I also see that I have somehow managed to overlook SMLoader-cmm.89 in the
inbox for the last two years(!!!). This update seems to resolve the main
annoyance that I encounter when updating releases on SqueakMap for a new
release of the Squeak image.

So +1 for both of these from my point of view.

Dave


On Sat, Oct 06, 2018 at 08:00:16PM +0000, [hidden email] wrote:

> Chris Muller uploaded a new version of SMLoader to project The Inbox:
> http://source.squeak.org/inbox/SMLoader-cmm.92.mcz
>
> ==================== Summary ====================
>
> Name: SMLoader-cmm.92
> Author: cmm
> Time: 6 October 2018, 2:59:45.066275 pm
> UUID: 7c4c92f1-6332-44d8-bd7c-e3702459df97
> Ancestors: SMLoader-cmm.91
>
> Begin to phase out 'published' flag unless we can remember what the original purpose of this level of detail in the model was for.
>
> =============== Diff against SMLoader-cmm.91 ===============
>
> Item was changed:
>   ----- Method: SMLoader>>installPackageRelease (in category 'actions') -----
>   installPackageRelease
>   "Install selected package or release.
>   The cache is used."
>   | item release |
>   item := self selectedPackageOrRelease
>   ifNil: [^ nil].
>   item isPackageRelease
>   ifTrue: [^ self installPackageRelease: item]
> + ifFalse: [release := item lastReleaseForCurrentSystemVersion.
> - ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
>   release
>   ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
>   ifTrue: [release := item lastPublishedRelease.
>   release
>   ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
>   ifTrue: [release := item lastRelease]]]].
>   release
>   ifNotNil: [^ self installPackageRelease: release]]!
>
> Item was changed:
>   ----- Method: SMLoaderPlus>>installPackageRelease (in category 'actions') -----
>   installPackageRelease
>   "Install selected package or release.
>   The cache is used."
>   | item release |
>   item := self selectedPackageOrRelease
>   ifNil: [^ nil].
>   item isPackageRelease
>   ifTrue: [^ self installPackageRelease: item]
> + ifFalse: [release := item lastReleaseForCurrentSystemVersion.
> - ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
>   release
>   ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?')
>   ifTrue: [release := item lastPublishedRelease.
>   release
>   ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?')
>   ifTrue: [release := item lastRelease]]]].
>   release
>   ifNotNil: [^ self installPackageRelease: release]]!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: SMLoader-cmm.92.mcz

Hannes Hirzel
+1

SqueakMap package loading should work reliably before the release.

And this caused problems as people no longer seem to know what the
'published' flag is about.

So going for

    release := item lastReleaseForCurrentSystemVersion

seems to be safer. Assuming that is a superset of

   item lastPublishedReleaseForCurrentSystemVersion


Alternatively as there are only about 10 entries in SqueakMap for 5.2
one could ask that all contributers set the 'published' flag.

My guess is that the 'published' flag is for the case that there are
several entries for the same release.


--Hannes










On 10/8/18, David T. Lewis <[hidden email]> wrote:

> This seems like a very good idea to me. I (and apparently one or two other
> hapless contributors) recently found myself confused about this, so if we
> can't remember why the 'published' flag is there, I would be happy to see
> it be ignored.
>
> I also see that I have somehow managed to overlook SMLoader-cmm.89 in the
> inbox for the last two years(!!!). This update seems to resolve the main
> annoyance that I encounter when updating releases on SqueakMap for a new
> release of the Squeak image.
>
> So +1 for both of these from my point of view.
>
> Dave
>
>
> On Sat, Oct 06, 2018 at 08:00:16PM +0000, [hidden email] wrote:
>> Chris Muller uploaded a new version of SMLoader to project The Inbox:
>> http://source.squeak.org/inbox/SMLoader-cmm.92.mcz
>>
>> ==================== Summary ====================
>>
>> Name: SMLoader-cmm.92
>> Author: cmm
>> Time: 6 October 2018, 2:59:45.066275 pm
>> UUID: 7c4c92f1-6332-44d8-bd7c-e3702459df97
>> Ancestors: SMLoader-cmm.91
>>
>> Begin to phase out 'published' flag unless we can remember what the
>> original purpose of this level of detail in the model was for.
>>
>> =============== Diff against SMLoader-cmm.91 ===============
>>
>> Item was changed:
>>   ----- Method: SMLoader>>installPackageRelease (in category 'actions')
>> -----
>>   installPackageRelease
>>   "Install selected package or release.
>>   The cache is used."
>>   | item release |
>>   item := self selectedPackageOrRelease
>>   ifNil: [^ nil].
>>   item isPackageRelease
>>   ifTrue: [^ self installPackageRelease: item]
>> + ifFalse: [release := item lastReleaseForCurrentSystemVersion.
>> - ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
>>   release
>>   ifNil: [(self confirm: 'The package has no published release for
>> your Squeak version, try releases for any Squeak version?')
>>   ifTrue: [release := item lastPublishedRelease.
>>   release
>>   ifNil: [(self confirm: 'The package has no published release at
>> all, take the latest of the unpublished releases?')
>>   ifTrue: [release := item lastRelease]]]].
>>   release
>>   ifNotNil: [^ self installPackageRelease: release]]!
>>
>> Item was changed:
>>   ----- Method: SMLoaderPlus>>installPackageRelease (in category
>> 'actions') -----
>>   installPackageRelease
>>   "Install selected package or release.
>>   The cache is used."
>>   | item release |
>>   item := self selectedPackageOrRelease
>>   ifNil: [^ nil].
>>   item isPackageRelease
>>   ifTrue: [^ self installPackageRelease: item]
>> + ifFalse: [release := item lastReleaseForCurrentSystemVersion.
>> - ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion.
>>   release
>>   ifNil: [(self confirm: 'The package has no published release for
>> your Squeak version, try releases for any Squeak version?')
>>   ifTrue: [release := item lastPublishedRelease.
>>   release
>>   ifNil: [(self confirm: 'The package has no published release at
>> all, take the latest of the unpublished releases?')
>>   ifTrue: [release := item lastRelease]]]].
>>   release
>>   ifNotNil: [^ self installPackageRelease: release]]!
>>
>>
>
>