The Inbox: Tools-ct.958.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tools-ct.958.mcz

commits-2
Christoph Thiede uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.958.mcz

==================== Summary ====================

Name: Tools-ct.958
Author: ct
Time: 16 March 2020, 8:47:01.435937 pm
UUID: 7c9173ab-a806-734d-8b7f-fcf1fe6ad124
Ancestors: Tools-mt.955

Proposal: Implement #browse on BlockClosure and CompiledCode again.

        thisContext sender arguments last browse.
        thisContext sender arguments last method browse.

=============== Diff against Tools-mt.955 ===============

Item was added:
+ ----- Method: BlockClosure>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!

Item was added:
+ ----- Method: CompiledCode>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-ct.958.mcz

marcel.taeumel
There are comments missing. What if the method is a do-it? Please add comments.

Best,
Marcel

Am 16.03.2020 20:47:16 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.958.mcz

==================== Summary ====================

Name: Tools-ct.958
Author: ct
Time: 16 March 2020, 8:47:01.435937 pm
UUID: 7c9173ab-a806-734d-8b7f-fcf1fe6ad124
Ancestors: Tools-mt.955

Proposal: Implement #browse on BlockClosure and CompiledCode again.

thisContext sender arguments last browse.
thisContext sender arguments last method browse.

=============== Diff against Tools-mt.955 ===============

Item was added:
+ ----- Method: BlockClosure>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!

Item was added:
+ ----- Method: CompiledCode>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!




Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-ct.958.mcz

Christoph Thiede

Hi Marcel,


if the block is part of a do-it method, it is not installed so you will be informed that "no version are installed". We could also open a System Browser on BlockClosure in this case, but that would be inconsistent ...


A method comment could be:

"Opens a System Browser on the method that contains the receiver."

Do you think this comment adds value? :-)


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 23. März 2020 11:58:29
An: gettimothy via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Tools-ct.958.mcz
 
There are comments missing. What if the method is a do-it? Please add comments.

Best,
Marcel

Am 16.03.2020 20:47:16 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.958.mcz

==================== Summary ====================

Name: Tools-ct.958
Author: ct
Time: 16 March 2020, 8:47:01.435937 pm
UUID: 7c9173ab-a806-734d-8b7f-fcf1fe6ad124
Ancestors: Tools-mt.955

Proposal: Implement #browse on BlockClosure and CompiledCode again.

thisContext sender arguments last browse.
thisContext sender arguments last method browse.

=============== Diff against Tools-mt.955 ===============

Item was added:
+ ----- Method: BlockClosure>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!

Item was added:
+ ----- Method: CompiledCode>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!




Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-ct.958.mcz

marcel.taeumel
Do you think this comment adds value? :-)

Explain the expected usage, circumstances, and possible errors to inform the person that stumbles upon this method. If you omit to motivate, people might not use it correctly. Also, discovery can be supported with a comment. Think of full-text search in the image.

I am writing this in a more general sense because you are proposing quite many convenience methods lately. :-)

Best,
Marcel

Am 23.03.2020 14:50:25 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,


if the block is part of a do-it method, it is not installed so you will be informed that "no version are installed". We could also open a System Browser on BlockClosure in this case, but that would be inconsistent ...


A method comment could be:

"Opens a System Browser on the method that contains the receiver."

Do you think this comment adds value? :-)


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 23. März 2020 11:58:29
An: gettimothy via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Tools-ct.958.mcz
 
There are comments missing. What if the method is a do-it? Please add comments.

Best,
Marcel

Am 16.03.2020 20:47:16 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.958.mcz

==================== Summary ====================

Name: Tools-ct.958
Author: ct
Time: 16 March 2020, 8:47:01.435937 pm
UUID: 7c9173ab-a806-734d-8b7f-fcf1fe6ad124
Ancestors: Tools-mt.955

Proposal: Implement #browse on BlockClosure and CompiledCode again.

thisContext sender arguments last browse.
thisContext sender arguments last method browse.

=============== Diff against Tools-mt.955 ===============

Item was added:
+ ----- Method: BlockClosure>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!

Item was added:
+ ----- Method: CompiledCode>>browse (in category '*Tools-Browser') -----
+ browse
+
+ ^ self method browse!