The Inbox: Tools-ct.980.mcz

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

The Inbox: Tools-ct.980.mcz

A new version of Tools was added to project The Inbox:

==================== Summary ====================

Name: Tools-ct.980
Author: ct
Time: 27 June 2020, 9:46:13.766705 pm
UUID: ad6a8c37-fddf-fa4f-96ca-6b3c64d4b594
Ancestors: Tools-mt.979

Fixes opening a TextLink pointing to a class from within a MessageSet. In addition, only select the new item for a consistent experience.

Steps to reproduce the original bug:
1. Insert a TextLink pointing to a class comment into any method comment and save the method with style.
2. Browse the method in a message trace.
3. Click the link.
Before this fix, the message trace raised a draw error because an internal conversion step was forgotten. See also Model >> #addItem: which already respected that conversion.

=============== Diff against Tools-mt.979 ===============

Item was changed:
  ----- Method: MessageSet>>addItem: (in category 'message list') -----
  addItem: classAndMethod
  "Append a classAndMethod string to the list.  Select the new item."
+ "Do some checks on the input"
+ classAndMethod isMethodReference ifFalse: [
+ ^ self class parse: classAndMethod toClassAndSelector: [:class :sel |
+ class ifNotNil: [
+ self addItem: (MethodReference class: class selector: sel)]]].
- "Do some checks on the input?"
  self okToChange ifFalse: [^ self].
+ self deselectAll.
+ self basicAddItem: classAndMethod.
- messageList add: classAndMethod.
  self changed: #messageList.
  self messageListIndex: messageList size.!

Item was added:
+ ----- Method: MessageSet>>basicAddItem: (in category 'private') -----
+ basicAddItem: classAndMethod
+ messageList add: classAndMethod.!

Item was added:
+ ----- Method: MessageTrace>>basicAddItem: (in category 'message list') -----
+ basicAddItem: classAndMethod
+ super basicAddItem: classAndMethod.
+ autoSelectStrings add: nil.
+ messageSelections add: true.!