The Inbox: Tools-jr.809.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tools-jr.809.mcz

commits-2
A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-jr.809.mcz

==================== Summary ====================

Name: Tools-jr.809
Author: jr
Time: 29 April 2018, 7:26:21.629471 pm
UUID: 95b32bbc-8dd4-bf49-8226-b727ef91e4de
Ancestors: Tools-cmm.808

Fix small glitch in MessageSet initialization

=============== Diff against Tools-cmm.808 ===============

Item was changed:
  ----- Method: MessageSet>>initializeMessageList: (in category 'private') -----
  initializeMessageList: anArray
  "Initialize my messageList from the given list of MethodReference or string objects.  NB: special handling for uniclasses.
  Do /not/ replace the elements of anArray if they are already MethodReferences, so as to allow users to construct richer systems, such as differencers between existing and edited versions of code."
  messageList := OrderedCollection new.
  anArray do: [:each |
  each isMethodReference
  ifTrue: [messageList addLast: each]
  ifFalse: [MessageSet parse: each toClassAndSelector: [ :class :sel |
  class ifNotNil: [
  messageList addLast: (
+ MethodReference
- MethodReference new
  class: class  
  selector: sel)] ]]].
  "Unify labels if wanted."
  self class useUnifiedMessageLabels ifTrue: [
  messageList do: [:each | | cls |
  cls := each actualClass.
  each stringVersion:
  (cls
  ifNil: [each asString]
  ifNotNil:
  [cls isUniClass
  ifTrue: [cls typicalInstanceName, ' ', each selector]
  ifFalse: [cls name , ' ' , each selector , ' {' ,
  ((cls organization categoryOfElement: each selector) ifNil: ['']) , '}' ,
  ' {', cls category, '}']])]].
  messageListIndex := messageList isEmpty ifTrue: [0] ifFalse: [1].
  contents := ''!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-jr.809.mcz

Chris Muller-3
That's a Constructor Method, not a glitch.   :)

On Sun, Apr 29, 2018 at 12:26 PM,  <[hidden email]> wrote:

> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-jr.809.mcz
>
> ==================== Summary ====================
>
> Name: Tools-jr.809
> Author: jr
> Time: 29 April 2018, 7:26:21.629471 pm
> UUID: 95b32bbc-8dd4-bf49-8226-b727ef91e4de
> Ancestors: Tools-cmm.808
>
> Fix small glitch in MessageSet initialization
>
> =============== Diff against Tools-cmm.808 ===============
>
> Item was changed:
>   ----- Method: MessageSet>>initializeMessageList: (in category 'private') -----
>   initializeMessageList: anArray
>         "Initialize my messageList from the given list of MethodReference or string objects.  NB: special handling for uniclasses.
>          Do /not/ replace the elements of anArray if they are already MethodReferences, so as to allow users to construct richer systems, such as differencers between existing and edited versions of code."
>         messageList := OrderedCollection new.
>         anArray do: [:each |
>                  each isMethodReference
>                         ifTrue: [messageList addLast: each]
>                         ifFalse: [MessageSet parse: each toClassAndSelector: [ :class :sel |
>                                 class ifNotNil: [
>                                         messageList addLast: (
> +                                               MethodReference
> -                                               MethodReference new
>                                                         class: class
>                                                         selector: sel)] ]]].
>         "Unify labels if wanted."
>         self class useUnifiedMessageLabels ifTrue: [
>                 messageList do: [:each | | cls |
>                         cls := each actualClass.
>                         each stringVersion:
>                                 (cls
>                                         ifNil: [each asString]
>                                         ifNotNil:
>                                                 [cls isUniClass
>                                                         ifTrue: [cls typicalInstanceName, ' ', each selector]
>                                                         ifFalse: [cls name , ' ' , each selector , ' {' ,
>                                                                                                         ((cls organization categoryOfElement: each selector) ifNil: ['']) , '}' ,
>                                                                                                         ' {', cls category, '}']])]].
>         messageListIndex := messageList isEmpty ifTrue: [0] ifFalse: [1].
>         contents := ''!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-jr.809.mcz

Jakob Reschke
Yeah, I know. I meant this "new" probably belongs into the same category as a typo. ;-) The constructor method exists only on the class side of MethodReference in my image.

Chris Muller <[hidden email]> schrieb am Mo., 30. Apr. 2018, 01:52:
That's a Constructor Method, not a glitch.   :)

On Sun, Apr 29, 2018 at 12:26 PM,  <[hidden email]> wrote:
> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-jr.809.mcz
>
> ==================== Summary ====================
>
> Name: Tools-jr.809
> Author: jr
> Time: 29 April 2018, 7:26:21.629471 pm
> UUID: 95b32bbc-8dd4-bf49-8226-b727ef91e4de
> Ancestors: Tools-cmm.808
>
> Fix small glitch in MessageSet initialization
>
> =============== Diff against Tools-cmm.808 ===============
>
> Item was changed:
>   ----- Method: MessageSet>>initializeMessageList: (in category 'private') -----
>   initializeMessageList: anArray
>         "Initialize my messageList from the given list of MethodReference or string objects.  NB: special handling for uniclasses.
>          Do /not/ replace the elements of anArray if they are already MethodReferences, so as to allow users to construct richer systems, such as differencers between existing and edited versions of code."
>         messageList := OrderedCollection new.
>         anArray do: [:each |
>                  each isMethodReference
>                         ifTrue: [messageList addLast: each]
>                         ifFalse: [MessageSet parse: each toClassAndSelector: [ :class :sel |
>                                 class ifNotNil: [
>                                         messageList addLast: (
> +                                               MethodReference
> -                                               MethodReference new
>                                                         class: class
>                                                         selector: sel)] ]]].
>         "Unify labels if wanted."
>         self class useUnifiedMessageLabels ifTrue: [
>                 messageList do: [:each | | cls |
>                         cls := each actualClass.
>                         each stringVersion:
>                                 (cls
>                                         ifNil: [each asString]
>                                         ifNotNil:
>                                                 [cls isUniClass
>                                                         ifTrue: [cls typicalInstanceName, ' ', each selector]
>                                                         ifFalse: [cls name , ' ' , each selector , ' {' ,
>                                                                                                         ((cls organization categoryOfElement: each selector) ifNil: ['']) , '}' ,
>                                                                                                         ' {', cls category, '}']])]].
>         messageListIndex := messageList isEmpty ifTrue: [0] ifFalse: [1].
>         contents := ''!
>
>



Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-jr.809.mcz

Chris Muller-4
Woops, I beg your pardon!  I misread the + and - lines and mistakenly thought you inserted the "new" when, in fact, you removed it.  


On Mon, Apr 30, 2018 at 12:22 AM, Jakob Reschke <[hidden email]> wrote:
Yeah, I know. I meant this "new" probably belongs into the same category as a typo. ;-) The constructor method exists only on the class side of MethodReference in my image.

Chris Muller <[hidden email]> schrieb am Mo., 30. Apr. 2018, 01:52:
That's a Constructor Method, not a glitch.   :)

On Sun, Apr 29, 2018 at 12:26 PM,  <[hidden email]> wrote:
> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-jr.809.mcz
>
> ==================== Summary ====================
>
> Name: Tools-jr.809
> Author: jr
> Time: 29 April 2018, 7:26:21.629471 pm
> UUID: 95b32bbc-8dd4-bf49-8226-b727ef91e4de
> Ancestors: Tools-cmm.808
>
> Fix small glitch in MessageSet initialization
>
> =============== Diff against Tools-cmm.808 ===============
>
> Item was changed:
>   ----- Method: MessageSet>>initializeMessageList: (in category 'private') -----
>   initializeMessageList: anArray
>         "Initialize my messageList from the given list of MethodReference or string objects.  NB: special handling for uniclasses.
>          Do /not/ replace the elements of anArray if they are already MethodReferences, so as to allow users to construct richer systems, such as differencers between existing and edited versions of code."
>         messageList := OrderedCollection new.
>         anArray do: [:each |
>                  each isMethodReference
>                         ifTrue: [messageList addLast: each]
>                         ifFalse: [MessageSet parse: each toClassAndSelector: [ :class :sel |
>                                 class ifNotNil: [
>                                         messageList addLast: (
> +                                               MethodReference
> -                                               MethodReference new
>                                                         class: class
>                                                         selector: sel)] ]]].
>         "Unify labels if wanted."
>         self class useUnifiedMessageLabels ifTrue: [
>                 messageList do: [:each | | cls |
>                         cls := each actualClass.
>                         each stringVersion:
>                                 (cls
>                                         ifNil: [each asString]
>                                         ifNotNil:
>                                                 [cls isUniClass
>                                                         ifTrue: [cls typicalInstanceName, ' ', each selector]
>                                                         ifFalse: [cls name , ' ' , each selector , ' {' ,
>                                                                                                         ((cls organization categoryOfElement: each selector) ifNil: ['']) , '}' ,
>                                                                                                         ' {', cls category, '}']])]].
>         messageListIndex := messageList isEmpty ifTrue: [0] ifFalse: [1].
>         contents := ''!
>
>