The Inbox: ToolsTests-fbs.43.mcz
Locked
 
|
A new version of ToolsTests was added to project The Inbox:
http://source.squeak.org/inbox/ToolsTests-fbs.43.mcz ==================== Summary ==================== Name: ToolsTests-fbs.43 Author: fbs Time: 12 May 2011, 4:18:47.449 pm UUID: e4d6c83a-d6f2-ed40-9791-a702dfb06fb9 Ancestors: ToolsTests-fbs.42 Test for Tools-laza.354, and a bonus test just for kicks. =============== Diff against ToolsTests-fbs.42 =============== Item was added: + ----- Method: DependencyBrowserTest>>testSelectedMessageClassSideShowsSource (in category 'testing - message list') ----- + testSelectedMessageClassSideShowsSource + "Warning!! When Collections' dependencies change, this test may start to fail!!" + + browser packageListIndex: (browser packageList indexOf: #'311Deprecated'). + browser packageDepsIndex: (browser packageDeps indexOf: #Kernel). + browser classDepsIndex: (browser classDeps indexOf: #'Number class'). + browser classListIndex: (browser classList indexOf: #'Number class'). + browser messageListIndex: 1. + self assert: browser selectedMessageName == #readExactlyFrom:. + + self assert: browser contents = (Number class sourceCodeAt: #readExactlyFrom:)! Item was added: + ----- Method: DependencyBrowserTest>>testSelectedMessageNameClassSide (in category 'testing - message list') ----- + testSelectedMessageNameClassSide + "Warning!! When Collections' dependencies change, this test may start to fail!!" + self assert: browser selectedMessageName isNil. + + browser packageListIndex: (browser packageList indexOf: #'311Deprecated'). + self assert: browser selectedMessageName isNil. + + browser packageDepsIndex: (browser packageDeps indexOf: #Kernel). + self assert: browser selectedMessageName isNil. + + browser classDepsIndex: (browser classDeps indexOf: #'Number class'). + self assert: browser selectedMessageName isNil. + + browser classListIndex: (browser classList indexOf: #'Number class'). + self assert: browser selectedMessageName isNil. + + browser messageListIndex: 1. + self assert: browser selectedMessageName == #readExactlyFrom:.! |
|
Ah, that's great! Thanks!
Alex 2011/5/12 <[hidden email]> A new version of ToolsTests was added to project The Inbox: |
Re: The Inbox: ToolsTests-fbs.43.mcz
|
|
In reply to this post by commits-2
On Thu, 12 May 2011, [hidden email] wrote:
> A new version of ToolsTests was added to project The Inbox: > http://source.squeak.org/inbox/ToolsTests-fbs.43.mcz > > ==================== Summary ==================== > > Name: ToolsTests-fbs.43 > Author: fbs > Time: 12 May 2011, 4:18:47.449 pm > UUID: e4d6c83a-d6f2-ed40-9791-a702dfb06fb9 > Ancestors: ToolsTests-fbs.42 > > Test for Tools-laza.354, and a bonus test just for kicks. > > =============== Diff against ToolsTests-fbs.42 =============== > > Item was added: > + ----- Method: DependencyBrowserTest>>testSelectedMessageClassSideShowsSource (in category 'testing - message list') ----- > + testSelectedMessageClassSideShowsSource > + "Warning!! When Collections' dependencies change, this test may start to fail!!" > + > + browser packageListIndex: (browser packageList indexOf: #'311Deprecated'). A package that's more likely to be in the image in the future would be a better candidate IMHO. Predicting the future is not easy, but it's pretty likely that 311Deprecated will be removed soon. Levente snip |
|
|
On Fri, May 13, 2011 at 2:51 PM, Levente Uzonyi <[hidden email]> wrote:
> A package that's more likely to be in the image in the future would be a > better candidate IMHO. Predicting the future is not easy, but it's pretty > likely that 311Deprecated will be removed soon. So, when will that be removed? 3 releases seems adequate preparation to me... -Chris |
Re: The Inbox: ToolsTests-fbs.43.mcz
|
|
On Fri, 13 May 2011, Chris Cunningham wrote:
> On Fri, May 13, 2011 at 2:51 PM, Levente Uzonyi <[hidden email]> wrote: >> A package that's more likely to be in the image in the future would be a >> better candidate IMHO. Predicting the future is not easy, but it's pretty >> likely that 311Deprecated will be removed soon. > > So, when will that be removed? 3 releases seems adequate preparation to me... > -Chris As soon as someone reviews that package, decides what should be really removed and what should be kept, then does the removal. Levente > > |
Re: The Inbox: ToolsTests-fbs.43.mcz
|
|
In reply to this post by Levente Uzonyi-2
On 2011/05/13 22:51, Levente Uzonyi wrote:
> On Thu, 12 May 2011, [hidden email] wrote: > >> A new version of ToolsTests was added to project The Inbox: >> http://source.squeak.org/inbox/ToolsTests-fbs.43.mcz >> >> ==================== Summary ==================== >> >> Name: ToolsTests-fbs.43 >> Author: fbs >> Time: 12 May 2011, 4:18:47.449 pm >> UUID: e4d6c83a-d6f2-ed40-9791-a702dfb06fb9 >> Ancestors: ToolsTests-fbs.42 >> >> Test for Tools-laza.354, and a bonus test just for kicks. >> >> =============== Diff against ToolsTests-fbs.42 =============== >> >> Item was added: >> + ----- Method: >> DependencyBrowserTest>>testSelectedMessageClassSideShowsSource (in >> category 'testing - message list') ----- >> + testSelectedMessageClassSideShowsSource >> + "Warning!! When Collections' dependencies change, this test may >> start to fail!!" >> + >> + browser packageListIndex: (browser packageList indexOf: >> #'311Deprecated'). > > A package that's more likely to be in the image in the future would be a > better candidate IMHO. Predicting the future is not easy, but it's > pretty likely that 311Deprecated will be removed soon. For sure. However, it's a test that I could write in five minutes demonstrating that the bugfix works :) When 311Deprecated disappears, the test will break, and we can find a new victim for the test. But sure, I'll go resubmit with a better (non-deprecated) test. frank |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |