The Trunk: 39Deprecated-fbs.20.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: 39Deprecated-fbs.20.mcz

commits-2
David T. Lewis uploaded a new version of 39Deprecated to project The Trunk:
http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz

==================== Summary ====================

Name: 39Deprecated-fbs.20
Author: fbs
Time: 25 July 2012, 9:42:16.56 pm
UUID: b22c5338-3200-4545-89bc-3f75c07e39af
Ancestors: 39Deprecated-ar.19

These methods are deprecated, and I can find no uses in the base image.

=============== Diff against 39Deprecated-ar.19 ===============

Item was removed:
- ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
- flush
- self deprecated: 'use removeAll'.
- ^self removeAll!

Item was removed:
- ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
- flushAllSuchThat: aBlock
- self deprecated: 'use removeAllSuchThat:'.
-
- ^self removeAllSuchThat: aBlock!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

David T. Lewis
Moved from inbox to trunk. These two methods have been deprecated for five years,
so we can let them go now.

Dave

On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of 39Deprecated to project The Trunk:
> http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
>
> ==================== Summary ====================
>
> Name: 39Deprecated-fbs.20
> Author: fbs
> Time: 25 July 2012, 9:42:16.56 pm
> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
> Ancestors: 39Deprecated-ar.19
>
> These methods are deprecated, and I can find no uses in the base image.
>
> =============== Diff against 39Deprecated-ar.19 ===============
>
> Item was removed:
> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
> - flush
> - self deprecated: 'use removeAll'.
> - ^self removeAll!
>
> Item was removed:
> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
> - flushAllSuchThat: aBlock
> - self deprecated: 'use removeAllSuchThat:'.
> -
> - ^self removeAllSuchThat: aBlock!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

marcel.taeumel
Hi Dave,

why would we ever want to remove things from the "deprecated"-packages? Wouldn't be the only thing to do to not load that respective package at all?

We could start unloading some older "deprecated"-packages for the next release. If we are unsure about certain methods, we can always move them from an older "deprecated"-package to a newer, loaded "deprecated" package. :)

Best,
Marcel

Am 20.09.2017 15:23:53 schrieb David T. Lewis <[hidden email]>:

Moved from inbox to trunk. These two methods have been deprecated for five years,
so we can let them go now.

Dave

On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of 39Deprecated to project The Trunk:
> http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
>
> ==================== Summary ====================
>
> Name: 39Deprecated-fbs.20
> Author: fbs
> Time: 25 July 2012, 9:42:16.56 pm
> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
> Ancestors: 39Deprecated-ar.19
>
> These methods are deprecated, and I can find no uses in the base image.
>
> =============== Diff against 39Deprecated-ar.19 ===============
>
> Item was removed:
> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
> - flush
> - self deprecated: 'use removeAll'.
> - ^self removeAll!
>
> Item was removed:
> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
> - flushAllSuchThat: aBlock
> - self deprecated: 'use removeAllSuchThat:'.
> -
> - ^self removeAllSuchThat: aBlock!
>
>



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

Hannes Hirzel
On 9/20/17, Marcel Taeumel <[hidden email]> wrote:
> Hi Dave,
>
> why would we ever want to remove things from the
> "deprecated"-packages? Wouldn't be the only thing to do to not load that
> respective package at all?

+1


>
> We could start unloading some older "deprecated"-packages for the next
> release. If we are unsure about certain methods, we can always move them
> from an older "deprecated"-package to a newer, loaded "deprecated" package.
> :)

+1

> Best,
> Marcel
> Am 20.09.2017 15:23:53 schrieb David T. Lewis <[hidden email]>:
> Moved from inbox to trunk. These two methods have been deprecated for five
> years,
> so we can let them go now.
>
> Dave
>
> On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:
>> David T. Lewis uploaded a new version of 39Deprecated to project The
>> Trunk:
>> http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
>>
>> ==================== Summary ====================
>>
>> Name: 39Deprecated-fbs.20
>> Author: fbs
>> Time: 25 July 2012, 9:42:16.56 pm
>> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
>> Ancestors: 39Deprecated-ar.19
>>
>> These methods are deprecated, and I can find no uses in the base image.
>>
>> =============== Diff against 39Deprecated-ar.19 ===============
>>
>> Item was removed:
>> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
>> - flush
>> - self deprecated: 'use removeAll'.
>> - ^self removeAll!
>>
>> Item was removed:
>> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category
>> '*39Deprecated') -----
>> - flushAllSuchThat: aBlock
>> - self deprecated: 'use removeAllSuchThat:'.
>> -
>> - ^self removeAllSuchThat: aBlock!
>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

David T. Lewis
In reply to this post by marcel.taeumel
You are right.

Actually, I was just picking a random package out of the inbox to clean
up, and that was the first one one I picked. I figured that after five
years it was probably time it was time to get it out of the inbox ;-)

I should have just moved that one to the treated inbox instead. I will revert.

Dave

On Wed, Sep 20, 2017 at 04:40:26PM +0200, Marcel Taeumel wrote:

> Hi Dave,
>
> why would we ever want to remove things from the "deprecated"-packages???Wouldn't be the only thing to do to not load that respective package at all?
>
> We could start unloading some older "deprecated"-packages for the next release. If we are unsure about certain methods, we can always move them from an older "deprecated"-package to a newer, loaded "deprecated" package. :)
>
> Best,
> Marcel
> Am 20.09.2017 15:23:53 schrieb David T. Lewis <[hidden email]>:
> Moved from inbox to trunk. These two methods have been deprecated for five years,
> so we can let them go now.
>
> Dave
>
> On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:
> > David T. Lewis uploaded a new version of 39Deprecated to project The Trunk:
> > http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
> >
> > ==================== Summary ====================
> >
> > Name: 39Deprecated-fbs.20
> > Author: fbs
> > Time: 25 July 2012, 9:42:16.56 pm
> > UUID: b22c5338-3200-4545-89bc-3f75c07e39af
> > Ancestors: 39Deprecated-ar.19
> >
> > These methods are deprecated, and I can find no uses in the base image.
> >
> > =============== Diff against 39Deprecated-ar.19 ===============
> >
> > Item was removed:
> > - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
> > - flush
> > - self deprecated: 'use removeAll'.
> > - ^self removeAll!
> >
> > Item was removed:
> > - ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
> > - flushAllSuchThat: aBlock
> > - self deprecated: 'use removeAllSuchThat:'.
> > -
> > - ^self removeAllSuchThat: aBlock!
> >
> >
>

>


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

Levente Uzonyi
In reply to this post by David T. Lewis
These methods were there to make it possible to migrate from SharedQueue
to SharedQueue2 in a live system.
That migration has not happened yet, so removing them means
SharedQueue2 will not replace SharedQueue.

Levente

On Wed, 20 Sep 2017, David T. Lewis wrote:

> Moved from inbox to trunk. These two methods have been deprecated for five years,
> so we can let them go now.
>
> Dave
>
> On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:
>> David T. Lewis uploaded a new version of 39Deprecated to project The Trunk:
>> http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
>>
>> ==================== Summary ====================
>>
>> Name: 39Deprecated-fbs.20
>> Author: fbs
>> Time: 25 July 2012, 9:42:16.56 pm
>> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
>> Ancestors: 39Deprecated-ar.19
>>
>> These methods are deprecated, and I can find no uses in the base image.
>>
>> =============== Diff against 39Deprecated-ar.19 ===============
>>
>> Item was removed:
>> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
>> - flush
>> - self deprecated: 'use removeAll'.
>> - ^self removeAll!
>>
>> Item was removed:
>> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category '*39Deprecated') -----
>> - flushAllSuchThat: aBlock
>> - self deprecated: 'use removeAllSuchThat:'.
>> -
>> - ^self removeAllSuchThat: aBlock!
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

Hannes Hirzel
On 9/20/17, Levente Uzonyi <[hidden email]> wrote:
> These methods were there to make it possible to migrate from SharedQueue
> to SharedQueue2 in a live system.

Could you please give some more background information about this migration?

> That migration has not happened yet,

Is there a reason not to do it after 5 years?

> so removing them means
> SharedQueue2 will not replace SharedQueue.
>
> Levente
>
> On Wed, 20 Sep 2017, David T. Lewis wrote:
>
>> Moved from inbox to trunk. These two methods have been deprecated for five
>> years,
>> so we can let them go now.
>>
>> Dave
>>
>> On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:
>>> David T. Lewis uploaded a new version of 39Deprecated to project The
>>> Trunk:
>>> http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: 39Deprecated-fbs.20
>>> Author: fbs
>>> Time: 25 July 2012, 9:42:16.56 pm
>>> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
>>> Ancestors: 39Deprecated-ar.19
>>>
>>> These methods are deprecated, and I can find no uses in the base image.
>>>
>>> =============== Diff against 39Deprecated-ar.19 ===============
>>>
>>> Item was removed:
>>> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
>>> - flush
>>> - self deprecated: 'use removeAll'.
>>> - ^self removeAll!
>>>
>>> Item was removed:
>>> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category
>>> '*39Deprecated') -----
>>> - flushAllSuchThat: aBlock
>>> - self deprecated: 'use removeAllSuchThat:'.
>>> -
>>> - ^self removeAllSuchThat: aBlock!
>>>
>>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 39Deprecated-fbs.20.mcz

Levente Uzonyi
On Wed, 20 Sep 2017, H. Hirzel wrote:

> On 9/20/17, Levente Uzonyi <[hidden email]> wrote:
>> These methods were there to make it possible to migrate from SharedQueue
>> to SharedQueue2 in a live system.
>
> Could you please give some more background information about this migration?

http://bugs.squeak.org/view.php?id=1375

>
>> That migration has not happened yet,
>
> Is there a reason not to do it after 5 years?

The mantis issue above has a few potential reasons.
Another one may be that now there are other potential shared
queue implementations to replace SharedQueue.

Levente

>
>> so removing them means
>> SharedQueue2 will not replace SharedQueue.
>>
>> Levente
>>
>> On Wed, 20 Sep 2017, David T. Lewis wrote:
>>
>>> Moved from inbox to trunk. These two methods have been deprecated for five
>>> years,
>>> so we can let them go now.
>>>
>>> Dave
>>>
>>> On Wed, Sep 20, 2017 at 01:21:42PM +0000, [hidden email] wrote:
>>>> David T. Lewis uploaded a new version of 39Deprecated to project The
>>>> Trunk:
>>>> http://source.squeak.org/trunk/39Deprecated-fbs.20.mcz
>>>>
>>>> ==================== Summary ====================
>>>>
>>>> Name: 39Deprecated-fbs.20
>>>> Author: fbs
>>>> Time: 25 July 2012, 9:42:16.56 pm
>>>> UUID: b22c5338-3200-4545-89bc-3f75c07e39af
>>>> Ancestors: 39Deprecated-ar.19
>>>>
>>>> These methods are deprecated, and I can find no uses in the base image.
>>>>
>>>> =============== Diff against 39Deprecated-ar.19 ===============
>>>>
>>>> Item was removed:
>>>> - ----- Method: SharedQueue2>>flush (in category '*39Deprecated') -----
>>>> - flush
>>>> - self deprecated: 'use removeAll'.
>>>> - ^self removeAll!
>>>>
>>>> Item was removed:
>>>> - ----- Method: SharedQueue2>>flushAllSuchThat: (in category
>>>> '*39Deprecated') -----
>>>> - flushAllSuchThat: aBlock
>>>> - self deprecated: 'use removeAllSuchThat:'.
>>>> -
>>>> - ^self removeAllSuchThat: aBlock!
>>>>
>>>>
>>
>>