The Trunk: 60Deprecated-mt.38.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: 60Deprecated-mt.38.mcz

commits-2
Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk:
http://source.squeak.org/trunk/60Deprecated-mt.38.mcz

==================== Summary ====================

Name: 60Deprecated-mt.38
Author: mt
Time: 12 July 2019, 8:39:34.417612 am
UUID: f25adf3c-1f60-5749-aada-72ceed6de84c
Ancestors: 60Deprecated-mt.37

Complements Collections-mt.840.

=============== Diff against 60Deprecated-mt.37 ===============

Item was added:
+ ----- Method: Symbol class>>internCharacter: (in category '*60Deprecated-instance creation') -----
+ internCharacter: aCharacter
+
+ self deprecated: 'Use #intern: instead. There is no special table for one-character symbols anymore'.
+ ^ self intern: aCharacter asString!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 60Deprecated-mt.38.mcz

marcel.taeumel
Hi, there.

as of today, this change causes update troubles. I have no idea why. Has been working fine during the last 5 days. See http://files.squeak.org/5.3alpha/.

Something started (indirectly) sending Symbol class>>internCharacter: during the updates. I am still investigating.

Best,
Marcel

Am 12.07.2019 08:39:37 schrieb [hidden email] <[hidden email]>:

Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk:
http://source.squeak.org/trunk/60Deprecated-mt.38.mcz

==================== Summary ====================

Name: 60Deprecated-mt.38
Author: mt
Time: 12 July 2019, 8:39:34.417612 am
UUID: f25adf3c-1f60-5749-aada-72ceed6de84c
Ancestors: 60Deprecated-mt.37

Complements Collections-mt.840.

=============== Diff against 60Deprecated-mt.37 ===============

Item was added:
+ ----- Method: Symbol class>>internCharacter: (in category '*60Deprecated-instance creation') -----
+ internCharacter: aCharacter
+
+ self deprecated: 'Use #intern: instead. There is no special table for one-character symbols anymore'.
+ ^ self intern: aCharacter asString!




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 60Deprecated-mt.38.mcz

marcel.taeumel
Well, in the update map "update-mt.446.mcm", which I made for the literalsDo-Refactoring step 1 of 3, I mixed up the order of 

60Deprecated-mt.38 (deprecates #internCharacter:)
Collections-mt.841 (actually Collections-mt.840 that stops using #internCharacter:)

So, I corrected that update map. Still not working.

Unfortunately, "mcPreload" treats methods that got moved between packages, including that #internCharacter:. So, that method get's deprecated before all sends can be updated.

Btw: This has happened with all our deprecations in the past. This means that we should create a new update map *before* committing changes to "60Deprecated"... did we do that in the past?

Best,
Marcel

P.S.: There are post-load scripts that enable deprecation warnings again. So, if you cannot update your Trunk image, disable those warnings via preferences or here:

MCMcmUpdater >> #updateFromRepository

   ...
   updateList do: [:assoc |
      Deprecation showDeprecationWarnings: false.
      ...
      Deprecation showDeprecationWarnings: false.
   ] displayingProgress: ...
...

Am 17.07.2019 15:21:53 schrieb Marcel Taeumel <[hidden email]>:

Hi, there.

as of today, this change causes update troubles. I have no idea why. Has been working fine during the last 5 days. See http://files.squeak.org/5.3alpha/.

Something started (indirectly) sending Symbol class>>internCharacter: during the updates. I am still investigating.

Best,
Marcel

Am 12.07.2019 08:39:37 schrieb [hidden email] <[hidden email]>:

Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk:
http://source.squeak.org/trunk/60Deprecated-mt.38.mcz

==================== Summary ====================

Name: 60Deprecated-mt.38
Author: mt
Time: 12 July 2019, 8:39:34.417612 am
UUID: f25adf3c-1f60-5749-aada-72ceed6de84c
Ancestors: 60Deprecated-mt.37

Complements Collections-mt.840.

=============== Diff against 60Deprecated-mt.37 ===============

Item was added:
+ ----- Method: Symbol class>>internCharacter: (in category '*60Deprecated-instance creation') -----
+ internCharacter: aCharacter
+
+ self deprecated: 'Use #intern: instead. There is no special table for one-character symbols anymore'.
+ ^ self intern: aCharacter asString!




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 60Deprecated-mt.38.mcz

marcel.taeumel
Okay from "update-mt.446.mcm", I just removed "60Deprecated-mt.38" to post-pone the update of "60Deprecated"  until "update-mt.447.mcm" and later.

Seems to work as a workaround for "mcPreload". :-)

Best,
Marcel

Am 17.07.2019 16:45:25 schrieb Marcel Taeumel <[hidden email]>:

Well, in the update map "update-mt.446.mcm", which I made for the literalsDo-Refactoring step 1 of 3, I mixed up the order of 

60Deprecated-mt.38 (deprecates #internCharacter:)
Collections-mt.841 (actually Collections-mt.840 that stops using #internCharacter:)

So, I corrected that update map. Still not working.

Unfortunately, "mcPreload" treats methods that got moved between packages, including that #internCharacter:. So, that method get's deprecated before all sends can be updated.

Btw: This has happened with all our deprecations in the past. This means that we should create a new update map *before* committing changes to "60Deprecated"... did we do that in the past?

Best,
Marcel

P.S.: There are post-load scripts that enable deprecation warnings again. So, if you cannot update your Trunk image, disable those warnings via preferences or here:

MCMcmUpdater >> #updateFromRepository

   ...
   updateList do: [:assoc |
      Deprecation showDeprecationWarnings: false.
      ...
      Deprecation showDeprecationWarnings: false.
   ] displayingProgress: ...
...

Am 17.07.2019 15:21:53 schrieb Marcel Taeumel <[hidden email]>:

Hi, there.

as of today, this change causes update troubles. I have no idea why. Has been working fine during the last 5 days. See http://files.squeak.org/5.3alpha/.

Something started (indirectly) sending Symbol class>>internCharacter: during the updates. I am still investigating.

Best,
Marcel

Am 12.07.2019 08:39:37 schrieb [hidden email] <[hidden email]>:

Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk:
http://source.squeak.org/trunk/60Deprecated-mt.38.mcz

==================== Summary ====================

Name: 60Deprecated-mt.38
Author: mt
Time: 12 July 2019, 8:39:34.417612 am
UUID: f25adf3c-1f60-5749-aada-72ceed6de84c
Ancestors: 60Deprecated-mt.37

Complements Collections-mt.840.

=============== Diff against 60Deprecated-mt.37 ===============

Item was added:
+ ----- Method: Symbol class>>internCharacter: (in category '*60Deprecated-instance creation') -----
+ internCharacter: aCharacter
+
+ self deprecated: 'Use #intern: instead. There is no special table for one-character symbols anymore'.
+ ^ self intern: aCharacter asString!