The Trunk: Collections.spur-ul.573.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Collections.spur-ul.573.mcz

commits-2
Eliot Miranda uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections.spur-ul.573.mcz

==================== Summary ====================

Name: Collections.spur-ul.573
Author: eem
Time: 17 July 2014, 2:37:48.485 pm
UUID: e0223be3-5368-4070-9468-66be709d489c
Ancestors: Collections-ul.573

Collections-ul.573 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.168

Character changes
- introduced #encodedCharSet to access the EncodedCharSet of a character
- all methods use #encodedCharSet instead of (EncodedCharSet charSetAt: self leadingChar)
- #isAlphaNumeric uses the EncodedCharSet class's #isAlphaNumeric: method

=============== Diff against Collections-ul.573 ===============

Item was changed:
==== ERROR ===

Error: Unrecognized class type

17 July 2014 9:39:45.17 pm

VM: unix - a SmalltalkImage
Image: Squeak3.11alpha [latest update: #8824]

SecurityManager state:
Restricted: false
FileAccess: true
SocketAccess: true
Working Dir /home/squeaksource
Trusted Dir /home/squeaksource/secure
Untrusted Dir /home/squeaksource/My Squeak

MCClassDefinition(Object)>>error:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                aString: 'Unrecognized class type'
        Receiver's instance variables:
                name: #Character
                superclassName: #Magnitude
                variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category: #'Collections-Strings'
                type: #immediate
                comment: 'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp: 'ar 4/9/2005 22:35'
                traitComposition: nil
                classTraitComposition: nil

MCClassDefinition>>kindOfSubclass
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:

        Receiver's instance variables:
                name: #Character
                superclassName: #Magnitude
                variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category: #'Collections-Strings'
                type: #immediate
                comment: 'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp: 'ar 4/9/2005 22:35'
                traitComposition: nil
                classTraitComposition: nil

MCClassDefinition>>printDefinitionOn:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                stream: a WriteStream
        Receiver's instance variables:
                name: #Character
                superclassName: #Magnitude
                variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category: #'Collections-Strings'
                type: #immediate
                comment: 'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp: 'ar 4/9/2005 22:35'
                traitComposition: nil
                classTraitComposition: nil

[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
        Receiver: a MCDiffyTextWriter
        Arguments and temporary variables:
                definition: a WriteStream
                s: a MCClassDefinition(Character)
        Receiver's instance variables:
                stream: a WriteStream
                initStream: nil


--- The full stack ---
MCClassDefinition(Object)>>error:
MCClassDefinition>>kindOfSubclass
MCClassDefinition>>printDefinitionOn:
[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>chunkContents:
MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
MCDiffyTextWriter(MCStWriter)>>visitClassDefinition:
MCClassDefinition>>accept:
[] in MCDiffyTextWriter(MCTextWriter)>>visitInFork:
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>visitInFork:
MCDiffyTextWriter>>writePatchFrom:to:
MCDiffyTextWriter>>writeModification:
[] in MCDiffyTextWriter>>writePatch:
SortedCollection(OrderedCollection)>>do:
MCDiffyTextWriter>>writePatch:
SSDiffyTextWriter>>writePatch:
[] in SSDiffyTextWriter>>writeVersion:for:
BlockClosure>>on:do:
SSDiffyTextWriter>>writeVersion:for:
[] in SSEMailSubscription>>versionAdded:to:
BlockClosure>>on:do:
SSEMailSubscription>>versionAdded:to:
[] in [] in SSProject>>versionAdded:
[] in BlockClosure>>newProcess

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Collections.spur-ul.573.mcz

Karl Ramberg
It seems there are problems with this commit.

Karl


On Thu, Jul 17, 2014 at 11:39 PM, <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections.spur-ul.573.mcz

==================== Summary ====================

Name: Collections.spur-ul.573
Author: eem
Time: 17 July 2014, 2:37:48.485 pm
UUID: e0223be3-5368-4070-9468-66be709d489c
Ancestors: Collections-ul.573

Collections-ul.573 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.168

Character changes
- introduced #encodedCharSet to access the EncodedCharSet of a character
- all methods use #encodedCharSet instead of (EncodedCharSet charSetAt: self leadingChar)
- #isAlphaNumeric uses the EncodedCharSet class's #isAlphaNumeric: method

=============== Diff against Collections-ul.573 ===============

Item was changed:
==== ERROR ===

Error: Unrecognized class type

17 July 2014 9:39:45.17 pm

VM: unix - a SmalltalkImage
Image: Squeak3.11alpha [latest update: #8824]

SecurityManager state:
Restricted: false
FileAccess: true
SocketAccess: true
Working Dir /home/squeaksource
Trusted Dir /home/squeaksource/secure
Untrusted Dir /home/squeaksource/My Squeak

MCClassDefinition(Object)>>error:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                aString:        'Unrecognized class type'
        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

MCClassDefinition>>kindOfSubclass
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:

        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

MCClassDefinition>>printDefinitionOn:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                stream:         a WriteStream
        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
        Receiver: a MCDiffyTextWriter
        Arguments and temporary variables:
                definition:     a WriteStream
                s:      a MCClassDefinition(Character)
        Receiver's instance variables:
                stream:         a WriteStream
                initStream:     nil


--- The full stack ---
MCClassDefinition(Object)>>error:
MCClassDefinition>>kindOfSubclass
MCClassDefinition>>printDefinitionOn:
[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>chunkContents:
MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
MCDiffyTextWriter(MCStWriter)>>visitClassDefinition:
MCClassDefinition>>accept:
[] in MCDiffyTextWriter(MCTextWriter)>>visitInFork:
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>visitInFork:
MCDiffyTextWriter>>writePatchFrom:to:
MCDiffyTextWriter>>writeModification:
[] in MCDiffyTextWriter>>writePatch:
SortedCollection(OrderedCollection)>>do:
MCDiffyTextWriter>>writePatch:
SSDiffyTextWriter>>writePatch:
[] in SSDiffyTextWriter>>writeVersion:for:
BlockClosure>>on:do:
SSDiffyTextWriter>>writeVersion:for:
[] in SSEMailSubscription>>versionAdded:to:
BlockClosure>>on:do:
SSEMailSubscription>>versionAdded:to:
[] in [] in SSProject>>versionAdded:
[] in BlockClosure>>newProcess




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Collections.spur-ul.573.mcz

Eliot Miranda-2
In reply to this post by commits-2
Hi Karl,

    worry not.  It is simply that the image that does the differencing hasn't been updated and so barfs on Spur's Character class definition:

Magnitude immediateSubclass: #Character
instanceVariableNames: ''
classVariableNames: 'CharacterTable ClassificationTable DigitValues LetterBits LowercaseBit UppercaseBit'
poolDictionaries: ''
category: 'Collections-Strings'

immediateSubclass: is new with Spur, support for which is in trunk.  Now that there are two immediate subclasses and we're likely to have a third in the 64-bit system some time next year (SmallFloat) it seemed to me better to introduce the selector and avoid using the old hack which presents SmallInteger as if it is a normal class and needs hidden chicanery in the ClassBuilder to allow it to be redefined.


On Thu, Jul 17, 2014 at 2:39 PM, <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections.spur-ul.573.mcz

==================== Summary ====================

Name: Collections.spur-ul.573
Author: eem
Time: 17 July 2014, 2:37:48.485 pm
UUID: e0223be3-5368-4070-9468-66be709d489c
Ancestors: Collections-ul.573

Collections-ul.573 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.168

Character changes
- introduced #encodedCharSet to access the EncodedCharSet of a character
- all methods use #encodedCharSet instead of (EncodedCharSet charSetAt: self leadingChar)
- #isAlphaNumeric uses the EncodedCharSet class's #isAlphaNumeric: method

=============== Diff against Collections-ul.573 ===============

Item was changed:
==== ERROR ===

Error: Unrecognized class type

17 July 2014 9:39:45.17 pm

VM: unix - a SmalltalkImage
Image: Squeak3.11alpha [latest update: #8824]

SecurityManager state:
Restricted: false
FileAccess: true
SocketAccess: true
Working Dir /home/squeaksource
Trusted Dir /home/squeaksource/secure
Untrusted Dir /home/squeaksource/My Squeak

MCClassDefinition(Object)>>error:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                aString:        'Unrecognized class type'
        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

MCClassDefinition>>kindOfSubclass
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:

        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

MCClassDefinition>>printDefinitionOn:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                stream:         a WriteStream
        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
        Receiver: a MCDiffyTextWriter
        Arguments and temporary variables:
                definition:     a WriteStream
                s:      a MCClassDefinition(Character)
        Receiver's instance variables:
                stream:         a WriteStream
                initStream:     nil


--- The full stack ---
MCClassDefinition(Object)>>error:
MCClassDefinition>>kindOfSubclass
MCClassDefinition>>printDefinitionOn:
[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>chunkContents:
MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
MCDiffyTextWriter(MCStWriter)>>visitClassDefinition:
MCClassDefinition>>accept:
[] in MCDiffyTextWriter(MCTextWriter)>>visitInFork:
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>visitInFork:
MCDiffyTextWriter>>writePatchFrom:to:
MCDiffyTextWriter>>writeModification:
[] in MCDiffyTextWriter>>writePatch:
SortedCollection(OrderedCollection)>>do:
MCDiffyTextWriter>>writePatch:
SSDiffyTextWriter>>writePatch:
[] in SSDiffyTextWriter>>writeVersion:for:
BlockClosure>>on:do:
SSDiffyTextWriter>>writeVersion:for:
[] in SSEMailSubscription>>versionAdded:to:
BlockClosure>>on:do:
SSEMailSubscription>>versionAdded:to:
[] in [] in SSProject>>versionAdded:
[] in BlockClosure>>newProcess




--
best,
Eliot


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Collections.spur-ul.573.mcz

Karl Ramberg
Ok

Karl


On Fri, Jul 18, 2014 at 8:04 PM, Eliot Miranda <[hidden email]> wrote:
Hi Karl,

    worry not.  It is simply that the image that does the differencing hasn't been updated and so barfs on Spur's Character class definition:

Magnitude immediateSubclass: #Character
instanceVariableNames: ''
classVariableNames: 'CharacterTable ClassificationTable DigitValues LetterBits LowercaseBit UppercaseBit'
poolDictionaries: ''
category: 'Collections-Strings'

immediateSubclass: is new with Spur, support for which is in trunk.  Now that there are two immediate subclasses and we're likely to have a third in the 64-bit system some time next year (SmallFloat) it seemed to me better to introduce the selector and avoid using the old hack which presents SmallInteger as if it is a normal class and needs hidden chicanery in the ClassBuilder to allow it to be redefined.


On Thu, Jul 17, 2014 at 2:39 PM, <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections.spur-ul.573.mcz

==================== Summary ====================

Name: Collections.spur-ul.573
Author: eem
Time: 17 July 2014, 2:37:48.485 pm
UUID: e0223be3-5368-4070-9468-66be709d489c
Ancestors: Collections-ul.573

Collections-ul.573 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.168

Character changes
- introduced #encodedCharSet to access the EncodedCharSet of a character
- all methods use #encodedCharSet instead of (EncodedCharSet charSetAt: self leadingChar)
- #isAlphaNumeric uses the EncodedCharSet class's #isAlphaNumeric: method

=============== Diff against Collections-ul.573 ===============

Item was changed:
==== ERROR ===

Error: Unrecognized class type

17 July 2014 9:39:45.17 pm

VM: unix - a SmalltalkImage
Image: Squeak3.11alpha [latest update: #8824]

SecurityManager state:
Restricted: false
FileAccess: true
SocketAccess: true
Working Dir /home/squeaksource
Trusted Dir /home/squeaksource/secure
Untrusted Dir /home/squeaksource/My Squeak

MCClassDefinition(Object)>>error:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                aString:        'Unrecognized class type'
        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

MCClassDefinition>>kindOfSubclass
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:

        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

MCClassDefinition>>printDefinitionOn:
        Receiver: a MCClassDefinition(Character)
        Arguments and temporary variables:
                stream:         a WriteStream
        Receiver's instance variables:
                name:   #Character
                superclassName:         #Magnitude
                variables:      an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...
                category:       #'Collections-Strings'
                type:   #immediate
                comment:        'I represent a character by storing its associated Unicode. The first ...etc...
                commentStamp:   'ar 4/9/2005 22:35'
                traitComposition:       nil
                classTraitComposition:  nil

[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
        Receiver: a MCDiffyTextWriter
        Arguments and temporary variables:
                definition:     a WriteStream
                s:      a MCClassDefinition(Character)
        Receiver's instance variables:
                stream:         a WriteStream
                initStream:     nil


--- The full stack ---
MCClassDefinition(Object)>>error:
MCClassDefinition>>kindOfSubclass
MCClassDefinition>>printDefinitionOn:
[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>chunkContents:
MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:
MCDiffyTextWriter(MCStWriter)>>visitClassDefinition:
MCClassDefinition>>accept:
[] in MCDiffyTextWriter(MCTextWriter)>>visitInFork:
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
MCDiffyTextWriter(MCTextWriter)>>visitInFork:
MCDiffyTextWriter>>writePatchFrom:to:
MCDiffyTextWriter>>writeModification:
[] in MCDiffyTextWriter>>writePatch:
SortedCollection(OrderedCollection)>>do:
MCDiffyTextWriter>>writePatch:
SSDiffyTextWriter>>writePatch:
[] in SSDiffyTextWriter>>writeVersion:for:
BlockClosure>>on:do:
SSDiffyTextWriter>>writeVersion:for:
[] in SSEMailSubscription>>versionAdded:to:
BlockClosure>>on:do:
SSEMailSubscription>>versionAdded:to:
[] in [] in SSProject>>versionAdded:
[] in BlockClosure>>newProcess




--
best,
Eliot