The Trunk: HelpSystem-Core-mt.119.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: HelpSystem-Core-mt.119.mcz

commits-2
Marcel Taeumel uploaded a new version of HelpSystem-Core to project The Trunk:
http://source.squeak.org/trunk/HelpSystem-Core-mt.119.mcz

==================== Summary ====================

Name: HelpSystem-Core-mt.119
Author: mt
Time: 13 February 2020, 2:25:35.668714 pm
UUID: df92a1e9-bfbe-584c-83b8-afb5bec801a7
Ancestors: HelpSystem-Core-mt.118

Fixes window title for help browsers to behave like other browsers, i.e., the system (code) browser. Makes window listing more useful. See screenshot.

=============== Diff against HelpSystem-Core-mt.118 ===============

Item was changed:
  ----- Method: HelpBrowser>>buildTreeWith: (in category 'toolbuilder') -----
  buildTreeWith: builder
 
  ^ builder pluggableTreeSpec new
  model: self;
  nodeClass: HelpTopicListItemWrapper;
  roots: #toplevelTopics;
  getSelected: #currentTopic;
  setSelected: #currentTopic:;
  getSelectedPath: #currentTopicPath;
+ setSelectedPath: #noteTopicPath:;
  setSelectedParent: #currentParentTopic:;
  autoDeselect: false;
  frame: (LayoutFrame
  fractions: (0@0 corner: 0.3@1)
  offsets: (0@ (Preferences standardDefaultTextFont height * 2) corner: 0@0));
  yourself!

Item was changed:
  ----- Method: HelpBrowser>>currentTopicPath (in category 'accessing') -----
  currentTopicPath
- "Only used for dynamic dispatch. Should be nil or empty on manual evaluation. See #topic:."
 
  ^ topicPath ifNil: [#()]!

Item was added:
+ ----- Method: HelpBrowser>>noteTopicPath: (in category 'accessing') -----
+ noteTopicPath: someTopics
+ "Keep track of the current topic path as reported by the view through manual selection."
+
+ topicPath := someTopics.
+ self changed: #windowTitle.
+ !

Item was changed:
  ----- Method: HelpBrowser>>windowTitle (in category 'accessing - ui') -----
  windowTitle
 
+ ^ '{1}: {2}' format: {
+ self rootTopic
+ ifNil: ['Help Browser' translated]
+ ifNotNil: [:topic | topic title].
+ (self currentTopicPath collect: [:topic | topic title])
+ reversed joinSeparatedBy: ' > '}!
- ^ self rootTopic
- ifNil: ['Help Browser']
- ifNotNil: [:topic | topic title]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: HelpSystem-Core-mt.119.mcz

marcel.taeumel
<http://forum.world.st/file/t370078/help-browser-window-title.png>


commits-2 wrote

> Marcel Taeumel uploaded a new version of HelpSystem-Core to project The
> Trunk:
> http://source.squeak.org/trunk/HelpSystem-Core-mt.119.mcz
>
> ==================== Summary ====================
>
> Name: HelpSystem-Core-mt.119
> Author: mt
> Time: 13 February 2020, 2:25:35.668714 pm
> UUID: df92a1e9-bfbe-584c-83b8-afb5bec801a7
> Ancestors: HelpSystem-Core-mt.118
>
> Fixes window title for help browsers to behave like other browsers, i.e.,
> the system (code) browser. Makes window listing more useful. See
> screenshot.
>
> =============== Diff against HelpSystem-Core-mt.118 ===============
>
> Item was changed:
>   ----- Method: HelpBrowser>>buildTreeWith: (in category 'toolbuilder')
> -----
>   buildTreeWith: builder
>  
>   ^ builder pluggableTreeSpec new
>   model: self;
>   nodeClass: HelpTopicListItemWrapper;
>   roots: #toplevelTopics;
>   getSelected: #currentTopic;
>   setSelected: #currentTopic:;
>   getSelectedPath: #currentTopicPath;
> + setSelectedPath: #noteTopicPath:;
>   setSelectedParent: #currentParentTopic:;
>   autoDeselect: false;
>   frame: (LayoutFrame
>   fractions: (0@0 corner: 0.3@1)
>   offsets: (0@ (Preferences standardDefaultTextFont height * 2) corner:
> 0@0));
>   yourself!
>
> Item was changed:
>   ----- Method: HelpBrowser>>currentTopicPath (in category 'accessing')
> -----
>   currentTopicPath
> - "Only used for dynamic dispatch. Should be nil or empty on manual
> evaluation. See #topic:."
>  
>   ^ topicPath ifNil: [#()]!
>
> Item was added:
> + ----- Method: HelpBrowser>>noteTopicPath: (in category 'accessing')
> -----
> + noteTopicPath: someTopics
> + "Keep track of the current topic path as reported by the view through
> manual selection."
> +
> + topicPath := someTopics.
> + self changed: #windowTitle.
> + !
>
> Item was changed:
>   ----- Method: HelpBrowser>>windowTitle (in category 'accessing - ui')
> -----
>   windowTitle
>  
> + ^ '{1}: {2}' format: {
> + self rootTopic
> + ifNil: ['Help Browser' translated]
> + ifNotNil: [:topic | topic title].
> + (self currentTopicPath collect: [:topic | topic title])
> + reversed joinSeparatedBy: ' > '}!
> - ^ self rootTopic
> - ifNil: ['Help Browser']
> - ifNotNil: [:topic | topic title]!





--
Sent from: http://forum.world.st/Squeak-Dev-f45488.html

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: HelpSystem-Core-mt.119.mcz

David T. Lewis
Thanks, it looks good.

Thanks also for providing the graphic as a link, it's much easier
for me to see this way.

Dave

p.s. Welcome back :-)

On Thu, Feb 13, 2020 at 07:29:36AM -0600, marcel.taeumel wrote:

> <http://forum.world.st/file/t370078/help-browser-window-title.png>
>
>
> commits-2 wrote
> > Marcel Taeumel uploaded a new version of HelpSystem-Core to project The
> > Trunk:
> > http://source.squeak.org/trunk/HelpSystem-Core-mt.119.mcz
> >
> > ==================== Summary ====================
> >
> > Name: HelpSystem-Core-mt.119
> > Author: mt
> > Time: 13 February 2020, 2:25:35.668714 pm
> > UUID: df92a1e9-bfbe-584c-83b8-afb5bec801a7
> > Ancestors: HelpSystem-Core-mt.118
> >
> > Fixes window title for help browsers to behave like other browsers, i.e.,
> > the system (code) browser. Makes window listing more useful. See
> > screenshot.
> >
> > =============== Diff against HelpSystem-Core-mt.118 ===============
> >
> > Item was changed:
> >   ----- Method: HelpBrowser>>buildTreeWith: (in category 'toolbuilder')
> > -----
> >   buildTreeWith: builder
> >  
> >   ^ builder pluggableTreeSpec new
> >   model: self;
> >   nodeClass: HelpTopicListItemWrapper;
> >   roots: #toplevelTopics;
> >   getSelected: #currentTopic;
> >   setSelected: #currentTopic:;
> >   getSelectedPath: #currentTopicPath;
> > + setSelectedPath: #noteTopicPath:;
> >   setSelectedParent: #currentParentTopic:;
> >   autoDeselect: false;
> >   frame: (LayoutFrame
> >   fractions: (0@0 corner: 0.3@1)
> >   offsets: (0@ (Preferences standardDefaultTextFont height * 2) corner:
> > 0@0));
> >   yourself!
> >
> > Item was changed:
> >   ----- Method: HelpBrowser>>currentTopicPath (in category 'accessing')
> > -----
> >   currentTopicPath
> > - "Only used for dynamic dispatch. Should be nil or empty on manual
> > evaluation. See #topic:."
> >  
> >   ^ topicPath ifNil: [#()]!
> >
> > Item was added:
> > + ----- Method: HelpBrowser>>noteTopicPath: (in category 'accessing')
> > -----
> > + noteTopicPath: someTopics
> > + "Keep track of the current topic path as reported by the view through
> > manual selection."
> > +
> > + topicPath := someTopics.
> > + self changed: #windowTitle.
> > + !
> >
> > Item was changed:
> >   ----- Method: HelpBrowser>>windowTitle (in category 'accessing - ui')
> > -----
> >   windowTitle
> >  
> > + ^ '{1}: {2}' format: {
> > + self rootTopic
> > + ifNil: ['Help Browser' translated]
> > + ifNotNil: [:topic | topic title].
> > + (self currentTopicPath collect: [:topic | topic title])
> > + reversed joinSeparatedBy: ' > '}!
> > - ^ self rootTopic
> > - ifNil: ['Help Browser']
> > - ifNotNil: [:topic | topic title]!
>
>
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: HelpSystem-Core-mt.119.mcz

marcel.taeumel
Thanks also for providing the graphic as a link, it's much easier
for me to see this way.

I think that happened because I posted through nabble. 

p.s. Welcome back :-)

Thanks :-)

Best,
Marcel

Am 13.02.2020 14:38:42 schrieb David T. Lewis <[hidden email]>:

Thanks, it looks good.

Thanks also for providing the graphic as a link, it's much easier
for me to see this way.

Dave

p.s. Welcome back :-)

On Thu, Feb 13, 2020 at 07:29:36AM -0600, marcel.taeumel wrote:
>
>
>
> commits-2 wrote
> > Marcel Taeumel uploaded a new version of HelpSystem-Core to project The
> > Trunk:
> > http://source.squeak.org/trunk/HelpSystem-Core-mt.119.mcz
> >
> > ==================== Summary ====================
> >
> > Name: HelpSystem-Core-mt.119
> > Author: mt
> > Time: 13 February 2020, 2:25:35.668714 pm
> > UUID: df92a1e9-bfbe-584c-83b8-afb5bec801a7
> > Ancestors: HelpSystem-Core-mt.118
> >
> > Fixes window title for help browsers to behave like other browsers, i.e.,
> > the system (code) browser. Makes window listing more useful. See
> > screenshot.
> >
> > =============== Diff against HelpSystem-Core-mt.118 ===============
> >
> > Item was changed:
> > ----- Method: HelpBrowser>>buildTreeWith: (in category 'toolbuilder')
> > -----
> > buildTreeWith: builder
> >
> > ^ builder pluggableTreeSpec new
> > model: self;
> > nodeClass: HelpTopicListItemWrapper;
> > roots: #toplevelTopics;
> > getSelected: #currentTopic;
> > setSelected: #currentTopic:;
> > getSelectedPath: #currentTopicPath;
> > + setSelectedPath: #noteTopicPath:;
> > setSelectedParent: #currentParentTopic:;
> > autoDeselect: false;
> > frame: (LayoutFrame
> > fractions: (0@0 corner: 0.3@1)
> > offsets: (0@ (Preferences standardDefaultTextFont height * 2) corner:
> > 0@0));
> > yourself!
> >
> > Item was changed:
> > ----- Method: HelpBrowser>>currentTopicPath (in category 'accessing')
> > -----
> > currentTopicPath
> > - "Only used for dynamic dispatch. Should be nil or empty on manual
> > evaluation. See #topic:."
> >
> > ^ topicPath ifNil: [#()]!
> >
> > Item was added:
> > + ----- Method: HelpBrowser>>noteTopicPath: (in category 'accessing')
> > -----
> > + noteTopicPath: someTopics
> > + "Keep track of the current topic path as reported by the view through
> > manual selection."
> > +
> > + topicPath := someTopics.
> > + self changed: #windowTitle.
> > + !
> >
> > Item was changed:
> > ----- Method: HelpBrowser>>windowTitle (in category 'accessing - ui')
> > -----
> > windowTitle
> >
> > + ^ '{1}: {2}' format: {
> > + self rootTopic
> > + ifNil: ['Help Browser' translated]
> > + ifNotNil: [:topic | topic title].
> > + (self currentTopicPath collect: [:topic | topic title])
> > + reversed joinSeparatedBy: ' > '}!
> > - ^ self rootTopic
> > - ifNil: ['Help Browser']
> > - ifNotNil: [:topic | topic title]!
>
>
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: HelpSystem-Core-mt.119.mcz

Christoph Thiede

Thanks also for providing the graphic as a link, it's much easier for me to see this way.


I'm happy about any picture Marcel is sending to us, but actually I find inlined picture much easier to view than those that require me to open an extra link ...

Best,
Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 13. Februar 2020 15:03:51
An: JOHN SARKELA via Squeak-dev
Betreff: Re: [squeak-dev] The Trunk: HelpSystem-Core-mt.119.mcz
 
Thanks also for providing the graphic as a link, it's much easier
for me to see this way.

I think that happened because I posted through nabble. 

p.s. Welcome back :-)

Thanks :-)

Best,
Marcel

Am 13.02.2020 14:38:42 schrieb David T. Lewis <[hidden email]>:

Thanks, it looks good.

Thanks also for providing the graphic as a link, it's much easier
for me to see this way.

Dave

p.s. Welcome back :-)

On Thu, Feb 13, 2020 at 07:29:36AM -0600, marcel.taeumel wrote:
>
>
>
> commits-2 wrote
> > Marcel Taeumel uploaded a new version of HelpSystem-Core to project The
> > Trunk:
> > http://source.squeak.org/trunk/HelpSystem-Core-mt.119.mcz
> >
> > ==================== Summary ====================
> >
> > Name: HelpSystem-Core-mt.119
> > Author: mt
> > Time: 13 February 2020, 2:25:35.668714 pm
> > UUID: df92a1e9-bfbe-584c-83b8-afb5bec801a7
> > Ancestors: HelpSystem-Core-mt.118
> >
> > Fixes window title for help browsers to behave like other browsers, i.e.,
> > the system (code) browser. Makes window listing more useful. See
> > screenshot.
> >
> > =============== Diff against HelpSystem-Core-mt.118 ===============
> >
> > Item was changed:
> > ----- Method: HelpBrowser>>buildTreeWith: (in category 'toolbuilder')
> > -----
> > buildTreeWith: builder
> >
> > ^ builder pluggableTreeSpec new
> > model: self;
> > nodeClass: HelpTopicListItemWrapper;
> > roots: #toplevelTopics;
> > getSelected: #currentTopic;
> > setSelected: #currentTopic:;
> > getSelectedPath: #currentTopicPath;
> > + setSelectedPath: #noteTopicPath:;
> > setSelectedParent: #currentParentTopic:;
> > autoDeselect: false;
> > frame: (LayoutFrame
> > fractions: (0@0 corner: 0.3@1)
> > offsets: (0@ (Preferences standardDefaultTextFont height * 2) corner:
> > 0@0));
> > yourself!
> >
> > Item was changed:
> > ----- Method: HelpBrowser>>currentTopicPath (in category 'accessing')
> > -----
> > currentTopicPath
> > - "Only used for dynamic dispatch. Should be nil or empty on manual
> > evaluation. See #topic:."
> >
> > ^ topicPath ifNil: [#()]!
> >
> > Item was added:
> > + ----- Method: HelpBrowser>>noteTopicPath: (in category 'accessing')
> > -----
> > + noteTopicPath: someTopics
> > + "Keep track of the current topic path as reported by the view through
> > manual selection."
> > +
> > + topicPath := someTopics.
> > + self changed: #windowTitle.
> > + !
> >
> > Item was changed:
> > ----- Method: HelpBrowser>>windowTitle (in category 'accessing - ui')
> > -----
> > windowTitle
> >
> > + ^ '{1}: {2}' format: {
> > + self rootTopic
> > + ifNil: ['Help Browser' translated]
> > + ifNotNil: [:topic | topic title].
> > + (self currentTopicPath collect: [:topic | topic title])
> > + reversed joinSeparatedBy: ' > '}!
> > - ^ self rootTopic
> > - ifNil: ['Help Browser']
> > - ifNotNil: [:topic | topic title]!
>
>
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>