Quantcast

The Trunk: Monticello-eem.666.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

The Trunk: Monticello-eem.666.mcz

commits-2
Eliot Miranda uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-eem.666.mcz

==================== Summary ====================

Name: Monticello-eem.666
Author: eem
Time: 13 March 2017, 7:16:29.454362 pm
UUID: f527e844-d0de-4339-b0cd-f4052cf67d38
Ancestors: Monticello-ul.665

Remove an unnecessary block in MCRepositoryInspector>>versionList.
Fix a bug in MCCacheRepository>>versionInfoForFileNamed: (it has a cache, but no infoCache).

=============== Diff against Monticello-ul.665 ===============

Item was changed:
  ----- Method: MCCacheRepository>>versionInfoForFileNamed: (in category 'as yet unclassified') -----
  versionInfoForFileNamed: aString
+ ^ cache at: aString ifAbsentPut: [self versionReaderForFileNamed: aString do: [:r | r info]]!
- ^ self infoCache at: aString ifAbsentPut: [self versionReaderForFileNamed: aString do: [:r | r info]]!

Item was changed:
  ----- Method: MCRepositoryInspector>>versionList (in category 'morphic ui') -----
  versionList
  | result |
  result := selectedPackage
+ ifNil: [ self versionNamesForNoPackageSelection ]
+ ifNotNil: [ self versionNamesForSelectedPackage ].
- ifNil: [ self versionNamesForNoPackageSelection ]
- ifNotNil: [ self versionNamesForSelectedPackage ].
  (self orderSpecs at: order) value ifNotNil:
+ [ : sortBlock |
+ result sort: sortBlock ].
+ ^result collect:
- [ : sortBlock | result sort:
- [ : a : b |  sortBlock
- value: a
- value: b ] ].
- ^ result collect:
  [ : each | self versionHighlight: each ]!


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: The Trunk: Monticello-eem.666.mcz

Eliot Miranda-2


On Mon, Mar 13, 2017 at 7:16 PM, <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-eem.666.mcz

==================== Summary ====================

Name: Monticello-eem.666

I have a bad feeling about this ;-)
 
Author: eem
Time: 13 March 2017, 7:16:29.454362 pm
UUID: f527e844-d0de-4339-b0cd-f4052cf67d38
Ancestors: Monticello-ul.665

Remove an unnecessary block in MCRepositoryInspector>>versionList.
Fix a bug in MCCacheRepository>>versionInfoForFileNamed: (it has a cache, but no infoCache).

=============== Diff against Monticello-ul.665 ===============

Item was changed:
  ----- Method: MCCacheRepository>>versionInfoForFileNamed: (in category 'as yet unclassified') -----
  versionInfoForFileNamed: aString
+       ^ cache at: aString ifAbsentPut: [self versionReaderForFileNamed: aString do: [:r | r info]]!
-       ^ self infoCache at: aString ifAbsentPut: [self versionReaderForFileNamed: aString do: [:r | r info]]!

Item was changed:
  ----- Method: MCRepositoryInspector>>versionList (in category 'morphic ui') -----
  versionList
        | result |
        result := selectedPackage
+                               ifNil: [ self versionNamesForNoPackageSelection ]
+                               ifNotNil: [ self versionNamesForSelectedPackage ].
-               ifNil: [ self versionNamesForNoPackageSelection ]
-               ifNotNil: [ self versionNamesForSelectedPackage ].
        (self orderSpecs at: order) value ifNotNil:
+               [ : sortBlock |
+               result sort: sortBlock ].
+       ^result collect:
-               [ : sortBlock | result sort:
-                       [ : a : b |  sortBlock
-                               value: a
-                               value: b ] ].
-       ^ result collect:
                [ : each | self versionHighlight: each ]!





--
_,,,^..^,,,_
best, Eliot


Loading...