The Trunk: Monticello-jr.720.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Monticello-jr.720.mcz

commits-2
Marcel Taeumel uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-jr.720.mcz

==================== Summary ====================

Name: Monticello-jr.720
Author: jr
Time: 8 June 2020, 10:04:25.843513 pm
UUID: 3f24029f-dae5-e345-9060-d078beba7fcd
Ancestors: Monticello-mt.719

Load class traits only after the corresponding instance traits were loaded.

The Scanner expression comes from MCTraitDefinition>>requirements.

=============== Diff against Monticello-mt.719 ===============

Item was changed:
  ----- Method: MCClassDefinition>>requirements (in category 'comparing') -----
  requirements
  ^superclassName == #nil
  ifTrue: [self poolDictionaries]
+ ifFalse: [{ superclassName }, self poolDictionaries,
+ (self hasTraitComposition
+ ifTrue: [(Scanner new scanTokens: self traitComposition) flattened select: [:each | each first isUppercase]]
+ ifFalse: [#()])].!
- ifFalse: [{ superclassName }, self poolDictionaries]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Monticello-jr.720.mcz

Jakob Reschke-2
This change of mine triggers the bug with the false class requirements
due to wrong traitCompositions.
But the traitComposition itself is wrong and should be fixed.

Am Di., 9. Juni 2020 um 15:18 Uhr schrieb <[hidden email]>:

>
> Marcel Taeumel uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-jr.720.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-jr.720
> Author: jr
> Time: 8 June 2020, 10:04:25.843513 pm
> UUID: 3f24029f-dae5-e345-9060-d078beba7fcd
> Ancestors: Monticello-mt.719
>
> Load class traits only after the corresponding instance traits were loaded.
>
> The Scanner expression comes from MCTraitDefinition>>requirements.
>
> =============== Diff against Monticello-mt.719 ===============
>
> Item was changed:
>   ----- Method: MCClassDefinition>>requirements (in category 'comparing') -----
>   requirements
>         ^superclassName == #nil
>                 ifTrue: [self poolDictionaries]
> +               ifFalse: [{ superclassName }, self poolDictionaries,
> +                       (self hasTraitComposition
> +                               ifTrue: [(Scanner new scanTokens: self traitComposition) flattened select: [:each | each first isUppercase]]
> +                               ifFalse: [#()])].!
> -               ifFalse: [{ superclassName }, self poolDictionaries]!
>
>