The Trunk: Morphic-dtl.609.mcz

classic Classic list List threaded Threaded
3 messages Options
commits-2 commits-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

The Trunk: Morphic-dtl.609.mcz

David T. Lewis uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-dtl.609.mcz

==================== Summary ====================

Name: Morphic-dtl.609
Author: dtl
Time: 11 February 2012, 12:07:02.836 pm
UUID: 7e071de6-1409-44f1-aedb-e3f18075810d
Ancestors: Morphic-cmm.608

Make Connectors removable (almost).

Morph>>connections and Morph>>wantsEmbeddingsVocabulary are provided by package Connectors. Remove the stub implementations from Morphic and update Morph>>wantsConnectionVocabulary and Morph>>filterViewerCategoryDictionary: in package Etoys with #respondsTo: checks to break the package dependencies.

Allow Morph>>dismissMorph override to be removed from Connectors by adding the functionality to package Morphic, guarded by #respondsTo:

Follow up needed in Connectors:
Remove Morph>>dismissMorph override
Remove PasteUpMorph>>tellAllContents: override
Remove ObjectPropertiesMorph>>rebuild override

=============== Diff against Morphic-cmm.608 ===============

Item was removed:
- ----- Method: Morph>>connections (in category 'accessing') -----
- connections
- "Empty method in absence of connectors"
- ^ #()!

Item was changed:
  ----- Method: Morph>>dismissMorph (in category 'meta-actions') -----
  dismissMorph
+ "This is called from an explicit halo destroy/delete action.
+ So first disconnect all constraints to keep the graph up to date."
- "This is called from an explicit halo destroy/delete action."
 
+ (self respondsTo: #disconnectAllConstraints) "Connectors package"
+ ifTrue: [ self perform: #disconnectAllConstraints ].
+ (self respondsTo: #releaseGraphModels) "CGPrereqs package (Connectors)"
+ ifTrue: [ self perform: #releaseGraphModels ].
+ self releaseGraphModels.
+ self world ifNotNilDo:
+ [:w |  w abandonAllHalos; stopStepping: self].
- | w |
- w := self world ifNil:[^self].
- w abandonAllHalos; stopStepping: self.
  self delete!

Item was removed:
- ----- Method: Morph>>wantsEmbeddingsVocabulary (in category 'accessing') -----
- wantsEmbeddingsVocabulary
- "Empty method in absence of connectors"
- ^ false!


Chris Muller-3 Chris Muller-3
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: The Trunk: Morphic-dtl.609.mcz

Taking it that last mile thanks Dave!

Once we update the Connectors squeaksource project, then installing
the "head" release from SqueakMap will install the latest Connectors
packages.




On Sat, Feb 11, 2012 at 11:07 AM,  <[hidden email]> wrote:

> David T. Lewis uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-dtl.609.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-dtl.609
> Author: dtl
> Time: 11 February 2012, 12:07:02.836 pm
> UUID: 7e071de6-1409-44f1-aedb-e3f18075810d
> Ancestors: Morphic-cmm.608
>
> Make Connectors removable (almost).
>
> Morph>>connections and Morph>>wantsEmbeddingsVocabulary are provided by package Connectors. Remove the stub implementations from Morphic and update Morph>>wantsConnectionVocabulary and Morph>>filterViewerCategoryDictionary: in package Etoys with #respondsTo: checks to break the package dependencies.
>
> Allow Morph>>dismissMorph override to be removed from Connectors by adding the functionality to package Morphic, guarded by #respondsTo:
>
> Follow up needed in Connectors:
> Remove Morph>>dismissMorph override
> Remove PasteUpMorph>>tellAllContents: override
> Remove ObjectPropertiesMorph>>rebuild override
>
> =============== Diff against Morphic-cmm.608 ===============
>
> Item was removed:
> - ----- Method: Morph>>connections (in category 'accessing') -----
> - connections
> -       "Empty method in absence of connectors"
> -       ^ #()!
>
> Item was changed:
>  ----- Method: Morph>>dismissMorph (in category 'meta-actions') -----
>  dismissMorph
> +       "This is called from an explicit halo destroy/delete action.
> +       So first disconnect all constraints to keep the graph up to date."
> -       "This is called from an explicit halo destroy/delete action."
>
> +       (self respondsTo: #disconnectAllConstraints) "Connectors package"
> +               ifTrue: [ self perform: #disconnectAllConstraints ].
> +       (self respondsTo: #releaseGraphModels) "CGPrereqs package (Connectors)"
> +               ifTrue: [ self perform: #releaseGraphModels ].
> +       self releaseGraphModels.
> +       self world ifNotNilDo:
> +                       [:w |  w abandonAllHalos; stopStepping: self].
> -       | w |
> -       w := self world ifNil:[^self].
> -       w abandonAllHalos; stopStepping: self.
>        self delete!
>
> Item was removed:
> - ----- Method: Morph>>wantsEmbeddingsVocabulary (in category 'accessing') -----
> - wantsEmbeddingsVocabulary
> -       "Empty method in absence of connectors"
> -       ^ false!
>
>

David T. Lewis David T. Lewis
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: The Trunk: Morphic-dtl.609.mcz

On Sat, Feb 11, 2012 at 06:15:39PM -0600, Chris Muller wrote:
> Taking it that last mile thanks Dave!
>
> Once we update the Connectors squeaksource project, then installing
> the "head" release from SqueakMap will install the latest Connectors
> packages.
>

Perfect :)

I have not actually tried removing Connectors (why would anyone want to
do such a thing ;-) so I might have missed some package dependencies,
but hopefully this is all of them.

Dave


>
>
>
> On Sat, Feb 11, 2012 at 11:07 AM,  <[hidden email]> wrote:
> > David T. Lewis uploaded a new version of Morphic to project The Trunk:
> > http://source.squeak.org/trunk/Morphic-dtl.609.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Morphic-dtl.609
> > Author: dtl
> > Time: 11 February 2012, 12:07:02.836 pm
> > UUID: 7e071de6-1409-44f1-aedb-e3f18075810d
> > Ancestors: Morphic-cmm.608
> >
> > Make Connectors removable (almost).
> >
> > Morph>>connections and Morph>>wantsEmbeddingsVocabulary are provided by package Connectors. Remove the stub implementations from Morphic and update Morph>>wantsConnectionVocabulary and Morph>>filterViewerCategoryDictionary: in package Etoys with #respondsTo: checks to break the package dependencies.
> >
> > Allow Morph>>dismissMorph override to be removed from Connectors by adding the functionality to package Morphic, guarded by #respondsTo:
> >
> > Follow up needed in Connectors:
> > Remove Morph>>dismissMorph override
> > Remove PasteUpMorph>>tellAllContents: override
> > Remove ObjectPropertiesMorph>>rebuild override
> >
> > =============== Diff against Morphic-cmm.608 ===============
> >
> > Item was removed:
> > - ----- Method: Morph>>connections (in category 'accessing') -----
> > - connections
> > - ?? ?? ?? "Empty method in absence of connectors"
> > - ?? ?? ?? ^ #()!
> >
> > Item was changed:
> > ??----- Method: Morph>>dismissMorph (in category 'meta-actions') -----
> > ??dismissMorph
> > + ?? ?? ?? "This is called from an explicit halo destroy/delete action.
> > + ?? ?? ?? So first disconnect all constraints to keep the graph up to date."
> > - ?? ?? ?? "This is called from an explicit halo destroy/delete action."
> >
> > + ?? ?? ?? (self respondsTo: #disconnectAllConstraints) "Connectors package"
> > + ?? ?? ?? ?? ?? ?? ?? ifTrue: [ self perform: #disconnectAllConstraints ].
> > + ?? ?? ?? (self respondsTo: #releaseGraphModels) "CGPrereqs package (Connectors)"
> > + ?? ?? ?? ?? ?? ?? ?? ifTrue: [ self perform: #releaseGraphModels ].
> > + ?? ?? ?? self releaseGraphModels.
> > + ?? ?? ?? self world ifNotNilDo:
> > + ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? [:w | ??w abandonAllHalos; stopStepping: self].
> > - ?? ?? ?? | w |
> > - ?? ?? ?? w := self world ifNil:[^self].
> > - ?? ?? ?? w abandonAllHalos; stopStepping: self.
> > ?? ?? ?? ??self delete!
> >
> > Item was removed:
> > - ----- Method: Morph>>wantsEmbeddingsVocabulary (in category 'accessing') -----
> > - wantsEmbeddingsVocabulary
> > - ?? ?? ?? "Empty method in absence of connectors"
> > - ?? ?? ?? ^ false!
> >
> >

Loading...