Eliot Miranda uploaded a new version of Morphic to project The Trunk:
==================== Summary ====================
Time: 29 November 2019, 4:50:37.46714 pm
Have seNders in the text editor also look up references to literals.
=============== Diff against Morphic-mt.1595 ===============
Item was changed:
----- Method: TextEditor>>selectedSelector (in category 'menu messages') -----
"Try to make a selector out of the current text selection"
+ | tokens |
+ tokens := Scanner new typedScanTokens: self selection string.
+ ^tokens isEmpty ifFalse: [tokens first]!
- ^self selection string findSelector!
Item was changed:
----- Method: TextEditor>>sendersOfIt (in category 'menu messages') -----
"Open a senders browser on the selected selector"
- | aSelector |
self lineSelectAndEmptyCheck: [^ self].
+ self selectedSelector ifNotNil:
+ [:aSelector| ^self systemNavigation browseAllCallsOn: aSelector].
+ self selectedLiteral ifNotNil:
+ [:aLiteral| ^self systemNavigation browseAllCallsOn: aLiteral].
+ morph flash!
- (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].
- self systemNavigation browseAllCallsOn: aSelector!
I don't think this works as expected. Please take a look at StringTest >> testFindSelector. The semantics of String >> #findSelector and Scanner >> #typedScanTokens: seem quite different.
Also, you forgot to commit TextEditor >> #selectedLiteral to make #sendersOfIt work as you intended.
Should we roll back this commit and polish it through the inbox first? ;-)
More importantly: what do you mean by "also look up references to literals"? This is already happening. See implementors of #allLiteralsDo:.
Or are you referring to the to-dos in CompiledCode >> #allLiteralsDo: and CompiledMethod >> #allLiteralsDo:?
|Free forum by Nabble||Edit this page|