The Trunk: Morphic-kfr.1415.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-kfr.1415.mcz

commits-2
Karl Ramberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-kfr.1415.mcz

==================== Summary ====================

Name: Morphic-kfr.1415
Author: kfr
Time: 16 April 2018, 9:00:44.326565 pm
UUID: fd7edd49-a300-764f-8d5d-fa2d2ad7b65b
Ancestors: Morphic-mt.1414

self world can be nil here

=============== Diff against Morphic-mt.1414 ===============

Item was changed:
  ----- Method: Morph>>openNear: (in category 'initialization') -----
  openNear: aRectangle
  self
  openNear: aRectangle
+ in: Project current world!
- in: self world!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.1415.mcz

Eliot Miranda-2
Hi Karl,

On Mon, Apr 16, 2018 at 12:01 PM, <[hidden email]> wrote:
Karl Ramberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-kfr.1415.mcz

==================== Summary ====================

Name: Morphic-kfr.1415
Author: kfr
Time: 16 April 2018, 9:00:44.326565 pm
UUID: fd7edd49-a300-764f-8d5d-fa2d2ad7b65b
Ancestors: Morphic-mt.1414

self world can be nil here

=============== Diff against Morphic-mt.1414 ===============

Item was changed:
  ----- Method: Morph>>openNear: (in category 'initialization') -----
  openNear: aRectangle
        self
                openNear: aRectangle
+               in: Project current world!
-               in: self world!

Shouldn't that be 
 
             in: (self world ifNil: [Project current world])

?  If one were using an arbitrary world in which one asked a Morph to open, wouldn't it be strange if that child morph opened up not in the world of the parent but in the current world?  Isn't this important enough to provide an accessor such as 
Morph>>world access
    theBestOfAllPossibleWorlds
        ^self world ifNil: [Project current world]

_,,,^..^,,,_
best, Candide


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.1415.mcz

marcel.taeumel
Hi, there.

Just replicate the behavior of #openInWorld, which uses "self currentWorld".

Best,
Marcel

Am 16.04.2018 21:32:21 schrieb Eliot Miranda <[hidden email]>:

Hi Karl,

On Mon, Apr 16, 2018 at 12:01 PM, <[hidden email]> wrote:
Karl Ramberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-kfr.1415.mcz

==================== Summary ====================

Name: Morphic-kfr.1415
Author: kfr
Time: 16 April 2018, 9:00:44.326565 pm
UUID: fd7edd49-a300-764f-8d5d-fa2d2ad7b65b
Ancestors: Morphic-mt.1414

self world can be nil here

=============== Diff against Morphic-mt.1414 ===============

Item was changed:
  ----- Method: Morph>>openNear: (in category 'initialization') -----
  openNear: aRectangle
        self
                openNear: aRectangle
+               in: Project current world!
-               in: self world!

Shouldn't that be 
 
             in: (self world ifNil: [Project current world])

?  If one were using an arbitrary world in which one asked a Morph to open, wouldn't it be strange if that child morph opened up not in the world of the parent but in the current world?  Isn't this important enough to provide an accessor such as 
Morph>>world access
    theBestOfAllPossibleWorlds
        ^self world ifNil: [Project current world]

_,,,^..^,,,_
best, Candide


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.1415.mcz

Karl Ramberg
Hi,
I followed Marcel's advise

Best,
Karl

On Tue, Apr 17, 2018 at 7:52 AM, Marcel Taeumel <[hidden email]> wrote:
Hi, there.

Just replicate the behavior of #openInWorld, which uses "self currentWorld".

Best,
Marcel

Am 16.04.2018 21:32:21 schrieb Eliot Miranda <[hidden email]>:

Hi Karl,

On Mon, Apr 16, 2018 at 12:01 PM, <[hidden email]> wrote:
Karl Ramberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-kfr.1415.mcz

==================== Summary ====================

Name: Morphic-kfr.1415
Author: kfr
Time: 16 April 2018, 9:00:44.326565 pm
UUID: fd7edd49-a300-764f-8d5d-fa2d2ad7b65b
Ancestors: Morphic-mt.1414

self world can be nil here

=============== Diff against Morphic-mt.1414 ===============

Item was changed:
  ----- Method: Morph>>openNear: (in category 'initialization') -----
  openNear: aRectangle
        self
                openNear: aRectangle
+               in: Project current world!
-               in: self world!

Shouldn't that be 
 
             in: (self world ifNil: [Project current world])

?  If one were using an arbitrary world in which one asked a Morph to open, wouldn't it be strange if that child morph opened up not in the world of the parent but in the current world?  Isn't this important enough to provide an accessor such as 
Morph>>world access
    theBestOfAllPossibleWorlds
        ^self world ifNil: [Project current world]

_,,,^..^,,,_
best, Candide